fix: remote addrs field cannot be empty

ironman0x7b2 · ironman0x7b2 · commit 412ec23004f4 · 2025-09-25T14:50:28.000+05:30
diff --git a/x/node/keeper/msg_handler.go b/x/node/keeper/msg_handler.go
@@ -101,8 +101,8 @@ func (k *Keeper) HandleMsgUpdateNodeDetails(ctx sdk.Context, msg *v3.MsgUpdateNo
 
 	// Apply updated prices and optional remote addrs
 	node.GigabytePrices = msg.GigabytePrices
-
 	node.HourlyPrices = msg.HourlyPrices
+
 	if len(msg.RemoteAddrs) > 0 {
 		node.RemoteAddrs = msg.RemoteAddrs
 	}
diff --git a/x/node/types/v3/msg.go b/x/node/types/v3/msg.go
@@ -59,6 +59,10 @@ func (m *MsgRegisterNodeRequest) ValidateBasic() error {
 		return types.NewErrorInvalidMessage("hourly_prices must be valid")
 	}
 
+	if len(m.RemoteAddrs) == 0 {
+		return types.NewErrorInvalidMessage("remote_addrs cannot be empty")
+	}
+
 	if err := validateRemoteAddrs(m.RemoteAddrs); err != nil {
 		return types.NewErrorInvalidMessage(fmt.Errorf("invalid remote_addrs: %w", err))
 	}

Original file line number	Diff line number	Diff line change
`@@ -101,8 +101,8 @@ func (k Keeper) HandleMsgUpdateNodeDetails(ctx sdk.Context, msg v3.MsgUpdateNo`
`101`	`101`
`102`	`102`	`// Apply updated prices and optional remote addrs`
`103`	`103`	`node.GigabytePrices = msg.GigabytePrices`
`104`		`-`
`105`	`104`	`node.HourlyPrices = msg.HourlyPrices`
	`105`	`+`
`106`	`106`	`if len(msg.RemoteAddrs) > 0 {`
`107`	`107`	`node.RemoteAddrs = msg.RemoteAddrs`
`108`	`108`	`}`
Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,10 @@ func (m *MsgRegisterNodeRequest) ValidateBasic() error {`
`59`	`59`	`return types.NewErrorInvalidMessage("hourly_prices must be valid")`
`60`	`60`	`}`
`61`	`61`
	`62`	`+ if len(m.RemoteAddrs) == 0 {`
	`63`	`+ return types.NewErrorInvalidMessage("remote_addrs cannot be empty")`
	`64`	`+ }`
	`65`	`+`
`62`	`66`	`if err := validateRemoteAddrs(m.RemoteAddrs); err != nil {`
`63`	`67`	`return types.NewErrorInvalidMessage(fmt.Errorf("invalid remote_addrs: %w", err))`
`64`	`68`	`}`