fix: add missing base app options

Author: ironman0x7b2

app/app.go

@@ -54,7 +54,7 @@ type App struct {
 func NewApp(
 	appOpts servertypes.AppOptions, bech32Prefix string, db tmdb.DB, encCfg EncodingConfig, homeDir string,
 	invCheckPeriod uint, loadLatest bool, logger tmlog.Logger, skipGenesisInvariants bool,
-	skipUpgradeHeights map[int64]bool, traceWriter io.Writer, version string, wasmOpts []wasmkeeper.Option,
+	traceWriter io.Writer, version string, skipUpgradeHeights map[int64]bool, wasmOpts []wasmkeeper.Option,
 	baseAppOpts ...func(*baseapp.BaseApp),
 ) *App {
 	baseApp := baseapp.NewBaseApp(appName, logger, db, encCfg.TxConfig.TxDecoder(), baseAppOpts...)

cmd/sentinelhub/app_creator.go

@@ -2,18 +2,13 @@ package main
 
 import (
 	"io"
-	"path/filepath"
 
 	wasmkeeper "github.com/CosmWasm/wasmd/x/wasm/keeper"
 	tmdb "github.com/cometbft/cometbft-db"
 	tmlog "github.com/cometbft/cometbft/libs/log"
-	tmtypes "github.com/cometbft/cometbft/types"
-	"github.com/cosmos/cosmos-sdk/baseapp"
 	"github.com/cosmos/cosmos-sdk/client/flags"
 	"github.com/cosmos/cosmos-sdk/server"
 	servertypes "github.com/cosmos/cosmos-sdk/server/types"
-	"github.com/cosmos/cosmos-sdk/store"
-	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/cosmos/cosmos-sdk/version"
 	"github.com/cosmos/cosmos-sdk/x/crisis"
 	"github.com/prometheus/client_golang/prometheus"
@@ -30,46 +25,23 @@ type appCreator struct {
 func (ac appCreator) NewApp(
 	logger tmlog.Logger, db tmdb.DB, traceWriter io.Writer, appOpts servertypes.AppOptions,
 ) servertypes.Application {
-	var cache sdk.MultiStorePersistentCache
-	if cast.ToBool(appOpts.Get(server.FlagInterBlockCache)) {
-		cache = store.NewCommitKVStoreCacheManager()
-	}
-
-	homeDir := cast.ToString(appOpts.Get(flags.FlagHome))
-
-	genDoc, err := tmtypes.GenesisDocFromFile(filepath.Join(homeDir, "config", "genesis.json"))
-	if err != nil {
-		panic(err)
-	}
+	baseAppOpts := server.DefaultBaseappOptions(appOpts)
 
 	skipUpgradeHeights := make(map[int64]bool)
 	for _, height := range cast.ToIntSlice(appOpts.Get(server.FlagUnsafeSkipUpgrades)) {
 		skipUpgradeHeights[int64(height)] = true
 	}
 
-	pruningOpts, err := server.GetPruningOptionsFromFlags(appOpts)
-	if err != nil {
-		panic(err)
-	}
-
 	var wasmOpts []wasmkeeper.Option
 	if cast.ToBool(appOpts.Get("telemetry.enabled")) {
 		wasmOpts = append(wasmOpts, wasmkeeper.WithVMCacheMetrics(prometheus.DefaultRegisterer))
 	}
 
 	return app.NewApp(
-		appOpts, base.Bech32MainPrefix, db, ac.encCfg, homeDir,
+		appOpts, base.Bech32MainPrefix, db, ac.encCfg, cast.ToString(appOpts.Get(flags.FlagHome)),
 		cast.ToUint(appOpts.Get(server.FlagInvCheckPeriod)), true, logger,
-		cast.ToBool(appOpts.Get(crisis.FlagSkipGenesisInvariants)), skipUpgradeHeights, traceWriter, version.Version,
-		wasmOpts, baseapp.SetChainID(genDoc.ChainID),
-		baseapp.SetHaltHeight(cast.ToUint64(appOpts.Get(server.FlagHaltHeight))),
-		baseapp.SetHaltTime(cast.ToUint64(appOpts.Get(server.FlagHaltTime))),
-		baseapp.SetIndexEvents(cast.ToStringSlice(appOpts.Get(server.FlagIndexEvents))),
-		baseapp.SetInterBlockCache(cache),
-		baseapp.SetMinGasPrices(cast.ToString(appOpts.Get(server.FlagMinGasPrices))),
-		baseapp.SetMinRetainBlocks(cast.ToUint64(appOpts.Get(server.FlagMinRetainBlocks))),
-		baseapp.SetPruning(pruningOpts),
-		baseapp.SetTrace(cast.ToBool(appOpts.Get(server.FlagTrace))),
+		cast.ToBool(appOpts.Get(crisis.FlagSkipGenesisInvariants)), traceWriter, version.Version,
+		skipUpgradeHeights, wasmOpts, baseAppOpts...,
 	)
 }
 
@@ -80,8 +52,8 @@ func (ac appCreator) AppExport(
 	v := app.NewApp(
 		appOpts, base.Bech32MainPrefix, db, ac.encCfg, cast.ToString(appOpts.Get(flags.FlagHome)),
 		cast.ToUint(appOpts.Get(server.FlagInvCheckPeriod)), height == -1, logger,
-		cast.ToBool(appOpts.Get(crisis.FlagSkipGenesisInvariants)), map[int64]bool{}, traceWriter,
-		version.Version, nil, nil,
+		cast.ToBool(appOpts.Get(crisis.FlagSkipGenesisInvariants)), traceWriter, version.Version,
+		map[int64]bool{}, nil,
 	)
 
 	if height != -1 {