feat: subscription plan details should not be updated

Author: ironman0x7b2

proto/sentinel/plan/v3/events.proto

@@ -36,6 +36,5 @@ message EventUnlinkNode {
 message EventUpdate {
   uint64 id = 1 [(gogoproto.customname) = "ID"];
   string prov_address = 2;
-  bool private = 3;
-  sentinel.types.v1.Status status = 4;
+  sentinel.types.v1.Status status = 3;
 }

proto/sentinel/plan/v3/msg.proto

@@ -39,12 +39,6 @@ message MsgUnlinkNodeRequest {
   string node_address = 3;
 }
 
-message MsgUpdatePlanDetailsRequest {
-  string from = 1;
-  uint64 id = 2 [(gogoproto.customname) = "ID"];
-  bool private = 3;
-}
-
 message MsgUpdatePlanStatusRequest {
   string from = 1;
   uint64 id = 2 [(gogoproto.customname) = "ID"];
@@ -67,8 +61,6 @@ message MsgLinkNodeResponse {}
 
 message MsgUnlinkNodeResponse {}
 
-message MsgUpdatePlanDetailsResponse {}
-
 message MsgUpdatePlanStatusResponse {}
 
 message MsgStartSessionResponse {
@@ -79,7 +71,6 @@ service MsgService {
   rpc MsgCreatePlan(MsgCreatePlanRequest) returns (MsgCreatePlanResponse);
   rpc MsgLinkNode(MsgLinkNodeRequest) returns (MsgLinkNodeResponse);
   rpc MsgUnlinkNode(MsgUnlinkNodeRequest) returns (MsgUnlinkNodeResponse);
-  rpc MsgUpdatePlanDetails(MsgUpdatePlanDetailsRequest) returns (MsgUpdatePlanDetailsResponse);
   rpc MsgUpdatePlanStatus(MsgUpdatePlanStatusRequest) returns (MsgUpdatePlanStatusResponse);
   rpc MsgStartSession(MsgStartSessionRequest) returns (MsgStartSessionResponse);
 }

x/plan/client/cli/cli.go

@@ -21,7 +21,6 @@ func GetTxCommands() []*cobra.Command {
 		txCreatePlan(),
 		txLinkNode(),
 		txUnlinkNode(),
-		txUpdatePlanDetails(),
 		txUpdatePlanStatus(),
 	)
 

x/plan/client/cli/tx.go

@@ -146,45 +146,6 @@ func txUnlinkNode() *cobra.Command {
 	return cmd
 }
 
-func txUpdatePlanDetails() *cobra.Command {
-	cmd := &cobra.Command{
-		Use:   "update-plan-details [id] [private]",
-		Short: "Update the details of an existing subscription plan",
-		Args:  cobra.ExactArgs(2),
-		RunE: func(cmd *cobra.Command, args []string) error {
-			ctx, err := client.GetClientTxContext(cmd)
-			if err != nil {
-				return err
-			}
-
-			id, err := strconv.ParseUint(args[0], 10, 64)
-			if err != nil {
-				return err
-			}
-
-			private, err := strconv.ParseBool(args[1])
-			if err != nil {
-				return err
-			}
-
-			msg := v3.NewMsgUpdatePlanDetailsRequest(
-				ctx.FromAddress.Bytes(),
-				id,
-				private,
-			)
-			if err := msg.ValidateBasic(); err != nil {
-				return err
-			}
-
-			return tx.GenerateOrBroadcastTxCLI(ctx, cmd.Flags(), msg)
-		},
-	}
-
-	flags.AddTxFlagsToCmd(cmd)
-
-	return cmd
-}
-
 func txUpdatePlanStatus() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "update-plan-status [id] [status]",

x/plan/keeper/msg_handler.go

@@ -108,29 +108,6 @@ func (k *Keeper) HandleMsgUnlinkNode(ctx sdk.Context, msg *v3.MsgUnlinkNodeReque
 	return &v3.MsgUnlinkNodeResponse{}, nil
 }
 
-func (k *Keeper) HandleMsgUpdatePlanDetails(ctx sdk.Context, msg *v3.MsgUpdatePlanDetailsRequest) (*v3.MsgUpdatePlanDetailsResponse, error) {
-	plan, found := k.GetPlan(ctx, msg.ID)
-	if !found {
-		return nil, types.NewErrorPlanNotFound(msg.ID)
-	}
-	if msg.From != plan.ProvAddress {
-		return nil, types.NewErrorUnauthorized(msg.From)
-	}
-
-	plan.Private = msg.Private
-
-	k.SetPlan(ctx, plan)
-	ctx.EventManager().EmitTypedEvent(
-		&v3.EventUpdate{
-			ID:          plan.ID,
-			ProvAddress: plan.ProvAddress,
-			Private:     plan.Private,
-		},
-	)
-
-	return &v3.MsgUpdatePlanDetailsResponse{}, nil
-}
-
 func (k *Keeper) HandleMsgUpdatePlanStatus(ctx sdk.Context, msg *v3.MsgUpdatePlanStatusRequest) (*v3.MsgUpdatePlanStatusResponse, error) {
 	plan, found := k.GetPlan(ctx, msg.ID)
 	if !found {

x/plan/services/v3/msg_server.go

@@ -36,11 +36,6 @@ func (m *msgServer) MsgUnlinkNode(c context.Context, req *v3.MsgUnlinkNodeReques
 	return m.HandleMsgUnlinkNode(ctx, req)
 }
 
-func (m *msgServer) MsgUpdatePlanDetails(c context.Context, req *v3.MsgUpdatePlanDetailsRequest) (*v3.MsgUpdatePlanDetailsResponse, error) {
-	ctx := sdk.UnwrapSDKContext(c)
-	return m.HandleMsgUpdatePlanDetails(ctx, req)
-}
-
 func (m *msgServer) MsgUpdatePlanStatus(c context.Context, req *v3.MsgUpdatePlanStatusRequest) (*v3.MsgUpdatePlanStatusResponse, error) {
 	ctx := sdk.UnwrapSDKContext(c)
 	return m.HandleMsgUpdatePlanStatus(ctx, req)

x/plan/types/v3/events.pb.go

@@ -148,37 +148,6 @@ func (m *MsgUnlinkNodeRequest) GetSigners() []sdk.AccAddress {
 	return []sdk.AccAddress{from.Bytes()}
 }
 
-func NewMsgUpdatePlanDetailsRequest(from base.ProvAddress, id uint64, private bool) *MsgUpdatePlanDetailsRequest {
-	return &MsgUpdatePlanDetailsRequest{
-		From:    from.String(),
-		ID:      id,
-		Private: private,
-	}
-}
-
-func (m *MsgUpdatePlanDetailsRequest) ValidateBasic() error {
-	if m.From == "" {
-		return sdkerrors.Wrap(types.ErrorInvalidMessage, "from cannot be empty")
-	}
-	if _, err := base.ProvAddressFromBech32(m.From); err != nil {
-		return sdkerrors.Wrap(types.ErrorInvalidMessage, err.Error())
-	}
-	if m.ID == 0 {
-		return sdkerrors.Wrap(types.ErrorInvalidMessage, "id cannot be zero")
-	}
-
-	return nil
-}
-
-func (m *MsgUpdatePlanDetailsRequest) GetSigners() []sdk.AccAddress {
-	from, err := base.ProvAddressFromBech32(m.From)
-	if err != nil {
-		panic(err)
-	}
-
-	return []sdk.AccAddress{from.Bytes()}
-}
-
 func NewMsgUpdatePlanStatusRequest(from base.ProvAddress, id uint64, status v1base.Status) *MsgUpdatePlanStatusRequest {
 	return &MsgUpdatePlanStatusRequest{
 		From:   from.String(),