Skip to content

Commit fa434cc

Browse files
committed
chore(ci): bump golangci-lint
1 parent c2e5eb3 commit fa434cc

7 files changed

Lines changed: 63 additions & 47 deletions

File tree

.github/workflows/nightly-release.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ jobs:
3333
sudo apt update -qq
3434
sudo apt install -y -qq build-essential git sqlite3 libtag1-dev ffmpeg mpv zlib1g-dev
3535
- name: Lint
36-
uses: golangci/golangci-lint-action@v6
36+
uses: golangci/golangci-lint-action@v8
3737
with:
38-
version: v1.60
39-
args: --timeout=5m
38+
install-mode: goinstall
39+
version: v2.3.0
4040
- name: Test
4141
run: go test ./...
4242
build-release:

.github/workflows/release.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ jobs:
1919
sudo apt update -qq
2020
sudo apt install -y -qq build-essential git sqlite3 libtag1-dev ffmpeg mpv zlib1g-dev
2121
- name: Lint
22-
uses: golangci/golangci-lint-action@v6
22+
uses: golangci/golangci-lint-action@v8
2323
with:
24-
version: v1.60
25-
args: --timeout=5m
24+
install-mode: goinstall
25+
version: v2.3.0
2626
- name: Test
2727
run: go test ./...
2828
release-please:

.github/workflows/test.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ jobs:
2020
sudo apt update -qq
2121
sudo apt install -y -qq build-essential git sqlite3 libtag1-dev ffmpeg mpv zlib1g-dev
2222
- name: Lint
23-
uses: golangci/golangci-lint-action@v6
23+
uses: golangci/golangci-lint-action@v8
2424
with:
25-
version: v1.60
26-
args: --timeout=5m
25+
install-mode: goinstall
26+
version: v2.3.0
2727
- name: Test
2828
run: go test ./...

.golangci.yml

Lines changed: 50 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
version: "2"
12
linters:
2-
disable-all: true
3+
default: none
34
enable:
45
- asasalint
56
- asciicheck
@@ -14,8 +15,6 @@ linters:
1415
- errchkjson
1516
- errname
1617
- errorlint
17-
- execinquery
18-
- exportloopref
1918
- forbidigo
2019
- ginkgolinter
2120
- gocheckcompilerdirectives
@@ -24,13 +23,10 @@ linters:
2423
- goconst
2524
- gocritic
2625
- gocyclo
27-
- gofmt
2826
- goheader
29-
- goimports
3027
- gomodguard
3128
- goprintffuncname
3229
- gosec
33-
- gosimple
3430
- gosmopolitan
3531
- govet
3632
- grouper
@@ -51,40 +47,60 @@ linters:
5147
- rowserrcheck
5248
- sqlclosecheck
5349
- staticcheck
54-
- stylecheck
55-
- tenv
5650
- testableexamples
5751
- thelper
5852
- tparallel
59-
- typecheck
6053
- unconvert
6154
- unparam
6255
- unused
6356
- wastedassign
6457
- whitespace
6558
- zerologlint
66-
67-
issues:
68-
exclude-rules:
69-
- path: _test\.go
70-
linters:
71-
- errcheck
72-
- gochecknoglobals
73-
- text: "weak cryptographic primitive"
74-
linters:
75-
- gosec
76-
- text: "weak random number generator"
77-
linters:
78-
- gosec
79-
- text: "integer overflow conversion"
80-
linters:
81-
- gosec
82-
- text: "at least one file in a package should have a package comment"
83-
linters:
84-
- stylecheck
85-
- text: "should rewrite switch"
86-
linters:
87-
- gocritic
88-
exclude-dirs:
89-
- server/assets
90-
exclude-dirs-use-default: true
59+
exclusions:
60+
generated: lax
61+
presets:
62+
- comments
63+
- common-false-positives
64+
- legacy
65+
- std-error-handling
66+
rules:
67+
- linters:
68+
- errcheck
69+
- gochecknoglobals
70+
path: _test\.go
71+
- linters:
72+
- gosec
73+
text: weak cryptographic primitive
74+
- linters:
75+
- gosec
76+
text: weak random number generator
77+
- linters:
78+
- gosec
79+
text: integer overflow conversion
80+
- linters:
81+
- staticcheck
82+
text: at least one file in a package should have a package comment
83+
- linters:
84+
- gocritic
85+
text: should rewrite switch
86+
paths:
87+
- server/assets
88+
- third_party$
89+
- builtin$
90+
- examples$
91+
settings:
92+
staticcheck:
93+
checks:
94+
- all
95+
- "-QF1001"
96+
formatters:
97+
enable:
98+
- gofmt
99+
- goimports
100+
exclusions:
101+
generated: lax
102+
paths:
103+
- server/assets
104+
- third_party$
105+
- builtin$
106+
- examples$

db/migrations_old_models.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package db
22

33
import "time"
44

5-
type __OldPlaylist struct { //nolint: revive,stylecheck
5+
type __OldPlaylist struct { //nolint: staticcheck
66
ID int `gorm:"primary_key"`
77
CreatedAt time.Time
88
UpdatedAt time.Time

server/ctrlsubsonic/ctrl_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ const (
3939
)
4040

4141
const (
42-
audioPath5s = "testdata/audio/5s.flac" //nolint:deadcode,varcheck
43-
audioPath10s = "testdata/audio/10s.flac" //nolint:deadcode,varcheck
42+
audioPath5s = "testdata/audio/5s.flac"
43+
audioPath10s = "testdata/audio/10s.flac"
4444
)
4545

4646
type queryCase struct {

version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//nolint:gochecknoglobals,golint,stylecheck
1+
//nolint:gochecknoglobals
22
package gonic
33

44
import (

0 commit comments

Comments
 (0)