Skip to content

Commit 45f9ae9

Browse files
authored
feat(hook): ArgoCd Compatible Annotations for hook (#1977)
1 parent 0af7560 commit 45f9ae9

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

charts/sentry/templates/hooks/sentry-secret-create.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,13 @@ metadata:
99
release: "{{ .Release.Name }}"
1010
heritage: "{{ .Release.Service }}"
1111
annotations:
12+
{{- if .Values.useArgoCdCompatibleAnnotations }}
13+
"argocd.argoproj.io/hook": "Sync"
14+
"argocd.argoproj.io/sync-wave": "-1"
15+
{{- else }}
1216
"helm.sh/hook": "pre-install"
1317
"helm.sh/hook-weight": "3"
18+
{{- end }}
1419
type: Opaque
1520
data:
1621
key: {{ randAlphaNum 50 | b64enc | quote }}

charts/sentry/values.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3157,3 +3157,8 @@ pgbouncer:
31573157
# clientIP:
31583158
# timeoutSeconds: 180
31593159
sessionAffinityConfig: {}
3160+
3161+
# Helm hooks are similar to Argo CD hooks, but some of them are incompatible.
3162+
# Please refer to for details:
3163+
# https://argo-cd.readthedocs.io/en/stable/user-guide/helm/#helm-hooks
3164+
useArgoCdCompatibleAnnotations: false

0 commit comments

Comments
 (0)