Add binary codec and transaction models for MPT #203
e-desouzaAnnotations
63 warnings
|
the `Err`-variant returned from this function is very large:
src/bin/xrpl.rs#L2
warning: the `Err`-variant returned from this function is very large
--> src/bin/xrpl.rs:2:14
|
2 | fn main() -> Result<(), xrpl::cli::CliError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 144 bytes
|
= help: try reducing the size of `xrpl::cli::CliError`, for example by boxing large elements or replacing it with `Box<xrpl::cli::CliError>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
= note: `#[warn(clippy::result_large_err)]` on by default
|
|
hiding a lifetime that's elided elsewhere is confusing:
src/utils/parse_nftoken_id.rs#L55
warning: hiding a lifetime that's elided elsewhere is confusing
--> src/utils/parse_nftoken_id.rs:55:33
|
55 | pub fn parse_nftoken_id(nft_id: Cow<str>) -> XRPLUtilsResult<NFTokenId<'_>> {
| ^^^^^^^^ the lifetime is hidden here ^^ the same lifetime is elided here
|
= help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: consistently use `'_`
|
55 | pub fn parse_nftoken_id(nft_id: Cow<'_, str>) -> XRPLUtilsResult<NFTokenId<'_>> {
| +++
|
|
hiding a lifetime that's elided elsewhere is confusing:
src/models/transactions/mod.rs#L613
warning: hiding a lifetime that's elided elsewhere is confusing
--> src/models/transactions/mod.rs:613:17
|
613 | fn get_hash(&self) -> XRPLModelResult<Cow<str>>
| ^^^^^ ^^^^^^^^ the same lifetime is hidden here
| |
| the lifetime is elided here
|
= help: the same lifetime is referred to in inconsistent ways, making the signature confusing
= note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: use `'_` for type paths
|
613 | fn get_hash(&self) -> XRPLModelResult<Cow<'_, str>>
| +++
|
|
the `Err`-variant returned from this function is very large:
src/wallet/faucet_generation.rs#L19
warning: the `Err`-variant returned from this function is very large
--> src/wallet/faucet_generation.rs:19:6
|
19 | ) -> XRPLHelperResult<Wallet>
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true:
src/utils/txn_parser/utils/mod.rs#L39
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> src/utils/txn_parser/utils/mod.rs:39:1
|
39 | impl<'a> Into<Amount<'a>> for Balance<'a> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#from_over_into
= note: `#[warn(clippy::from_over_into)]` on by default
help: replace the `Into` implementation with `From<utils::txn_parser::utils::Balance<'a>>`
|
39 ~ impl<'a> From<Balance<'a>> for Amount<'a> {
40 ~ fn from(val: Balance<'a>) -> Self {
41 ~ if val.currency == "XRP" {
42 ~ Amount::XRPAmount(val.value.into())
43 | } else {
44 | Amount::IssuedCurrencyAmount(crate::models::IssuedCurrencyAmount {
45 ~ currency: val.currency,
46 ~ value: val.value,
47 ~ issuer: val.issuer.unwrap_or("".into()),
|
|
|
this creates an owned instance just for comparison:
src/utils/txn_parser/get_final_balances.rs#L29
warning: this creates an owned instance just for comparison
--> src/utils/txn_parser/get_final_balances.rs:29:17
|
29 | if value == BigDecimal::from(0) {
| ^^^^^^^^^^^^^^^^^^^ help: try: `0`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#cmp_owned
= note: `#[warn(clippy::cmp_owned)]` on by default
|
|
the `Err`-variant returned from this function is very large:
src/transaction/mod.rs#L118
warning: the `Err`-variant returned from this function is very large
--> src/transaction/mod.rs:118:6
|
118 | ) -> XRPLHelperResult<XRPAmount<'c>>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/transaction/mod.rs#L99
warning: the `Err`-variant returned from this function is very large
--> src/transaction/mod.rs:99:6
|
99 | ) -> XRPLHelperResult<TxVersionMap<'b>>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/transaction/mod.rs#L84
warning: the `Err`-variant returned from this function is very large
--> src/transaction/mod.rs:84:60
|
84 | pub fn submit<'a, T, F, C>(transaction: &T, client: &C) -> XRPLHelperResult<Submit<'a>>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/transaction/mod.rs#L70
warning: the `Err`-variant returned from this function is very large
--> src/transaction/mod.rs:70:6
|
70 | ) -> XRPLHelperResult<()>
| ^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/transaction/mod.rs#L56
warning: the `Err`-variant returned from this function is very large
--> src/transaction/mod.rs:56:6
|
56 | ) -> XRPLHelperResult<()>
| ^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/transaction/mod.rs#L37
warning: the `Err`-variant returned from this function is very large
--> src/transaction/mod.rs:37:6
|
37 | ) -> XRPLHelperResult<Submit<'a>>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/transaction/multisign.rs#L12
warning: the `Err`-variant returned from this function is very large
--> src/transaction/multisign.rs:12:73
|
12 | pub fn multisign<'a, T, F>(transaction: &mut T, tx_list: &'a Vec<T>) -> XRPLHelperResult<()>
| ^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
length comparison to zero:
src/models/transactions/mod.rs#L282
warning: length comparison to zero
--> src/models/transactions/mod.rs:282:65
|
282 | .all(|signer| signer.txn_signature.len() > 0 && signer.signing_pub_key.len() > 0)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!signer.signing_pub_key.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#len_zero
|
|
length comparison to zero:
src/models/transactions/mod.rs#L282
warning: length comparison to zero
--> src/models/transactions/mod.rs:282:31
|
282 | .all(|signer| signer.txn_signature.len() > 0 && signer.signing_pub_key.len() > 0)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!signer.txn_signature.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
|
|
called `unwrap` on `self.signer_entries` after checking its variant with `is_some`:
src/models/transactions/signer_list_set.rs#L135
warning: called `unwrap` on `self.signer_entries` after checking its variant with `is_some`
--> src/models/transactions/signer_list_set.rs:135:33
|
134 | if self.signer_entries.is_some() {
| -------------------------------- help: try: `if let Some(<item>) = &self.signer_entries`
135 | for signer_entry in self.signer_entries.as_ref().unwrap() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_unwrap
|
|
called `unwrap` on `self.clear_flag` after checking its variant with `is_some`:
src/models/transactions/account_set.rs#L257
warning: called `unwrap` on `self.clear_flag` after checking its variant with `is_some`
--> src/models/transactions/account_set.rs:257:24
|
254 | if self.clear_flag.is_some() && self.set_flag.is_some() && self.clear_flag == self.set_flag
| ------------------------- the check is happening here
...
257 | found: self.clear_flag.unwrap(),
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try using `match`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_unwrap
= note: `#[warn(clippy::unnecessary_unwrap)]` on by default
|
|
large size difference between variants:
src/models/results/mod.rs#L114
warning: large size difference between variants
--> src/models/results/mod.rs:114:1
|
114 | / pub enum XRPLResult<'a> {
115 | | AccountChannels(account_channels::AccountChannels<'a>),
116 | | AccountInfo(account_info::AccountInfoVersionMap<'a>),
117 | | AccountCurrencies(account_currencies::AccountCurrencies<'a>),
... |
144 | | ServerInfo(server_info::ServerInfo<'a>),
| | --------------------------------------- the largest variant contains at least 1088 bytes
145 | | ServerState(server_state::ServerState<'a>),
| | ------------------------------------------ the second-largest variant contains at least 792 bytes
... |
153 | | Other(XRPLOtherResult),
154 | | }
| |_^ the entire enum is at least 1088 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum
|
144 - ServerInfo(server_info::ServerInfo<'a>),
144 + ServerInfo(Box<server_info::ServerInfo<'a>>),
|
|
|
the `Err`-variant returned from this function is very large:
src/ledger/mod.rs#L36
warning: the `Err`-variant returned from this function is very large
--> src/ledger/mod.rs:36:6
|
36 | ) -> XRPLHelperResult<XRPAmount<'_>>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/ledger/mod.rs#L25
warning: the `Err`-variant returned from this function is very large
--> src/ledger/mod.rs:25:58
|
25 | pub fn get_latest_open_ledger_sequence<C>(client: &C) -> XRPLHelperResult<u32>
| ^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/ledger/mod.rs#L18
warning: the `Err`-variant returned from this function is very large
--> src/ledger/mod.rs:18:63
|
18 | pub fn get_latest_validated_ledger_sequence<C>(client: &C) -> XRPLHelperResult<u32>
| ^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
manual implementation of `.is_multiple_of()`:
src/core/binarycodec/types/vector256.rs#L69
warning: manual implementation of `.is_multiple_of()`
--> src/core/binarycodec/types/vector256.rs:69:12
|
69 | if self.0.len() % _HASH_LENGTH_BYTES != 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!self.0.len().is_multiple_of(_HASH_LENGTH_BYTES)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#manual_is_multiple_of
= note: `#[warn(clippy::manual_is_multiple_of)]` on by default
|
|
the `Err`-variant returned from this function is very large:
src/clients/mod.rs#L182
warning: the `Err`-variant returned from this function is very large
--> src/clients/mod.rs:182:34
|
182 | pub fn open(url: Url) -> XRPLClientResult<WebSocketClient<M, WebSocketOpen>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/clients/exceptions.rs:26:5
|
26 | XRPLWebSocketError(#[from] XRPLWebSocketException),
| -------------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::clients::exceptions::XRPLClientException`, for example by boxing large elements or replacing it with `Box<asynch::clients::exceptions::XRPLClientException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/clients/mod.rs#L156
warning: the `Err`-variant returned from this function is very large
--> src/clients/mod.rs:156:35
|
156 | fn xrpl_receive(&mut self) -> XRPLClientResult<Option<XRPLResponse<'_>>>;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/clients/exceptions.rs:26:5
|
26 | XRPLWebSocketError(#[from] XRPLWebSocketException),
| -------------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::clients::exceptions::XRPLClientException`, for example by boxing large elements or replacing it with `Box<asynch::clients::exceptions::XRPLClientException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/clients/mod.rs#L154
warning: the `Err`-variant returned from this function is very large
--> src/clients/mod.rs:154:58
|
154 | fn xrpl_send(&mut self, message: XRPLRequest<'_>) -> XRPLClientResult<()>;
| ^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/clients/exceptions.rs:26:5
|
26 | XRPLWebSocketError(#[from] XRPLWebSocketException),
| -------------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::clients::exceptions::XRPLClientException`, for example by boxing large elements or replacing it with `Box<asynch::clients::exceptions::XRPLClientException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/clients/mod.rs#L11
warning: the `Err`-variant returned from this function is very large
--> src/clients/mod.rs:11:36
|
11 | fn get_common_fields(&self) -> XRPLClientResult<CommonFields<'_>>;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/clients/exceptions.rs:26:5
|
26 | XRPLWebSocketError(#[from] XRPLWebSocketException),
| -------------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::clients::exceptions::XRPLClientException`, for example by boxing large elements or replacing it with `Box<asynch::clients::exceptions::XRPLClientException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/clients/mod.rs#L9
warning: the `Err`-variant returned from this function is very large
--> src/clients/mod.rs:9:64
|
9 | fn request<'a: 'b, 'b>(&self, request: XRPLRequest<'a>) -> XRPLClientResult<XRPLResponse<'b>>;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/clients/exceptions.rs:26:5
|
26 | XRPLWebSocketError(#[from] XRPLWebSocketException),
| -------------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::clients::exceptions::XRPLClientException`, for example by boxing large elements or replacing it with `Box<asynch::clients::exceptions::XRPLClientException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/cli/mod.rs#L792
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/cli/mod.rs:792:62
|
792 | let json_value: Value = serde_json::from_str(&json)?;
| ^^^^^ help: change this to: `json`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/cli/mod.rs#L789
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/cli/mod.rs:789:42
|
789 | let wallet = Wallet::new(&seed, 0)?;
| ^^^^^ help: change this to: `seed`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/cli/mod.rs#L491
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/cli/mod.rs:491:87
|
491 | let (classic_address, tag, is_test) = xaddress_to_classic_address(&address)?;
| ^^^^^^^^ help: change this to: `address`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/cli/mod.rs#L484
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/cli/mod.rs:484:52
|
484 | let is_valid_x = is_valid_xaddress(&address);
| ^^^^^^^^ help: change this to: `address`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/cli/mod.rs#L483
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/cli/mod.rs:483:65
|
483 | let is_valid_classic = is_valid_classic_address(&address);
| ^^^^^^^^ help: change this to: `address`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
the `Err`-variant returned from this function is very large:
src/cli/mod.rs#L418
warning: the `Err`-variant returned from this function is very large
--> src/cli/mod.rs:418:47
|
358 | ClientError(#[from] crate::asynch::clients::exceptions::XRPLClientException),
| ---------------------------------------------------------------------------- the largest variant contains at least 136 bytes
...
366 | HelperError(#[from] crate::asynch::exceptions::XRPLHelperException),
| ------------------------------------------------------------------- the variant `HelperError` contains at least 136 bytes
...
418 | pub fn execute_command(command: &Commands) -> Result<(), CliError> {
| ^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `cli::CliError`, for example by boxing large elements or replacing it with `Box<cli::CliError>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/cli/mod.rs#L412
warning: the `Err`-variant returned from this function is very large
--> src/cli/mod.rs:412:56
|
358 | ClientError(#[from] crate::asynch::clients::exceptions::XRPLClientException),
| ---------------------------------------------------------------------------- the largest variant contains at least 136 bytes
...
366 | HelperError(#[from] crate::asynch::exceptions::XRPLHelperException),
| ------------------------------------------------------------------- the variant `HelperError` contains at least 136 bytes
...
412 | fn encode_and_print_tx<T: serde::Serialize>(tx: &T) -> Result<String, CliError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `cli::CliError`, for example by boxing large elements or replacing it with `Box<cli::CliError>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/cli/mod.rs#L405
warning: the `Err`-variant returned from this function is very large
--> src/cli/mod.rs:405:31
|
358 | ClientError(#[from] crate::asynch::clients::exceptions::XRPLClientException),
| ---------------------------------------------------------------------------- the largest variant contains at least 136 bytes
...
366 | HelperError(#[from] crate::asynch::exceptions::XRPLHelperException),
| ------------------------------------------------------------------- the variant `HelperError` contains at least 136 bytes
...
405 | fn get_or_create_runtime() -> Result<tokio::runtime::Runtime, CliError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `cli::CliError`, for example by boxing large elements or replacing it with `Box<cli::CliError>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/cli/mod.rs#L393
warning: the `Err`-variant returned from this function is very large
--> src/cli/mod.rs:393:6
|
358 | ClientError(#[from] crate::asynch::clients::exceptions::XRPLClientException),
| ---------------------------------------------------------------------------- the largest variant contains at least 136 bytes
...
366 | HelperError(#[from] crate::asynch::exceptions::XRPLHelperException),
| ------------------------------------------------------------------- the variant `HelperError` contains at least 136 bytes
...
393 | ) -> Result<(), CliError> {
| ^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `cli::CliError`, for example by boxing large elements or replacing it with `Box<cli::CliError>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/cli/mod.rs#L383
warning: the `Err`-variant returned from this function is very large
--> src/cli/mod.rs:383:6
|
358 | ClientError(#[from] crate::asynch::clients::exceptions::XRPLClientException),
| ---------------------------------------------------------------------------- the largest variant contains at least 136 bytes
...
366 | HelperError(#[from] crate::asynch::exceptions::XRPLHelperException),
| ------------------------------------------------------------------- the variant `HelperError` contains at least 136 bytes
...
383 | ) -> Result<crate::clients::json_rpc::JsonRpcClient, CliError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `cli::CliError`, for example by boxing large elements or replacing it with `Box<cli::CliError>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/cli/mod.rs#L375
warning: the `Err`-variant returned from this function is very large
--> src/cli/mod.rs:375:32
|
358 | ClientError(#[from] crate::asynch::clients::exceptions::XRPLClientException),
| ---------------------------------------------------------------------------- the largest variant contains at least 136 bytes
...
366 | HelperError(#[from] crate::asynch::exceptions::XRPLHelperException),
| ------------------------------------------------------------------- the variant `HelperError` contains at least 136 bytes
...
375 | fn parse_url(url_str: &str) -> Result<url::Url, CliError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `cli::CliError`, for example by boxing large elements or replacing it with `Box<cli::CliError>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/cli/std_cli.rs#L8
warning: the `Err`-variant returned from this function is very large
--> src/cli/std_cli.rs:8:17
|
8 | pub fn run() -> Result<(), CliError> {
| ^^^^^^^^^^^^^^^^^^^^
|
::: src/cli/mod.rs:358:5
|
358 | ClientError(#[from] crate::asynch::clients::exceptions::XRPLClientException),
| ---------------------------------------------------------------------------- the largest variant contains at least 136 bytes
...
366 | HelperError(#[from] crate::asynch::exceptions::XRPLHelperException),
| ------------------------------------------------------------------- the variant `HelperError` contains at least 136 bytes
|
= help: try reducing the size of `cli::CliError`, for example by boxing large elements or replacing it with `Box<cli::CliError>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/asynch/wallet/mod.rs#L72
warning: the `Err`-variant returned from this function is very large
--> src/asynch/wallet/mod.rs:72:59
|
72 | pub fn get_faucet_url<C>(client: &C, url: Option<Url>) -> XRPLHelperResult<Url>
| ^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/asynch/transaction/mod.rs#L463
warning: the `Err`-variant returned from this function is very large
--> src/asynch/transaction/mod.rs:463:6
|
463 | ) -> XRPLHelperResult<()>
| ^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
this `match` expression can be replaced with `?`:
src/asynch/transaction/mod.rs#L438
warning: this `match` expression can be replaced with `?`
--> src/asynch/transaction/mod.rs:438:33
|
438 | let (address, tag, _) = match xaddress_to_classic_address(&account_address) {
| _________________________________^
439 | | Ok(t) => t,
440 | | Err(error) => return Err(error.into()),
441 | | };
| |_________^ help: try instead: `xaddress_to_classic_address(&account_address)?`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#question_mark
= note: `#[warn(clippy::question_mark)]` on by default
|
|
the `Err`-variant returned from this function is very large:
src/asynch/transaction/mod.rs#L409
warning: the `Err`-variant returned from this function is very large
--> src/asynch/transaction/mod.rs:409:6
|
409 | ) -> XRPLHelperResult<()>
| ^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/asynch/transaction/mod.rs#L382
warning: the `Err`-variant returned from this function is very large
--> src/asynch/transaction/mod.rs:382:75
|
382 | fn prepare_transaction<'a, T, F>(transaction: &mut T, wallet: &Wallet) -> XRPLHelperResult<()>
| ^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/asynch/transaction/mod.rs#L281
warning: the `Err`-variant returned from this function is very large
--> src/asynch/transaction/mod.rs:281:68
|
281 | fn is_not_later_rippled_version(source: String, target: String) -> XRPLHelperResult<bool> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/asynch/transaction/mod.rs#L262
warning: the `Err`-variant returned from this function is very large
--> src/asynch/transaction/mod.rs:262:61
|
262 | fn txn_needs_network_id(common_fields: CommonFields<'_>) -> XRPLHelperResult<bool> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/asynch/transaction/mod.rs#L249
warning: the `Err`-variant returned from this function is very large
--> src/asynch/transaction/mod.rs:249:6
|
249 | ) -> XRPLHelperResult<XRPAmount<'a>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/asynch/transaction/mod.rs#L238
warning: the `Err`-variant returned from this function is very large
--> src/asynch/transaction/mod.rs:238:6
|
238 | ) -> XRPLHelperResult<XRPAmount<'b>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
useless conversion to the same type: `std::string::String`:
src/asynch/transaction/mod.rs#L66
warning: useless conversion to the same type: `std::string::String`
--> src/asynch/transaction/mod.rs:66:13
|
66 | wallet.public_key.clone().into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `wallet.public_key.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#useless_conversion
|
|
useless conversion to the same type: `std::string::String`:
src/asynch/transaction/mod.rs#L65
warning: useless conversion to the same type: `std::string::String`
--> src/asynch/transaction/mod.rs:65:13
|
65 | signature.into(),
| ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `signature`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#useless_conversion
|
|
useless conversion to the same type: `std::string::String`:
src/asynch/transaction/mod.rs#L64
warning: useless conversion to the same type: `std::string::String`
--> src/asynch/transaction/mod.rs:64:13
|
64 | wallet.classic_address.clone().into(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `wallet.classic_address.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
the `Err`-variant returned from this function is very large:
src/asynch/transaction/mod.rs#L51
warning: the `Err`-variant returned from this function is very large
--> src/asynch/transaction/mod.rs:51:81
|
51 | pub fn sign<'a, T, F>(transaction: &mut T, wallet: &Wallet, multisign: bool) -> XRPLHelperResult<()>
| ^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/asynch/ledger/mod.rs#L90
warning: the `Err`-variant returned from this function is very large
--> src/asynch/ledger/mod.rs:90:6
|
90 | ) -> XRPLHelperResult<u32> {
| ^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/asynch/clients/mod.rs#L37
warning: the `Err`-variant returned from this function is very large
--> src/asynch/clients/mod.rs:37:51
|
37 | fn get_faucet_url(&self, url: Option<Url>) -> XRPLClientResult<Url>
| ^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/clients/exceptions.rs:26:5
|
26 | XRPLWebSocketError(#[from] XRPLWebSocketException),
| -------------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::clients::exceptions::XRPLClientException`, for example by boxing large elements or replacing it with `Box<asynch::clients::exceptions::XRPLClientException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/asynch/clients/json_rpc/mod.rs#L14
warning: the `Err`-variant returned from this function is very large
--> src/asynch/clients/json_rpc/mod.rs:14:53
|
14 | fn request_to_json_rpc(request: &impl Serialize) -> XRPLClientResult<Value> {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/clients/exceptions.rs:26:5
|
26 | XRPLWebSocketError(#[from] XRPLWebSocketException),
| -------------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::clients::exceptions::XRPLClientException`, for example by boxing large elements or replacing it with `Box<asynch::clients::exceptions::XRPLClientException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/account/mod.rs#L73
warning: the `Err`-variant returned from this function is very large
--> src/account/mod.rs:73:6
|
73 | ) -> XRPLHelperResult<AccountTxVersionMap<'b>>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/account/mod.rs#L63
warning: the `Err`-variant returned from this function is very large
--> src/account/mod.rs:63:6
|
63 | ) -> XRPLHelperResult<AccountRoot<'b>>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/account/mod.rs#L52
warning: the `Err`-variant returned from this function is very large
--> src/account/mod.rs:52:6
|
52 | ) -> XRPLHelperResult<XRPAmount<'b>>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/account/mod.rs#L37
warning: the `Err`-variant returned from this function is very large
--> src/account/mod.rs:37:6
|
37 | ) -> XRPLHelperResult<u32>
| ^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
src/account/mod.rs#L26
warning: the `Err`-variant returned from this function is very large
--> src/account/mod.rs:26:6
|
26 | ) -> XRPLHelperResult<bool>
| ^^^^^^^^^^^^^^^^^^^^^^
|
::: src/asynch/exceptions.rs:50:5
|
50 | XRPLClientError(#[from] XRPLClientException),
| -------------------------------------------- the largest variant contains at least 136 bytes
|
= help: try reducing the size of `asynch::exceptions::XRPLHelperException`, for example by boxing large elements or replacing it with `Box<asynch::exceptions::XRPLHelperException>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_large_err
= note: `#[warn(clippy::result_large_err)]` on by default
|
|
value assigned to `found` is never read:
src/models/transactions/exceptions.rs#L150
warning: value assigned to `found` is never read
--> src/models/transactions/exceptions.rs:150:49
|
150 | SignerQuorumExceedsSignerWeight { max: u32, found: u32 },
| ^^^^^
|
= help: maybe it is overwritten before being read?
|
|
value assigned to `max` is never read:
src/models/transactions/exceptions.rs#L150
warning: value assigned to `max` is never read
--> src/models/transactions/exceptions.rs:150:39
|
150 | SignerQuorumExceedsSignerWeight { max: u32, found: u32 },
| ^^^
|
= help: maybe it is overwritten before being read?
= note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default
|
|
unreachable statement:
src/asynch/mod.rs#L26
warning: unreachable statement
--> src/asynch/mod.rs:26:5
|
23 | return;
| ------ any code following this expression is unreachable
...
26 | / {
27 | | embassy_time::Timer::after_secs(1).await;
28 | | return;
29 | | }
| |_____^ unreachable statement
|
= note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default
|