chore: modernize CI workflows and enforce strict linting

- Replace deprecated actions-rs/* with dtolnay/rust-toolchain and
  direct cargo commands (actions-rs has been archived)
- Upgrade actions/checkout from v1/v2 to v4
- Add cargo fmt --check step to quality workflow
- Enforce -D warnings on clippy in CI and pre-commit hook
- Add rustfmt.toml with import ordering rules
- Change pre-commit hook to check formatting rather than auto-fix
- Fix duplicate "Build only core" step name (was building json-rpc)

Author: e-desouza

.cargo-husky/hooks/pre-commit

@@ -2,9 +2,9 @@
 set -e
 
 echo 'Running all pre-commit checks:'
-cargo fmt
+cargo fmt -- --check
+cargo clippy --all-features -- -D warnings
 cargo test --release
-cargo test  --release --no-default-features --features embassy-rt,core,wallet,models,helpers,websocket,json-rpc
-cargo clippy --fix --allow-staged
+cargo test --release --no-default-features --features embassy-rt,core,wallet,models,helpers,websocket,json-rpc
 cargo doc --no-deps
 cargo audit

.github/workflows/audit_test.yml

@@ -14,7 +14,9 @@ jobs:
   audit:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-      - uses: actions-rs/audit-check@v1
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
+      - name: Install cargo-audit
+        run: cargo install cargo-audit
+      - name: Run security audit
+        run: cargo audit

.github/workflows/quality_test.yml

@@ -1,4 +1,4 @@
-on: 
+on:
   push:
     branches:
       - dev
@@ -9,12 +9,14 @@ on:
 name: Quality
 
 jobs:
-  clippy_check:
+  quality_check:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-      - run: rustup component add clippy
-      - uses: actions-rs/clippy-check@v1
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
         with:
-          token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-features
+          components: clippy, rustfmt
+      - name: Check formatting
+        run: cargo fmt -- --check
+      - name: Clippy lint
+        run: cargo clippy --all-features -- -D warnings

.github/workflows/unit_test.yml

@@ -14,62 +14,27 @@ jobs:
     name: xrpl-rust
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions-rs/toolchain@v1
-        with:
-          toolchain: stable
-      - uses: actions-rs/cargo@v1
-        name: Build with default features
-        with:
-          command: build
-          args: --release
-      - uses: actions-rs/cargo@v1
-        name: Build with no default features
-        with:
-          command: build
-          args: --release --no-default-features
-      - uses: actions-rs/cargo@v1
-        name: Build for no_std
-        with:
-          command: build
-          args: --release --no-default-features --features embassy-rt,core,wallet,models,helpers,websocket,json-rpc
-      - uses: actions-rs/cargo@v1
-        name: Build only core
-        with:
-          command: build
-          args: --release --no-default-features --features core
-      - uses: actions-rs/cargo@v1
-        name: Build only wallet
-        with:
-          command: build
-          args: --release --no-default-features --features wallet
-      - uses: actions-rs/cargo@v1
-        name: Build only models
-        with:
-          command: build
-          args: --release --no-default-features --features models
-      - uses: actions-rs/cargo@v1
-        name: Build only helpers
-        with:
-          command: build
-          args: --release --no-default-features --features websocket,json-rpc,helpers,tokio-rt
-      - uses: actions-rs/cargo@v1
-        name: Build only websocket
-        with:
-          command: build
-          args: --release --no-default-features --features websocket
-      - uses: actions-rs/cargo@v1
-        name: Build only core
-        with:
-          command: build
-          args: --release --no-default-features --features json-rpc
-      - uses: actions-rs/cargo@v1
-        name: Test with default features
-        with:
-          command: test
-          args: --release
-      - uses: actions-rs/cargo@v1
-        name: Test for no_std
-        with:
-          command: test
-          args: --release --no-default-features --features embassy-rt,core,utils,wallet,models,helpers,websocket,json-rpc
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
+      - name: Build with default features
+        run: cargo build --release
+      - name: Build with no default features
+        run: cargo build --release --no-default-features
+      - name: Build for no_std
+        run: cargo build --release --no-default-features --features embassy-rt,core,wallet,models,helpers,websocket,json-rpc
+      - name: Build only core
+        run: cargo build --release --no-default-features --features core
+      - name: Build only wallet
+        run: cargo build --release --no-default-features --features wallet
+      - name: Build only models
+        run: cargo build --release --no-default-features --features models
+      - name: Build only helpers
+        run: cargo build --release --no-default-features --features websocket,json-rpc,helpers,tokio-rt
+      - name: Build only websocket
+        run: cargo build --release --no-default-features --features websocket
+      - name: Build only json-rpc
+        run: cargo build --release --no-default-features --features json-rpc
+      - name: Test with default features
+        run: cargo test --release
+      - name: Test for no_std
+        run: cargo test --release --no-default-features --features embassy-rt,core,utils,wallet,models,helpers,websocket,json-rpc

rustfmt.toml

@@ -0,0 +1 @@
+edition = "2021"