fix clippy

Author: LimpidCrypto

src/models/results/account_info.rs

@@ -126,7 +126,7 @@ impl<'a> TryFrom<XRPLResult<'a>> for AccountInfoVersionMap<'a> {
 
     fn try_from(result: XRPLResult<'a>) -> XRPLModelResult<Self> {
         match result {
-            XRPLResult::AccountInfo(account_info) => Ok(account_info),
+            XRPLResult::AccountInfo(account_info) => Ok(*account_info),
             res => Err(XRPLResultException::UnexpectedResultType(
                 "AccountInfo".to_string(),
                 res.get_name(),

src/models/results/mod.rs

@@ -86,7 +86,7 @@ impl XRPLOtherResult {
 #[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
 #[serde(untagged)]
 pub enum XRPLResult<'a> {
-    AccountInfo(account_info::AccountInfoVersionMap<'a>),
+    AccountInfo(Box<account_info::AccountInfoVersionMap<'a>>), // Boxed because AccountInfo is large
     AccountTx(account_tx::AccountTxVersionMap<'a>),
     Fee(fee::Fee<'a>),
     Ledger(ledger::Ledger<'a>),
@@ -104,19 +104,23 @@ pub enum XRPLResult<'a> {
 
 impl<'a> From<account_info::AccountInfo<'a>> for XRPLResult<'a> {
     fn from(account_info: account_info::AccountInfo<'a>) -> Self {
-        XRPLResult::AccountInfo(account_info::AccountInfoVersionMap::Default(account_info))
+        XRPLResult::AccountInfo(Box::new(account_info::AccountInfoVersionMap::Default(
+            account_info,
+        )))
     }
 }
 
 impl<'a> From<account_info::AccountInfoV1<'a>> for XRPLResult<'a> {
     fn from(account_info: account_info::AccountInfoV1<'a>) -> Self {
-        XRPLResult::AccountInfo(account_info::AccountInfoVersionMap::V1(account_info))
+        XRPLResult::AccountInfo(Box::new(account_info::AccountInfoVersionMap::V1(
+            account_info,
+        )))
     }
 }
 
 impl<'a> From<account_info::AccountInfoVersionMap<'a>> for XRPLResult<'a> {
     fn from(account_info: account_info::AccountInfoVersionMap<'a>) -> Self {
-        XRPLResult::AccountInfo(account_info)
+        XRPLResult::AccountInfo(Box::new(account_info))
     }
 }
 

src/utils/str_conversion.rs

@@ -1,16 +1,13 @@
-use alloc::{borrow::Cow, format, string::String};
+use alloc::{borrow::Cow, string::String};
 
 use super::exceptions::XRPLUtilsResult;
 
 /// Convert a UTF-8-encoded string into hexadecimal encoding.
 /// XRPL uses hex strings as inputs in fields like `domain`
 /// in the `AccountSet` transaction.
 pub fn str_to_hex<'a: 'b, 'b>(value: Cow<'a, str>) -> XRPLUtilsResult<Cow<'b, str>> {
-    let hex_string = value
-        .as_bytes()
-        .iter()
-        .map(|b| format!("{:02x}", b))
-        .collect::<String>();
+    let hex_string = hex::encode(value.as_bytes());
+
     Ok(Cow::Owned(hex_string))
 }
 

src/utils/txn_parser/get_balance_changes.rs

@@ -3,10 +3,7 @@ use bigdecimal::BigDecimal;
 
 use crate::{
     models::transactions::metadata::TransactionMetadata,
-    utils::{
-        exceptions::XRPLUtilsResult,
-        txn_parser::utils::parser::get_value,
-    },
+    utils::{exceptions::XRPLUtilsResult, txn_parser::utils::parser::get_value},
 };
 
 use super::utils::{
@@ -16,7 +13,7 @@ use super::utils::{
 pub fn get_balance_changes<'a: 'b, 'b>(
     meta: &'a TransactionMetadata<'a>,
 ) -> XRPLUtilsResult<Vec<AccountBalances<'b>>> {
-    Ok(derive_account_balances(meta, compute_balance_change)?)
+    derive_account_balances(meta, compute_balance_change)
 }
 
 /// Get the balance change from a node.
@@ -56,7 +53,6 @@ mod test {
 
     use super::*;
     use crate::models::transactions::metadata::TransactionMetadata;
-    
 
     #[test]
     fn test_parse_balance_changes() {

src/utils/txn_parser/utils/balance_parser.rs

@@ -38,9 +38,7 @@ fn get_xrp_quantity(
         } else {
             let xrp_value = drops_to_xrp(absulte_value.to_string().as_str())?;
             let dec = BigDecimal::from_str(&xrp_value)?;
-            let negated_xrp_value = negate(&dec);
-
-            negated_xrp_value
+            negate(&dec)
         };
         if let Some(final_fields) = node.final_fields {
             if let Some(account) = final_fields.account {
@@ -76,9 +74,7 @@ fn get_xrp_quantity(
     }
 }
 
-fn flip_trustline_perspective<'a>(
-    account_balance: AccountBalance<'a>,
-) -> XRPLUtilsResult<AccountBalance<'a>> {
+fn flip_trustline_perspective(account_balance: AccountBalance) -> XRPLUtilsResult<AccountBalance> {
     let balance = account_balance.balance.clone();
     let negated_value = negate(&BigDecimal::from_str(balance.value.as_ref())?);
     let issuer = balance.issuer.clone();

src/utils/txn_parser/utils/order_book_parser.rs

@@ -9,7 +9,7 @@ fn get_offer_status(node: &NormalizedNode<'_>) -> OfferStatus {
         NodeType::CreatedNode => OfferStatus::Created,
         NodeType::ModifiedNode => OfferStatus::PartiallyFilled,
         NodeType::DeletedNode => {
-            if let Some(_) = node.previous_fields {
+            if node.previous_fields.is_some() {
                 // a filled offer has previous fields
                 OfferStatus::Filled
             } else {