fix: address Claude review on interactive Seqera buttons

Add progress/complete message button tests, validate unknown action button
modes with a link-mode fallback, and document custom status phase mapping.

Generated by Codex

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: adamrtalbot

src/main/groovy/nextflow/slack/SeqeraPlatformActionButtonsConfig.groovy

@@ -17,6 +17,7 @@
 package nextflow.slack
 
 import groovy.transform.CompileStatic
+import groovy.util.logging.Slf4j
 
 /**
  * Configuration for Seqera Platform action buttons in Slack messages.
@@ -25,6 +26,7 @@ import groovy.transform.CompileStatic
  * Interactive mode emits action_id buttons for an external Slack interactivity handler.
  */
 @CompileStatic
+@Slf4j
 class SeqeraPlatformActionButtonsConfig {
 
     static final String MODE_LINK = 'link'
@@ -37,7 +39,12 @@ class SeqeraPlatformActionButtonsConfig {
 
     SeqeraPlatformActionButtonsConfig(Map config) {
         config = config ?: [:]
-        this.mode = (config.mode as String ?: MODE_LINK).toLowerCase()
+        def configuredMode = (config.mode as String ?: MODE_LINK).toLowerCase()
+        if (configuredMode != MODE_LINK && configuredMode != MODE_INTERACTIVE) {
+            log.warn "Slack plugin: Unknown seqeraPlatform.actionButtons.mode '${configuredMode}'; falling back to '${MODE_LINK}'"
+            configuredMode = MODE_LINK
+        }
+        this.mode = configuredMode
         this.cancel = config.cancel != null ? config.cancel as boolean : true
         this.resume = config.resume != null ? config.resume as boolean : true
         this.relaunch = config.relaunch != null ? config.relaunch as boolean : true

src/main/groovy/nextflow/slack/SlackMessageBuilder.groovy

@@ -620,6 +620,7 @@ class SlackMessageBuilder {
             case 'failed':
                 return SeqeraMessagePhase.FAILED
             default:
+                // Custom statuses (e.g. paused) are treated as RUNNING for button selection.
                 return SeqeraMessagePhase.RUNNING
         }
     }

src/test/groovy/nextflow/slack/SeqeraPlatformActionButtonsTest.groovy

@@ -117,4 +117,14 @@ class SeqeraPlatformActionButtonsTest extends Specification {
         config.isLinkMode()
         !config.isInteractiveMode()
     }
+
+    def 'should fall back to link mode for unknown mode values'() {
+        when:
+        def config = new SeqeraPlatformActionButtonsConfig([mode: 'url'])
+
+        then:
+        config.mode == 'link'
+        config.isLinkMode()
+        !config.isInteractiveMode()
+    }
 }

src/test/groovy/nextflow/slack/SlackMessageBuilderTest.groovy

@@ -678,6 +678,59 @@ class SlackMessageBuilderTest extends Specification {
         actionsBlock.elements*.text.text == ['🔗 View in Seqera Platform', '▶️ Resume', '🔄 Relaunch']
     }
 
+    def 'should include Seqera Platform buttons in progress update when watchUrl is available'() {
+        given:
+        def platformConfig = new SlackConfig([
+            webhook: 'https://hooks.slack.com/test',
+            seqeraPlatform: [enabled: true]
+        ])
+        def mockMetadata = Mock(WorkflowMetadata)
+        mockMetadata.scriptName >> 'test-workflow.nf'
+        def towerSession = Mock(Session)
+        towerSession.config >> [:]
+        towerSession.workflowMetadata >> mockMetadata
+        towerSession.runName >> 'crazy_einstein'
+        towerSession.uniqueId >> UUID.fromString('00000000-0000-0000-0000-000000000000')
+        def builder = Spy(new SlackMessageBuilder(platformConfig, towerSession))
+        builder.getTowerClientWatchUrl() >> 'https://cloud.seqera.io/orgs/myorg/workspaces/myws/watch/abc123'
+
+        when:
+        def message = builder.buildProgressUpdateMessage(10, 5, 2, 0, 60000L, null)
+        def json = new JsonSlurper().parseText(message)
+
+        then:
+        def actionsBlock = json.blocks.find { it.type == 'actions' }
+        actionsBlock != null
+        actionsBlock.elements*.text.text == ['🔗 View in Seqera Platform', '⏹ Cancel']
+    }
+
+    def 'should include View and Relaunch buttons on workflow complete message'() {
+        given:
+        def platformConfig = new SlackConfig([
+            webhook: 'https://hooks.slack.com/test',
+            seqeraPlatform: [enabled: true]
+        ])
+        def mockMetadata = Mock(WorkflowMetadata)
+        mockMetadata.scriptName >> 'test-workflow.nf'
+        mockMetadata.duration >> nextflow.util.Duration.of('1h')
+        mockMetadata.stats >> null
+        def towerSession = Mock(Session)
+        towerSession.config >> [:]
+        towerSession.workflowMetadata >> mockMetadata
+        towerSession.runName >> 'crazy_einstein'
+        towerSession.uniqueId >> UUID.fromString('00000000-0000-0000-0000-000000000000')
+        def builder = Spy(new SlackMessageBuilder(platformConfig, towerSession))
+        builder.getTowerClientWatchUrl() >> 'https://cloud.seqera.io/orgs/myorg/workspaces/myws/watch/abc123'
+
+        when:
+        def message = builder.buildWorkflowCompleteMessage()
+        def json = new JsonSlurper().parseText(message)
+
+        then:
+        def actionsBlock = json.blocks.find { it.type == 'actions' }
+        actionsBlock.elements*.text.text == ['🔗 View in Seqera Platform', '🔄 Relaunch']
+    }
+
     def 'should not include Seqera Platform button when no TowerClient present'() {
         when:
         def message = messageBuilder.buildWorkflowStartMessage()