fix: wire mention resolver into bot and webhook senders

Generated by Codex

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: adamrtalbot

src/main/groovy/nextflow/slack/BotSlackSender.groovy

@@ -52,6 +52,7 @@ class BotSlackSender implements SlackSender {
 
     private final String botToken
     private final String channelId
+    private final SlackMentionResolver mentionResolver
     private final Set<String> loggedErrors = Collections.synchronizedSet(new HashSet<String>())
     private String threadTs  // Store the thread timestamp for threaded conversations
     private String resolvedChannelId  // Channel ID resolved from Slack API response
@@ -65,6 +66,7 @@ class BotSlackSender implements SlackSender {
     BotSlackSender(String botToken, String channelId) {
         this.botToken = botToken
         this.channelId = channelId
+        this.mentionResolver = new SlackMentionResolver(botToken)
     }
 
     /**
@@ -75,8 +77,8 @@ class BotSlackSender implements SlackSender {
     @Override
     void sendMessage(String message) {
         try {
-            // Message is already formatted by SlackMessageBuilder with channel ID
-            postToSlack(message)
+            def resolvedMessage = mentionResolver.resolveInJson(message)
+            postToSlack(resolvedMessage)
 
         } catch (Exception e) {
             def errorMsg = "Slack plugin: Error sending bot message: ${e.message}".toString()
@@ -419,7 +421,8 @@ class BotSlackSender implements SlackSender {
     @Override
     void updateMessage(String message, String messageTs) {
         try {
-            postUpdate(message, messageTs)
+            def resolvedMessage = mentionResolver.resolveInJson(message)
+            postUpdate(resolvedMessage, messageTs)
         } catch (Exception e) {
             def errorMsg = "Slack plugin: Error updating message: ${e.message}".toString()
             if (loggedErrors.add(errorMsg)) {

src/main/groovy/nextflow/slack/WebhookSlackSender.groovy

@@ -35,6 +35,7 @@ class WebhookSlackSender implements SlackSender {
 
     private final String webhookUrl
     private final Set<String> loggedErrors = Collections.synchronizedSet(new HashSet<String>())
+    private final Set<String> loggedWarnings = Collections.synchronizedSet(new HashSet<String>())
 
     /**
      * Create a new WebhookSlackSender with the given webhook URL
@@ -51,6 +52,8 @@ class WebhookSlackSender implements SlackSender {
     @Override
     void sendMessage(String message) {
         try {
+            warnIfUnresolvedMentions(message)
+
             def url = new URL(webhookUrl)
             def connection = url.openConnection() as HttpURLConnection
             connection.requestMethod = 'POST'
@@ -103,4 +106,14 @@ class WebhookSlackSender implements SlackSender {
     void uploadFile(Path filePath, Map options) {
         log.warn "Slack plugin: File upload is not supported with webhooks. Please configure a bot token to upload files."
     }
+
+    private void warnIfUnresolvedMentions(String message) {
+        if (!SlackMentionResolver.hasResolvableMentions(message)) {
+            return
+        }
+        def warning = 'Slack plugin: Display-name @mentions require a bot token (users:read scope) and are not resolved with webhooks'
+        if (loggedWarnings.add(warning)) {
+            log.warn warning
+        }
+    }
 }