Fix clippy warnings (#2988)

I swapped the CI to nightly for clippy, as otherwise I couldn't ignore
newly-added lints.

Author: GnomedDev

.github/workflows/lint.yml

@@ -15,7 +15,9 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Install toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@nightly
+        with:
+          components: clippy
 
       - name: Add problem matchers
         run: echo "::add-matcher::.github/matchers/rust.json"
@@ -24,7 +26,7 @@ jobs:
         uses: Swatinem/rust-cache@v2
 
       - name: Run clippy
-        run: cargo clippy --workspace --tests -- -D warnings --cfg ignore_serenity_deprecated
+        run: cargo clippy --workspace --tests --features full -- -D warnings --cfg ignore_serenity_deprecated
 
   rustfmt:
     name: Format

command_attr/src/attributes.rs

@@ -120,7 +120,7 @@ pub fn parse_values(attr: &Attribute) -> Result<Values> {
 #[derive(Debug, Clone)]
 struct DisplaySlice<'a, T>(&'a [T]);
 
-impl<'a, T: fmt::Display> fmt::Display for DisplaySlice<'a, T> {
+impl<T: fmt::Display> fmt::Display for DisplaySlice<'_, T> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         let mut iter = self.0.iter().enumerate();
 

command_attr/src/lib.rs

@@ -234,9 +234,10 @@ pub fn command(attr: TokenStream, input: TokenStream) -> TokenStream {
 }
 
 #[rustfmt::skip]
-/// A brother macro to [`command`], but for the help command. An interface for simple browsing of
-/// all the available commands the bot provides, and reading through specific information regarding
-/// a command.
+/// A brother macro to [`command`], but for the help command.
+///
+/// An interface for simple browsing of all the available commands the bot provides,
+/// and reading through specific information regarding a command.
 ///
 /// As such, the options here will pertain in the help command's **layout** than its functionality.
 ///
@@ -609,7 +610,6 @@ pub fn help(attr: TokenStream, input: TokenStream) -> TokenStream {
 /// the macro. For example: `#[group("Banana Phone")]`.
 ///
 /// [`command`]: macro@command
-
 #[proc_macro_attribute]
 pub fn group(attr: TokenStream, input: TokenStream) -> TokenStream {
     let group = parse_macro_input!(input as GroupStruct);

src/builder/create_attachment.rs

@@ -137,7 +137,7 @@ enum NewOrExisting {
 ///
 /// ```rust,no_run
 /// # use serenity::all::*;
-/// # async fn _foo(ctx: Http, mut msg: Message) -> Result<(), Error> {
+/// # async fn foo_(ctx: Http, mut msg: Message) -> Result<(), Error> {
 /// msg.edit(ctx, EditMessage::new().attachments(EditAttachments::new())).await?;
 /// # Ok(()) }
 /// ```
@@ -146,7 +146,7 @@ enum NewOrExisting {
 ///
 /// ```rust,no_run
 /// # use serenity::all::*;
-/// # async fn _foo(ctx: Http, mut msg: Message, my_attachment: CreateAttachment) -> Result<(), Error> {
+/// # async fn foo_(ctx: Http, mut msg: Message, my_attachment: CreateAttachment) -> Result<(), Error> {
 /// msg.edit(ctx, EditMessage::new().attachments(
 ///     EditAttachments::keep_all(&msg).add(my_attachment)
 /// )).await?;
@@ -157,7 +157,7 @@ enum NewOrExisting {
 ///
 /// ```rust,no_run
 /// # use serenity::all::*;
-/// # async fn _foo(ctx: Http, mut msg: Message, my_attachment: CreateAttachment) -> Result<(), Error> {
+/// # async fn foo_(ctx: Http, mut msg: Message, my_attachment: CreateAttachment) -> Result<(), Error> {
 /// msg.edit(ctx, EditMessage::new().attachments(
 ///     EditAttachments::new().keep(msg.attachments[0].id)
 /// )).await?;
@@ -168,7 +168,7 @@ enum NewOrExisting {
 ///
 /// ```rust,no_run
 /// # use serenity::all::*;
-/// # async fn _foo(ctx: Http, mut msg: Message, my_attachment: CreateAttachment) -> Result<(), Error> {
+/// # async fn foo_(ctx: Http, mut msg: Message, my_attachment: CreateAttachment) -> Result<(), Error> {
 /// msg.edit(ctx, EditMessage::new().attachments(
 ///     EditAttachments::keep_all(&msg).remove(msg.attachments[0].id)
 /// )).await?;

src/builder/create_channel.rs

@@ -256,7 +256,7 @@ impl<'a> CreateChannel<'a> {
 
 #[cfg(feature = "http")]
 #[async_trait::async_trait]
-impl<'a> Builder for CreateChannel<'a> {
+impl Builder for CreateChannel<'_> {
     type Context<'ctx> = GuildId;
     type Built = GuildChannel;
 

src/builder/create_components.rs

@@ -178,6 +178,7 @@ impl Serialize for CreateSelectMenuKind {
             default_values: Vec<CreateSelectMenuDefault>,
         }
 
+        #[allow(clippy::ref_option)]
         fn map<I: Into<Mention> + Copy>(
             values: &Option<Vec<I>>,
         ) -> impl Iterator<Item = CreateSelectMenuDefault> + '_ {

src/builder/create_forum_post.rs

@@ -96,7 +96,7 @@ impl<'a> CreateForumPost<'a> {
 
 #[cfg(feature = "http")]
 #[async_trait::async_trait]
-impl<'a> Builder for CreateForumPost<'a> {
+impl Builder for CreateForumPost<'_> {
     type Context<'ctx> = ChannelId;
     type Built = GuildChannel;
 

src/builder/create_invite.rs

@@ -198,7 +198,7 @@ impl<'a> CreateInvite<'a> {
 
 #[cfg(feature = "http")]
 #[async_trait::async_trait]
-impl<'a> Builder for CreateInvite<'a> {
+impl Builder for CreateInvite<'_> {
     type Context<'ctx> = ChannelId;
     type Built = RichInvite;
 

src/builder/create_scheduled_event.rs

@@ -124,7 +124,7 @@ impl<'a> CreateScheduledEvent<'a> {
 
 #[cfg(feature = "http")]
 #[async_trait::async_trait]
-impl<'a> Builder for CreateScheduledEvent<'a> {
+impl Builder for CreateScheduledEvent<'_> {
     type Context<'ctx> = GuildId;
     type Built = ScheduledEvent;
 

src/builder/create_stage_instance.rs

@@ -56,7 +56,7 @@ impl<'a> CreateStageInstance<'a> {
 
 #[cfg(feature = "http")]
 #[async_trait::async_trait]
-impl<'a> Builder for CreateStageInstance<'a> {
+impl Builder for CreateStageInstance<'_> {
     type Context<'ctx> = ChannelId;
     type Built = StageInstance;