Delete passthrough methods (#3023)

This deletes methods which simply pass through to their `id` fields, as
they are:
- Misleading, as a user may do an HTTP call or cache lookup to get a
model just to use it's ID
- Lead to a bunch of maintenance issues when having 2..=4 copies of
every method.
- Hurt compile times, as rustc is having to check signatures, calls,
construct async state machines, and maybe even inline to generate code
multiple times.

For methods which simply only used their `id` field but did not have a
version on their respective ID, they were moved to their ID.

This doesn't have a corresponding deprecation PR to current, as current
still has permission checks and other "helpers" which rely on the model.

Author: GnomedDev

examples/e03_struct_utilities/src/main.rs

@@ -19,7 +19,7 @@ impl EventHandler for Handler {
             // In this case, you can direct message a User directly by simply calling a method on
             // its instance, with the content of the message.
             let builder = CreateMessage::new().content("Hello!");
-            let dm = msg.author.dm(&context.http, builder).await;
+            let dm = msg.author.id.dm(&context.http, builder).await;
 
             if let Err(why) = dm {
                 println!("Error when direct messaging user: {why:?}");

examples/e09_collectors/src/main.rs

@@ -27,7 +27,8 @@ impl EventHandler for Handler {
         // There is a method implemented for some models to conveniently collect replies. They
         // return a builder that can be turned into a Stream, or here, where we can await a
         // single reply
-        let collector = msg.author.await_reply(ctx.shard.clone()).timeout(Duration::from_secs(10));
+        let collector =
+            msg.author.id.await_reply(ctx.shard.clone()).timeout(Duration::from_secs(10));
         if let Some(answer) = collector.await {
             if answer.content.to_lowercase() == "ferris" {
                 let _ = answer.reply(&ctx.http, "That's correct!").await;
@@ -46,6 +47,7 @@ impl EventHandler for Handler {
 
         // The message model can also be turned into a Collector to collect reactions on it.
         let collector = react_msg
+            .id
             .await_reaction(ctx.shard.clone())
             .timeout(Duration::from_secs(10))
             .author_id(msg.author.id);

examples/e14_message_components/src/main.rs

@@ -59,6 +59,7 @@ impl EventHandler for Handler {
         // This uses a collector to wait for an incoming event without needing to listen for it
         // manually in the EventHandler.
         let interaction = match m
+            .id
             .await_component_interaction(ctx.shard.clone())
             .timeout(Duration::from_secs(60 * 3))
             .await
@@ -106,10 +107,10 @@ impl EventHandler for Handler {
             .unwrap();
 
         // Wait for multiple interactions
-        let mut interaction_stream = m
-            .await_component_interaction(ctx.shard.clone())
-            .timeout(Duration::from_secs(60 * 3))
-            .stream();
+        let mut interaction_stream =
+            m.id.await_component_interaction(ctx.shard.clone())
+                .timeout(Duration::from_secs(60 * 3))
+                .stream();
 
         while let Some(interaction) = interaction_stream.next().await {
             let sound = &interaction.data.custom_id;

examples/testing/src/main.rs

@@ -120,6 +120,7 @@ async fn message(ctx: &Context, msg: Message) -> Result<(), serenity::Error> {
                 )
                 .await?;
             let button_press = msg
+                .id
                 .await_component_interaction(ctx.shard.clone())
                 .timeout(std::time::Duration::from_secs(10))
                 .await;
@@ -193,7 +194,7 @@ async fn message(ctx: &Context, msg: Message) -> Result<(), serenity::Error> {
             .flags(MessageFlags::IS_VOICE_MESSAGE)
             .add_file(CreateAttachment::url(&ctx.http, audio_url, "testing.ogg").await?);
 
-        msg.author.dm(&ctx.http, builder).await?;
+        msg.author.id.dm(&ctx.http, builder).await?;
     } else if let Some(channel) = msg.content.strip_prefix("movetorootandback") {
         let mut channel = {
             let channel_id = channel.trim().parse::<ChannelId>().unwrap();

src/builder/create_channel.rs

@@ -169,12 +169,12 @@ impl<'a> CreateChannel<'a> {
     /// Inheriting permissions from an existing channel:
     ///
     /// ```rust,no_run
-    /// # use serenity::{http::Http, model::guild::Guild};
+    /// # use serenity::{http::Http, model::id::GuildId};
     /// # use std::sync::Arc;
     /// #
     /// # async fn run() -> Result<(), Box<dyn std::error::Error>> {
     /// # let http: Http = unimplemented!();
-    /// # let mut guild: Guild = unimplemented!();
+    /// # let mut guild_id: GuildId = unimplemented!();
     /// use serenity::builder::CreateChannel;
     /// use serenity::model::channel::{PermissionOverwrite, PermissionOverwriteType};
     /// use serenity::model::id::UserId;
@@ -188,7 +188,7 @@ impl<'a> CreateChannel<'a> {
     /// }];
     ///
     /// let builder = CreateChannel::new("my_new_cool_channel").permissions(permissions);
-    /// guild.create_channel(&http, builder).await?;
+    /// guild_id.create_channel(&http, builder).await?;
     /// # Ok(())
     /// # }
     /// ```

src/builder/create_invite.rs

@@ -4,7 +4,7 @@ use crate::http::Http;
 use crate::internal::prelude::*;
 use crate::model::prelude::*;
 
-/// A builder to create a [`RichInvite`] for use via [`GuildChannel::create_invite`].
+/// A builder to create a [`RichInvite`] for use via [`ChannelId::create_invite`].
 ///
 /// This is a structured and cleaner way of creating an invite, as all parameters are optional.
 ///
@@ -16,9 +16,9 @@ use crate::model::prelude::*;
 /// # use serenity::{prelude::*, model::prelude::*};
 /// use serenity::builder::CreateInvite;
 /// use serenity::http::Http;
-/// # async fn run(http: &Http, channel: GuildChannel) -> Result<(), Box<dyn std::error::Error>> {
+/// # async fn run(http: &Http, channel_id: ChannelId) -> Result<(), Box<dyn std::error::Error>> {
 /// let builder = CreateInvite::new().max_age(3600).max_uses(10);
-/// let creation = channel.create_invite(http, builder).await?;
+/// let creation = channel_id.create_invite(http, builder).await?;
 /// # Ok(())
 /// # }
 /// ```
@@ -57,22 +57,6 @@ impl<'a> CreateInvite<'a> {
     /// Set to `0` for an invite which does not expire after an amount of time.
     ///
     /// Defaults to `86400`, or 24 hours.
-    ///
-    /// # Examples
-    ///
-    /// Create an invite with a max age of `3600` seconds, or 1 hour:
-    ///
-    /// ```rust,no_run
-    /// # use serenity::model::prelude::*;
-    /// # use serenity::builder::CreateInvite;
-    /// # use serenity::http::Http;
-    /// #
-    /// # async fn example(http: &Http, channel: GuildChannel) -> Result<(), Box<dyn std::error::Error>> {
-    /// let builder = CreateInvite::new().max_age(3600);
-    /// let invite = channel.create_invite(http, builder).await?;
-    /// # Ok(())
-    /// # }
-    /// ```
     pub fn max_age(mut self, max_age: u32) -> Self {
         self.max_age = Some(max_age);
         self
@@ -83,24 +67,6 @@ impl<'a> CreateInvite<'a> {
     /// Set to `0` for an invite which does not expire after a number of uses.
     ///
     /// Defaults to `0`.
-    ///
-    /// # Examples
-    ///
-    /// Create an invite with a max use limit of `5`:
-    ///
-    /// Create an invite with a max age of `3600` seconds, or 1 hour:
-    ///
-    /// ```rust,no_run
-    /// # use serenity::model::prelude::*;
-    /// # use serenity::builder::CreateInvite;
-    /// # use serenity::http::Http;
-    /// #
-    /// # async fn example(http:  &Http, channel: GuildChannel) -> Result<(), Box<dyn std::error::Error>> {
-    /// let builder = CreateInvite::new().max_uses(5);
-    /// let invite = channel.create_invite(http, builder).await?;
-    /// # Ok(())
-    /// # }
-    /// ```
     pub fn max_uses(mut self, max_uses: u8) -> Self {
         self.max_uses = Some(max_uses);
         self
@@ -109,22 +75,6 @@ impl<'a> CreateInvite<'a> {
     /// Whether an invite grants a temporary membership.
     ///
     /// Defaults to `false`.
-    ///
-    /// # Examples
-    ///
-    /// Create an invite which is temporary:
-    ///
-    /// ```rust,no_run
-    /// # use serenity::model::prelude::*;
-    /// # use serenity::builder::CreateInvite;
-    /// # use serenity::http::Http;
-    /// #
-    /// # async fn example(http: &Http, channel: GuildChannel) -> Result<(), Box<dyn std::error::Error>> {
-    /// let builder = CreateInvite::new().temporary(true);
-    /// let invite = channel.create_invite(http, builder).await?;
-    /// # Ok(())
-    /// # }
-    /// ```
     pub fn temporary(mut self, temporary: bool) -> Self {
         self.temporary = Some(temporary);
         self
@@ -133,22 +83,6 @@ impl<'a> CreateInvite<'a> {
     /// Whether or not to try to reuse a similar invite.
     ///
     /// Defaults to `false`.
-    ///
-    /// # Examples
-    ///
-    /// Create an invite which is unique:
-    ///
-    /// ```rust,no_run
-    /// # use serenity::model::prelude::*;
-    /// # use serenity::builder::CreateInvite;
-    /// # use serenity::http::Http;
-    /// #
-    /// # async fn example(http: &Http, channel: GuildChannel) -> Result<(), Box<dyn std::error::Error>> {
-    /// let builder = CreateInvite::new().unique(true);
-    /// let invite = channel.create_invite(&http, builder).await?;
-    /// # Ok(())
-    /// # }
-    /// ```
     pub fn unique(mut self, unique: bool) -> Self {
         self.unique = Some(unique);
         self

src/builder/edit_role.rs

@@ -9,10 +9,6 @@ use crate::model::prelude::*;
 ///
 /// These are:
 ///
-/// - [`PartialGuild::create_role`]
-/// - [`PartialGuild::edit_role`]
-/// - [`Guild::create_role`]
-/// - [`Guild::edit_role`]
 /// - [`GuildId::create_role`]
 /// - [`GuildId::edit_role`]
 /// - [`Role::edit`]

src/builder/edit_sticker.rs

@@ -11,8 +11,6 @@ use crate::model::prelude::*;
 ///
 /// These are:
 ///
-/// - [`Guild::edit_sticker`]
-/// - [`PartialGuild::edit_sticker`]
 /// - [`GuildId::edit_sticker`]
 /// - [`Sticker::edit`]
 ///

src/builder/get_messages.rs

@@ -21,7 +21,7 @@ use crate::model::prelude::*;
 /// The other parameter specifies the number of messages to retrieve. This is _optional_, and
 /// defaults to 50 if not specified.
 ///
-/// See [`GuildChannel::messages`] for more examples.
+/// See [`ChannelId::messages`] for more examples.
 ///
 /// # Examples
 ///

src/gateway/client/context.rs

@@ -334,7 +334,7 @@ impl Context {
     ///
     /// # Errors
     ///
-    /// See [`Guild::create_emoji`] for information about name and filesize requirements. This
+    /// See [`GuildId::create_emoji`] for information about name and filesize requirements. This
     /// method will error if said requirements are not met.
     pub async fn create_application_emoji(&self, name: &str, image: &str) -> Result<Emoji> {
         #[derive(serde::Serialize)]