Fix GuildChannel::is_text_based for Thread Channels (#3025)

m1sk9 · web-flow · commit e14acafed8e9 · 2024-11-11T20:01:02.000Z
diff --git a/src/model/channel/guild_channel.rs b/src/model/channel/guild_channel.rs
@@ -202,7 +202,13 @@ impl GuildChannel {
     pub fn is_text_based(&self) -> bool {
         matches!(
             self.kind,
-            ChannelType::Text | ChannelType::News | ChannelType::Voice | ChannelType::Stage
+            ChannelType::Text
+                | ChannelType::News
+                | ChannelType::Voice
+                | ChannelType::Stage
+                | ChannelType::PublicThread
+                | ChannelType::PrivateThread
+                | ChannelType::NewsThread
         )
     }
 
diff --git a/src/model/channel/mod.rs b/src/model/channel/mod.rs
@@ -254,7 +254,7 @@ enum_number! {
         /// An indicator that the channel is a forum [`GuildChannel`].
         Forum = 15,
         _ => Unknown(u8),
-    }
+    } // Make sure to update [`GuildChannel::is_text_based`].
 }
 
 impl ChannelType {

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,13 @@ impl GuildChannel {`
`202`	`202`	`pub fn is_text_based(&self) -> bool {`
`203`	`203`	`matches!(`
`204`	`204`	`self.kind,`
`205`		`- ChannelType::Text \| ChannelType::News \| ChannelType::Voice \| ChannelType::Stage`
	`205`	`+ ChannelType::Text`
	`206`	`+ \| ChannelType::News`
	`207`	`+ \| ChannelType::Voice`
	`208`	`+ \| ChannelType::Stage`
	`209`	`+ \| ChannelType::PublicThread`
	`210`	`+ \| ChannelType::PrivateThread`
	`211`	`+ \| ChannelType::NewsThread`
`206`	`212`	`)`
`207`	`213`	`}`
`208`	`214`
Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,7 @@ enum_number! {`
`254`	`254`	/// An indicator that the channel is a forum [`GuildChannel`].
`255`	`255`	`Forum = 15,`
`256`	`256`	`_ => Unknown(u8),`
`257`		`- }`
	`257`	+ } // Make sure to update [`GuildChannel::is_text_based`].
`258`	`258`	`}`
`259`	`259`
`260`	`260`	`impl ChannelType {`