Skip to content

Add banner model to Member and PartialMember #3368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arqunis merged 3 commits into from
Aug 29, 2025
Merged

Add banner model to Member and PartialMember #3368

arqunis merged 3 commits into from
Aug 29, 2025

Conversation

@TapGhoul
Copy link
Contributor

@TapGhoul TapGhoul commented May 23, 2025 •
edited
Loading

Adds missing fields in member data.
Annoyingly, discord does not allow us to update this data in guilds at the moment (that I can find) so it's just this for now.

@github-actions github-actions bot added model Related to the `model` module. cache Related to the `cache`-feature. labels May 23, 2025
@TapGhoul TapGhoul force-pushed the model-add-banner branch 2 times, most recently from eaf3f4f to e19d3d5 Compare May 23, 2025 09:06
GnomedDev
GnomedDev reviewed May 23, 2025
View reviewed changes
Copy link
Member

@GnomedDev GnomedDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small doc update update needed.

Is there a reason this is targeting next instead of current?

@GnomedDev GnomedDev added the needs-testing A PR that should work, but needs a functional test label May 23, 2025
@TapGhoul
Copy link
Contributor Author

TapGhoul commented May 23, 2025

Looks good, just a small doc update update needed.

Is there a reason this is targeting next instead of current?

From previous discussion, this was in next because the struct member is pub and therefore it's a breaking interface change.

@GnomedDev
Copy link
Member

GnomedDev commented May 23, 2025

I don't see where this is breaking? It's not changing existing fields and where new fields are added they are already non_exhaustive?

@TapGhoul
Copy link
Contributor Author

TapGhoul commented May 23, 2025

I don't see where this is breaking? It's not changing existing fields and where new fields are added they are already non_exhaustive?

Oh wait sorry I got wires crossed, I was thinking of the other old PR - not this one. You're right. I can rebase.

@TapGhoul TapGhoul force-pushed the model-add-banner branch from 92831a0 to 2d8ee47 Compare May 23, 2025 13:18
@TapGhoul TapGhoul changed the base branch from next to current May 23, 2025 13:19
@arqunis arqunis added enhancement An improvement to Serenity. and removed needs-testing A PR that should work, but needs a functional test labels Aug 29, 2025
@arqunis arqunis merged commit d11970f into serenity-rs:current Aug 29, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GnomedDev GnomedDev GnomedDev left review comments

@arqunis arqunis arqunis approved these changes

Assignees

No one assigned

Labels

cache Related to the `cache`-feature. enhancement An improvement to Serenity. model Related to the `model` module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TapGhoul @GnomedDev @arqunis