New minimal dependency for reqwest #3385
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GnomedDev
requested changes
Jul 25, 2025
Member
GnomedDev
left a comment
GnomedDev
left a comment
There was a problem hiding this comment.
This is failing CI due to what looks to be incompatibilities. Since we are releasing next soon™ this is probably not worth hacking around to make compatible with both. I'll leave this open if you can fix it nicely, but I recommend closing it.
Contributor
|
I think @Jasper-Bekkers just missed bumping the http_crate dev dependency that is only used during testing. edit: |
Member
|
Closing in favour of #3404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reqwest has been released for a while and this crate seems to be fully compatible with both versions. In order to shrink our list of duplicate dependencies downstream I'm PRing this to keep folks from being able to use 0.11 but also jump on 0.12 if that fits their dependencies better.