Accept ImageData when passing an image for an emoji in GuildId::create_emoji
#3386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, users were able to create the base64-encoded blob of data via
CreateAttachment::to_base64, which returned a string. Onnext, this method had been replaced byencode, which returns anImageDatainstead.It is still the base64-encoded blob of data as before, but users were no longer able to access it directly. This wasn't too much of a problem, as many places that accepted a plain string switched to expecting
ImageData. So for users, nothing practically has changed. ExceptGuildId::create_emoji, which still wanted a string, yet users couldn't reuse anyImageDatathey might have already had.This rectifies the issue by not only switching
image: &strtoimage: ImageDatainGuildId::create_emoji, but also adding an accessor method for the blob of data inImageData.