Fixing the README to make it beauty #3406
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
builder
GnomedDev
requested changes
Aug 11, 2025
Member
GnomedDev
left a comment
GnomedDev
left a comment
There was a problem hiding this comment.
I prefer the old version, and this includes random other code changes.
I am not going to immediately close this, but I am happy for another maintainer to.
jamesbt365
reviewed
Aug 11, 2025
src/gateway/error.rs
Outdated
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| match self { | ||
| Self::BuildingUrl => f.write_str("Error building url"), | ||
| Self::BuildingUrl => f.write_str("Error: Failed to build url"), |
Member
There was a problem hiding this comment.
none of the other variants use the Error: prefix. All together i'd prefer you didn't touch the code at all in a PR that "fixes" the README.
Like you requesting for it
Notice the ing
Member
You're still making code changes |
Author
|
Or i’ll close this, just for sure |
Author
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reason for my pull request:
hello there i was so kinda lil bored by try fix my issue so i was change small stuffs just to make it perfect and great so i was thinking fixing the readme even if look old i was kinda wanna make it looks Good, so that's it and thank you.