Skip to content

Conversation

@LikeLakers2
Copy link
Contributor

Hi! There really isn't much to this PR - it's just a documentation fix.

Specifically, in serenity::model::guild::Guild, the documentation for Guild.features featured a list of guild features - including three list items that were duplicates of previous items. This PR removes those three duplicates.

@github-actions github-actions bot added the model Related to the `model` module. label Aug 17, 2025
@jamesbt365
Copy link
Member

Can't speak for others but we should just remove the list of features, users can refer to the official discord docs or https://docs.discord.food (don't link this tho) for a list of features.

The official docs list is incomplete but contains enough for the common usecases, we shouldn't try and mirror the docs there to here.

@LikeLakers2
Copy link
Contributor Author

@jamesbt365 Do you want me to wait to see what others say on the matter, or do you want me to remove the rest of the items?

@GnomedDev
Copy link
Member

I agree with James, we should remove the raw list of features and just link to the discord documentation for that. I would also like to see a subtitle like "These are user-invisible options which are used for Discord rollouts and/or paid benefits" or something like that.

@LikeLakers2
Copy link
Contributor Author

So am I removing the rest of the items? Or is this planning for a future PR?

@GnomedDev
Copy link
Member

Yeah, remove the list and if you are good with adding the subtitle do that as well.

@LikeLakers2
Copy link
Contributor Author

How does that look?

Copy link
Member

@GnomedDev GnomedDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@GnomedDev GnomedDev merged commit 2eed823 into serenity-rs:current Aug 23, 2025
21 of 22 checks passed
@LikeLakers2 LikeLakers2 deleted the fix/docs/duplicate_guild_features branch August 23, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model Related to the `model` module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants