Handle query parameters for webhook requests #3410
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates how query parameters are handled when sending webhook requests in the
Httpclient. The main change is that query parameters from the URL are now parsed and passed along with the request, rather than always being set toNone.Improvements to webhook request handling:
url.query_pairs(), collected into a vector, and passed to the request if present, otherwise set toNone(src/http/client.rs).paramsfield in theRequeststruct is now set to the parsed query parameters instead of always beingNone(src/http/client.rs).