-
Notifications
You must be signed in to change notification settings - Fork 637
Refactor CI workflows #3414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor CI workflows #3414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Seems the MSRV job isn't being skipped - will fix tomorrow |
…eck` Gets rid of separate job for nightly
arqunis
approved these changes
Sep 4, 2025
BossFlea
pushed a commit
to BossFlea/serenity
that referenced
this pull request
Sep 16, 2025
This improves the ergonomics of the CI workflows and cuts down on CI runtime by adding a new `check` job for feature flags which only need to be tested using `cargo check` rather than `cargo test`. I removed the dedicated `nightly` job by including it in the `test` job. Also added `temp_cache` to the list of features to check; for some reason it wasn't included in CI before.
BossFlea
pushed a commit
to BossFlea/serenity
that referenced
this pull request
Sep 16, 2025
This improves the ergonomics of the CI workflows and cuts down on CI runtime by adding a new `check` job for feature flags which only need to be tested using `cargo check` rather than `cargo test`. I removed the dedicated `nightly` job by including it in the `test` job. Also added `temp_cache` to the list of features to check; for some reason it wasn't included in CI before.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
This improves the ergonomics of the CI workflows and cuts down on CI runtime by adding a new `check` job for feature flags which only need to be tested using `cargo check` rather than `cargo test`. I removed the dedicated `nightly` job by including it in the `test` job. Also added `temp_cache` to the list of features to check; for some reason it wasn't included in CI before.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
This improves the ergonomics of the CI workflows and cuts down on CI runtime by adding a new `check` job for feature flags which only need to be tested using `cargo check` rather than `cargo test`. I removed the dedicated `nightly` job by including it in the `test` job. Also added `temp_cache` to the list of features to check; for some reason it wasn't included in CI before.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
This improves the ergonomics of the CI workflows and cuts down on CI runtime by adding a new `check` job for feature flags which only need to be tested using `cargo check` rather than `cargo test`. I removed the dedicated `nightly` job by including it in the `test` job. Also added `temp_cache` to the list of features to check; for some reason it wasn't included in CI before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cache
Related to the `cache`-feature.
ci
Related to the continuous integration.
enhancement
An improvement to Serenity.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the ergonomics of the CI workflows and cuts down on CI runtime by adding a new
checkjob for feature flags which only need to be tested usingcargo checkrather thancargo test. I removed the dedicatednightlyjob by including it in thetestjob.Also added
temp_cacheto the list of features to check; for some reason it wasn't included in CI before.