Skip to content

Conversation

@mkrasnitski
Copy link
Collaborator

@mkrasnitski mkrasnitski commented Sep 1, 2025

This improves the ergonomics of the CI workflows and cuts down on CI runtime by adding a new check job for feature flags which only need to be tested using cargo check rather than cargo test. I removed the dedicated nightly job by including it in the test job.

Also added temp_cache to the list of features to check; for some reason it wasn't included in CI before.

@github-actions github-actions bot added cache Related to the `cache`-feature. ci Related to the continuous integration. labels Sep 1, 2025
@mkrasnitski
Copy link
Collaborator Author

Seems the MSRV job isn't being skipped - will fix tomorrow

@arqunis arqunis added the enhancement An improvement to Serenity. label Sep 4, 2025
@arqunis arqunis merged commit 1d01e47 into serenity-rs:next Sep 4, 2025
25 checks passed
@mkrasnitski mkrasnitski deleted the fix-ci branch September 5, 2025 03:26
BossFlea pushed a commit to BossFlea/serenity that referenced this pull request Sep 16, 2025
This improves the ergonomics of the CI workflows and cuts down on CI
runtime by adding a new `check` job for feature flags which only need to
be tested using `cargo check` rather than `cargo test`. I removed the
dedicated `nightly` job by including it in the `test` job.

Also added `temp_cache` to the list of features to check; for some
reason it wasn't included in CI before.
BossFlea pushed a commit to BossFlea/serenity that referenced this pull request Sep 16, 2025
This improves the ergonomics of the CI workflows and cuts down on CI
runtime by adding a new `check` job for feature flags which only need to
be tested using `cargo check` rather than `cargo test`. I removed the
dedicated `nightly` job by including it in the `test` job.

Also added `temp_cache` to the list of features to check; for some
reason it wasn't included in CI before.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Oct 7, 2025
This improves the ergonomics of the CI workflows and cuts down on CI
runtime by adding a new `check` job for feature flags which only need to
be tested using `cargo check` rather than `cargo test`. I removed the
dedicated `nightly` job by including it in the `test` job.

Also added `temp_cache` to the list of features to check; for some
reason it wasn't included in CI before.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Oct 7, 2025
This improves the ergonomics of the CI workflows and cuts down on CI
runtime by adding a new `check` job for feature flags which only need to
be tested using `cargo check` rather than `cargo test`. I removed the
dedicated `nightly` job by including it in the `test` job.

Also added `temp_cache` to the list of features to check; for some
reason it wasn't included in CI before.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Oct 7, 2025
This improves the ergonomics of the CI workflows and cuts down on CI
runtime by adding a new `check` job for feature flags which only need to
be tested using `cargo check` rather than `cargo test`. I removed the
dedicated `nightly` job by including it in the `test` job.

Also added `temp_cache` to the list of features to check; for some
reason it wasn't included in CI before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cache Related to the `cache`-feature. ci Related to the continuous integration. enhancement An improvement to Serenity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants