More tests are added

Author: serge1

ario/ario.hpp

@@ -202,6 +202,28 @@ class ario
             return parent->members_.cend();
         }
 
+        //------------------------------------------------------------------------------
+        //! @brief Get a const reference to the first member
+        //! @return Const reference to the first member
+        const Member& front() const
+        {
+            if ( parent->members_.empty() ) {
+                throw std::out_of_range( "No members in archive" );
+            }
+            return parent->members_.front();
+        }
+
+        //------------------------------------------------------------------------------
+        //! @brief Get a const reference to the last member
+        //! @return Const reference to the last member
+        const Member& back() const
+        {
+            if ( parent->members_.empty() ) {
+                throw std::out_of_range( "No members in archive" );
+            }
+            return parent->members_.back();
+        }
+
       private:
         ario* parent; //!< Pointer to the parent ario object
     };
@@ -383,14 +405,14 @@ class ario
     //! @brief Add a member to the archive
     //! @param member The member to add
     //! @param data The data associated with the member
-    //! @param added_member Reference to store the added member
     //! @return Error object indicating success or failure
-    Result
-    add_member( const Member&      member,
-                const std::string& data,
-                std::optional<std::reference_wrapper<const ario::Member>>&
-                    added_member )
+    Result add_member( const Member& member, const std::string& data )
     {
+        // Don't allow empty member names
+        if ( member.name.empty() ) {
+            return { "Member name cannot be empty" };
+        }
+
         // Check if the member with such name already exists
         for ( const auto& mem : members_ ) {
             if ( mem.name == member.name ) {
@@ -412,7 +434,6 @@ class ario
             new_member.short_name = "/" + std::to_string( location );
         }
 
-        added_member = new_member;
         return {};
     }
 
@@ -476,7 +497,10 @@ class ario
 
             pstream->read( header, HEADER_SIZE );
             if ( pstream->gcount() < HEADER_SIZE ) {
-                break; // End of file or error
+                if ( pstream->gcount() > 0 ) {
+                    return { "Corrupted archive" }; // End of file or error
+                }
+                break; // End of file reached
             }
             std::streamoff current_pos = pstream->tellg();
             m.short_name               = std::string( header, FIELD_NAME_SIZE );

examples/arioso/arioso.cpp

@@ -164,11 +164,8 @@ static int copy_members( const CommandLineOptions& opts,
             continue; // Skip this member
         }
 
-        std::optional<std::reference_wrapper<const ario::Member>> added_member =
-            std::nullopt;
-        auto result =
-            target_archive.add_member( member, member.data(), added_member );
-        if ( !result.ok() || added_member == std::nullopt ) {
+        auto result = target_archive.add_member( member, member.data() );
+        if ( !result.ok() ) {
             std::cerr << "Error adding member '" << member.name
                       << "': " << result.what() << std::endl;
             return 3;
@@ -177,7 +174,8 @@ static int copy_members( const CommandLineOptions& opts,
         // Copy member symbols
         std::vector<std::string> symbols;
         archive.get_symbols_for_member( member, symbols );
-        target_archive.add_symbols_for_member( added_member->get(), symbols );
+        target_archive.add_symbols_for_member( target_archive.members.back(),
+                                               symbols );
     }
 
     return 0;
@@ -241,9 +239,7 @@ static ario::Result add_new_member( ario&                   archive,
     const std::string data( ( std::istreambuf_iterator<char>( input ) ),
                             std::istreambuf_iterator<char>() );
 
-    std::optional<std::reference_wrapper<const ario::Member>> added_member =
-        std::nullopt;
-    const auto result = archive.add_member( new_member, data, added_member );
+    const auto result = archive.add_member( new_member, data );
     if ( !result.ok() ) {
         return result;
     }
@@ -252,7 +248,8 @@ static ario::Result add_new_member( ario&                   archive,
     if ( elf.load( full_file_path.string() ) ) {
         std::vector<std::string> gathered_symbols;
         collect_elf_global_symbols( elf, gathered_symbols );
-        archive.add_symbols_for_member( added_member->get(), gathered_symbols );
+        archive.add_symbols_for_member( archive.members.back(),
+                                        gathered_symbols );
     }
 
     return {}; // Return success