Fix possible nullptr dereference

saveasguy · serge1 · commit e656f75767db · 2024-11-06T20:18:27.000+02:00
diff --git a/elfio/elfio.hpp b/elfio/elfio.hpp
@@ -138,8 +138,12 @@ class elfio
     bool load( const std::string& file_name, bool is_lazy = false )
     {
         pstream = std::make_unique<std::ifstream>();
+        if ( !pstream ) {
+            return false;
+        }
+
         pstream->open( file_name.c_str(), std::ios::in | std::ios::binary );
-        if ( pstream == nullptr || !*pstream ) {
+        if ( !*pstream ) {
             return false;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -138,8 +138,12 @@ class elfio`
`138`	`138`	`bool load( const std::string& file_name, bool is_lazy = false )`
`139`	`139`	`{`
`140`	`140`	`pstream = std::make_unique<std::ifstream>();`
	`141`	`+ if ( !pstream ) {`
	`142`	`+ return false;`
	`143`	`+ }`
	`144`	`+`
`141`	`145`	`pstream->open( file_name.c_str(), std::ios::in \| std::ios::binary );`
`142`		`- if ( pstream == nullptr \|\| !*pstream ) {`
	`146`	`+ if ( !*pstream ) {`
`143`	`147`	`return false;`
`144`	`148`	`}`
`145`	`149`