Make single quotes for string property optional

[Janry]

Hi.
`
I have problem with single quotes. In code you replace all """ to "'". Can you please make this replace optional. I need just empty string for this. Because for example enum.SomeValue convert to "SomeValue", but string "SomeValue" to "'SomeValue'" and it's not looks like good.
I solved my problem with ILogEventEnricher and LogEventPropertyValue inherit my log event property from ScalarValue and override Render. But with parameter in appsettings.json will be better.

Thank you.

[mishamyte]

Hi @Janry,

Will look into that. We do some replacing like that to fix a payload.

I will look into your case

[mishamyte]

Also @Janry,

Could you provide a simple repro, cause I've tested on a simple example:

And seems like here are no extra quotes:

Loki's query is {app="web_app"} | json

[Janry]

Hi, @mishamyte. Thank you for your reply.

When you add global property in Lables in appsettings.json it looks good without escape single quotes.
When you use Enrich.WithProperty with runtime values it has single quotes escape.

[mishamyte]

What version of package do you use? And also Loki + Grafana version would be nice to know.

So I just tested for Enrich.WithProperty (if I understand correctly, WithUnquoutedProperty is something yours).

So I modified the console sample from this repo. Added cluster property.

Log.Logger = new LoggerConfiguration()
            .MinimumLevel.Debug()
            .Enrich.WithThreadId()
            .Enrich.WithProperty("meaning_of_life", 42)
            .Enrich.WithProperty("cluster", "local")
            .WriteTo.Console(outputTemplate: OutputTemplate)
            .WriteTo.GrafanaLoki(
                "http://localhost:3100",
                new List<LokiLabel> { new() { Key = "app", Value = "console" } },
                credentials: null)
            .CreateLogger();

In this case I got the next results:

My Loki query is {app="console"} | json

So you could see that there are no single quotes here. Detected fileds are in double quoutes and when it is parsed to labels by a | json parser, there are no quotes remaining.

For this test I used Serilog.Sinks.Grafana.Loki v8.0.0, Grafana v9.1.6 and Loki v2.6.1

[mishamyte]

Hi @Janry,

Any suggestions for this case from your side?