Add tests for filenames with windows and fix a recursion bug #286

Author: remi-braun

ci/on_push/test_others.py

@@ -595,3 +595,24 @@ def test_constellations():
 
 def test_regex_glob():
     ci.assert_val(convert_glob_to_regex("**/*_rgb.png"), r".*/.*_rgb\.png", "ASF regex")
+
+
+def test_filename_window():
+    prod_path = opt_path().joinpath("LT05_L1TP_200030_20111110_20200820_02_T1")
+    window_path = others_path().joinpath(
+        "20201220T104856_L8_200030_OLI_TIRS_window.geojson"
+    )
+    prod = READER.open(prod_path, remove_tmp=True)
+    extent = prod.extent()
+    ci.assert_val(
+        prod.get_band_file_name("RED", pixel_size=20, window=extent),
+        prod.get_band_file_name("RED", pixel_size=20),
+        "Extent window",
+    )
+
+    with pytest.raises(AssertionError):
+        ci.assert_val(
+            prod.get_band_file_name("RED", pixel_size=20, window=window_path),
+            prod.get_band_file_name("RED", pixel_size=20),
+            "Small window",
+        )

eoreader/products/product.py

@@ -141,7 +141,7 @@ def __init__(
         **kwargs,
     ) -> None:
         self.needs_extraction = True
-        """Does this product needs to be extracted to be processed ? (:code:`True` by default)."""
+        """Does this product needs to be extracted to be processed? (:code:`True` by default)."""
 
         self.path = AnyPath(product_path)
         if (
@@ -833,9 +833,14 @@ def get_band_file_name(
 
         # Window
         window = kwargs.get("window")
-        win_suffix = ""
+        max_extent = None
         if window is not None:
-            win_suffix = f"_{utils.get_window_suffix(window, max_extent=self.extent())}"
+            # This way we can avoid RecursionError when computing extents (which doesn't have a window)
+            max_extent = self.extent()
+
+        win_suffix = utils.get_window_suffix(window, max_extent=max_extent)
+        if win_suffix:
+            win_suffix = f"_{win_suffix}"
 
         # Specific if needed
         if dem_name: