FIX: Fix crash of _reorder_loaded_bands_like_input with indices and associated_bands

remi-braun · remi-braun · commit 80cf59521b04 · 2025-04-29T14:12:09.000+02:00
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,5 +1,9 @@
 # Release History
 
+## 0.22.3 (2025-mm-dd)
+
+- FIX: Fix crash of _`reorder_loaded_bands_like_input` with indices and associated_bands
+
 ## 0.22.2 (2025-04-18)
 
 - FIX: Fix GPT graphs (mutiple errors, such a lonely `Subset`, a `LinearToFromdB` step not written, etc.)
diff --git a/eoreader/products/optical/s2_product.py b/eoreader/products/optical/s2_product.py
@@ -835,7 +835,7 @@ def _reorder_loaded_bands_like_input(
         )
 
         for band in bands:
-            if associated_bands:
+            if associated_bands and band in associated_bands:
                 for associated_band in associated_bands[band]:
                     key = self._get_band_key(band, associated_band, **kwargs)
                     reordered_dict[key] = bands_dict[key]
diff --git a/eoreader/products/optical/s2_theia_product.py b/eoreader/products/optical/s2_theia_product.py
@@ -521,7 +521,7 @@ def _reorder_loaded_bands_like_input(
         )
 
         for band in bands:
-            if associated_bands:
+            if associated_bands and band in associated_bands:
                 for associated_band in associated_bands[band]:
                     key = self._get_band_key(band, associated_band, **kwargs)
                     reordered_dict[key] = bands_dict[key]

Original file line number	Diff line number	Diff line change
`@@ -835,7 +835,7 @@ def _reorder_loaded_bands_like_input(`
`835`	`835`	`)`
`836`	`836`
`837`	`837`	`for band in bands:`
`838`		`- if associated_bands:`
	`838`	`+ if associated_bands and band in associated_bands:`
`839`	`839`	`for associated_band in associated_bands[band]:`
`840`	`840`	`key = self._get_band_key(band, associated_band, **kwargs)`
`841`	`841`	`reordered_dict[key] = bands_dict[key]`
Original file line number	Diff line number	Diff line change
`@@ -521,7 +521,7 @@ def _reorder_loaded_bands_like_input(`
`521`	`521`	`)`
`522`	`522`
`523`	`523`	`for band in bands:`
`524`		`- if associated_bands:`
	`524`	`+ if associated_bands and band in associated_bands:`
`525`	`525`	`for associated_band in associated_bands[band]:`
`526`	`526`	`key = self._get_band_key(band, associated_band, **kwargs)`
`527`	`527`	`reordered_dict[key] = bands_dict[key]`