FIX: Set EPSG:4326 for rasters with empty CRS to be orthorectified with RPCs

Author: remi-braun

CHANGES.md

@@ -24,7 +24,8 @@
 - FIX: Handle GCPs in VHR data
 - FIX: Fix raw CRS exported as string rather than CRS object for Maxar data [#255](https://github.com/sertit/eoreader/issues/255)
 - FIX: Use only the number of range looks to derive the resolution and pixel_size of CSG data [#256](https://github.com/sertit/eoreader/issues/256)
-- FIX: Retunr an empty `lxml.Element` as metadata for S1 RTC ASF products instead of `None` to ensure consistency
+- FIX: Return an empty `lxml.Element` as metadata for S1 RTC ASF products instead of `None` to ensure consistency
+- FIX: Set `EPSG:4326` for rasters with empty CRS to be orthorectified with RPCs 
 - OPTIM: Use raw band path over default band path to speed up the computation of image information (extent, footprint, CRS, transform) of SAR ortho products
 - OPTIM: Allow predictor = 3 with LZW compression when saving SAR intermediate data as SNAP handles it properly now. [#173](https://github.com/sertit/eoreader/issues/173)
 - CI: Filter some warnings in pytest

eoreader/products/product.py

@@ -2594,6 +2594,12 @@ def _orthorectify(
         kw = utils._prune_keywords(["nodata", "num_threads"], **kwargs)
         resampling = kw.pop("resampling", self.band_resampling)
         vcrs = kw.pop("vcrs", os.getenv(DEM_VCRS))
+
+        if rpcs and not src_xda.rio.crs:
+            # RPCs are always in 4326 by convention
+            # https://rasterio.readthedocs.io/en/latest/topics/reproject.html#reprojecting-with-other-georeferencing-metadata
+            src_xda.rio.write_crs(vectors.EPSG_4326, inplace=True)
+
         out_xda = rasters.reproject(
             src_xda,
             rpcs=rpcs,