Test #307 against a real MPC Landsat product

Replace the hand-built STAC item with a real Landsat C2 L2 item from
Planetary Computer (per review), asserting the NIR band path resolves
to the SR_B5 asset instead of raising KeyError. Test lives alongside the
other MPC STAC tests.

Author: gaoflow

ci/on_push/test_others.py

@@ -616,45 +616,3 @@ def test_filename_window():
             prod.get_band_file_name("RED", pixel_size=20),
             "Small window",
         )
-
-
-def test_landsat_stac_asset_resolution():
-    """Resolve Landsat STAC bands whose asset name differs from the common name.
-
-    Landsat Collection-2 STAC items (Planetary Computer, Element84) expose the
-    NIR band as ``nir08`` rather than the STAC common name ``nir``. Resolving a
-    band must fall back to a fuzzy match against the actual asset keys instead of
-    raising ``KeyError`` (#307).
-    """
-    import types
-    from datetime import datetime, timezone
-
-    import pystac
-
-    from eoreader.products.optical.landsat_product import LandsatStacProduct
-
-    def _fake_product(asset_names):
-        item = pystac.Item(
-            id="test",
-            geometry=None,
-            bbox=None,
-            datetime=datetime(2026, 5, 24, tzinfo=timezone.utc),
-            properties={},
-        )
-        for name in asset_names:
-            item.add_asset(name, pystac.Asset(href=f"https://example.com/{name}.tif"))
-        prod = LandsatStacProduct.__new__(LandsatStacProduct)
-        prod.item = item
-        prod.bands = {NIR: types.SimpleNamespace(id=5)}  # Landsat NIR is B5
-        prod.sign_url = lambda href: href
-        return prod
-
-    # Landsat C2: the NIR asset is "nir08" -> fuzzy fallback resolves it
-    landsat = _fake_product(
-        ["coastal", "blue", "green", "red", "nir08", "swir16", "swir22"]
-    )
-    assert landsat._get_path("B5") == "https://example.com/nir08.tif"
-
-    # Sentinel-style item whose asset really is "nir" -> direct mapping, unchanged
-    sentinel = _fake_product(["blue", "green", "red", "nir", "swir16"])
-    assert sentinel._get_path("B5") == "https://example.com/nir.tif"

ci/on_push/test_stac_items.py

@@ -8,6 +8,7 @@
 from tempenv import tempenv
 
 from ci.scripts_utils import READER, compare, reduce_verbosity
+from eoreader.bands import NIR
 from eoreader.products import Product
 from eoreader.reader import Constellation
 
@@ -96,6 +97,24 @@ def test_l5_mpc():
     )
 
 
+def test_l9_l2_mpc_nir_asset():
+    """Resolving the NIR band of a Landsat C2 L2 MPC item must not raise (#307).
+
+    These items expose the NIR band under the versioned STAC asset name
+    ``nir08`` rather than the generic ``nir``, which used to raise
+    ``KeyError: 'nir'`` when getting the band path.
+    """
+    prod = READER.open(
+        "https://planetarycomputer.microsoft.com/api/stac/v1/collections/landsat-c2-l2/items/LC09_L2SP_095022_20231119_02_T2",
+        remove_tmp=True,
+    )
+    assert prod is not None
+
+    band_paths = prod.get_band_paths([NIR])
+    # NIR is band 5 on Landsat-8/9: the resolved asset is the SR_B5 file
+    assert "B5" in str(band_paths[NIR])
+
+
 def test_s2_mpc():
     """Function testing the support of Sentinel-2 L2A (COG) constellation processed by MPC and linked via a STAC URL"""
     _test_core(