Force nodata in stack

Author: remi-braun

ci/on_push/test_others.py

@@ -495,7 +495,7 @@ def test_custom_resamplings():
 
 @s3_env
 def test_write(tmp_path):
-    """Test custom resamplings"""
+    """Test write with different drivers"""
     # Get paths
     prod_path = opt_path().joinpath("LT05_L1TP_200030_20111110_20200820_02_T1")
     window_path = others_path().joinpath(
@@ -520,7 +520,6 @@ def test_write(tmp_path):
     assert_is_cog(cog)
 
     # Don't set it with os.environ otherwise it'll break all the test suite!
-
     with tempenv.TemporaryEnvironment({"EOREADER_DEFAULT_DRIVER": "GTiff"}):
         gtiff_env = tmp_path / "gtiff_e.tif"
         prod.stack(RED, window=window_path, pixel_size=60, stack_path=gtiff_env)
@@ -536,8 +535,6 @@ def test_write(tmp_path):
         driver="Zarr",
         compress="NONE",
     )
-    with pytest.raises(AssertionError):
-        assert_is_cog(gtiff_env)
 
     # Just test to read the zarr array
     np.testing.assert_array_equal(zstack.data, utils.read(zarr).data)

eoreader/products/product.py

@@ -1959,8 +1959,6 @@ def _collocate_bands(bands: dict, reference: xr.DataArray = None) -> dict:
 
         return bands
 
-    # pylint: disable=R0913
-    # Too many arguments (6/5)
     def stack(
         self,
         bands: list,
@@ -1971,7 +1969,7 @@ def stack(
         **kwargs,
     ) -> xr.DataArray:
         """
-        Stack bands and index of a products.
+        Stack bands and index of a product.
 
         .. code-block:: python
 

eoreader/utils.py

@@ -546,12 +546,9 @@ def stack(band_xds: xr.Dataset, **kwargs) -> (xr.DataArray, type):
         .transpose("bands", "y", "x")
     )
 
-    if dtype == np.float32:
-        # Set nodata if needed (NaN values are already set)
-        if stack.rio.encoded_nodata != nodata:
-            stack = stack.astype(dtype).rio.write_nodata(
-                nodata, encoded=True, inplace=True
-            )
+    # Set nodata if needed (NaN values are already set)
+    if dtype == np.float32 and stack.rio.encoded_nodata != nodata:
+        stack = rasters.set_nodata(stack.astype(dtype), nodata)
 
     return stack, dtype