fix: working-directory invalid

Signed-off-by: 张星宇 <neil.zxy@alibaba-inc.com>

Author: 张星宇

packages/engine/__tests__/failure.test.ts

@@ -16,6 +16,15 @@ test('某一步执行失败，错误信息记录在context.error', async () => {
   expect(res.error).toBeInstanceOf(Error);
 });
 
+test('路径错误，正常抛出', async () => {
+  const steps = [
+    { run: 'npm install', id: 'xhello', "working-directory": './xsadads' },
+  ] as IStepOptions[];
+  const engine = new Engine({ steps, logConfig: { logPrefix } });
+  const res: IContext | undefined = await engine.start();
+  expect(res.error).toBeInstanceOf(Error);
+});
+
 test('某一步执行失败，后续步骤执行状态为skip', async () => {
   const steps = [
     { run: 'echo "hello"', id: 'xhello' },

packages/engine/src/index.ts

@@ -8,6 +8,7 @@ import { parsePlugin, getProcessTime, getDefaultInitLog, getLogPath, getPluginRe
 import { INIT_STEP_COUNT, INIT_STEP_NAME, COMPLETED_STEP_COUNT, DEFAULT_COMPLETED_LOG, SERVERLESS_CD_KEY, SERVERLESS_CD_VALUE } from './constants';
 import execDaemon from './exec-daemon';
 import { filter, join } from 'lodash';
+import fs from 'fs';
 
 export { IStepOptions, IContext } from './types';
 
@@ -382,6 +383,14 @@ class Engine {
       }
     }
   }
+  private validateWorkingDirectory(path: string) {
+    if (!fs.existsSync(path)) {
+      throw new Error(`Invalid working directory: ${path}`);
+    }
+    if (!fs.statSync(path).isDirectory()) {
+      throw new Error(`Path is not a directory: ${path}`);
+    }
+  }
   private outputErrorLog(error: Error) {
     const logConfig = this.options.logConfig as ILogConfig;
     const { customLogger } = logConfig;
@@ -398,6 +407,9 @@ class Engine {
     if (runItem.run) {
       debug(`run: ${runItem.run}`);
       let execPath = runItem['working-directory'] || this.context.cwd;
+      if (execPath) {
+        this.validateWorkingDirectory(execPath);
+      }
       execPath = path.isAbsolute(execPath) ? execPath : path.join(this.context.cwd, execPath);
       this.logName(item);
       runItem.run = this.doArtTemplateCompile(runItem.run);