Zaninis comments

Signed-off-by: fjtirado <[email protected]>

Author: fjtirado

Diff for: impl/runner.go

@@ -137,7 +137,7 @@ func (wr *workflowRunnerImpl) Run(input interface{}) (output interface{}, err er
 	wr.RunnerCtx.SetInput(input)
 	// Run tasks sequentially
 	wr.RunnerCtx.SetStatus(ctx.RunningStatus)
-	doRunner, err := NewDoTaskRunner(wr.Workflow.Do, wr.GetWorkflowDef())
+	doRunner, err := NewDoTaskRunner(wr.Workflow.Do)
 	if err != nil {
 		return nil, err
 	}

Diff for: impl/task_runner_do.go

@@ -30,26 +30,24 @@ func NewTaskRunner(taskName string, task model.Task, workflowDef *model.Workflow
 	case *model.RaiseTask:
 		return NewRaiseTaskRunner(taskName, t, workflowDef)
 	case *model.DoTask:
-		return NewDoTaskRunner(t.Do, workflowDef)
+		return NewDoTaskRunner(t.Do)
 	case *model.ForTask:
-		return NewForTaskRunner(taskName, t, workflowDef)
+		return NewForTaskRunner(taskName, t)
 	case *model.CallHTTP:
 		return NewCallHttpRunner(taskName, t)
 	default:
 		return nil, fmt.Errorf("unsupported task type '%T' for task '%s'", t, taskName)
 	}
 }
 
-func NewDoTaskRunner(taskList *model.TaskList, workflowDef *model.Workflow) (*DoTaskRunner, error) {
+func NewDoTaskRunner(taskList *model.TaskList) (*DoTaskRunner, error) {
 	return &DoTaskRunner{
-		TaskList:    taskList,
-		WorkflowDef: workflowDef,
+		TaskList: taskList,
 	}, nil
 }
 
 type DoTaskRunner struct {
-	TaskList    *model.TaskList
-	WorkflowDef *model.Workflow
+	TaskList *model.TaskList
 }
 
 func (d *DoTaskRunner) Run(input interface{}, taskSupport TaskSupport) (output interface{}, err error) {

Diff for: impl/task_runner_for.go

@@ -28,12 +28,12 @@ const (
 	forTaskDefaultAt   = "$index"
 )
 
-func NewForTaskRunner(taskName string, task *model.ForTask, workflowDef *model.Workflow) (*ForTaskRunner, error) {
+func NewForTaskRunner(taskName string, task *model.ForTask) (*ForTaskRunner, error) {
 	if task == nil || task.Do == nil {
 		return nil, model.NewErrValidation(fmt.Errorf("invalid For task %s", taskName), taskName)
 	}
 
-	doRunner, err := NewDoTaskRunner(task.Do, workflowDef)
+	doRunner, err := NewDoTaskRunner(task.Do)
 	if err != nil {
 		return nil, err
 	}