Refactor installation type detection and upgrade check logic

- Updated the installation_type function to use a case statement for improved readability and maintainability.
- Modified the upgrade check to only apply for user installations, enhancing the script's behavior for different installation types.

Author: jaydrogers

bin/spin

@@ -42,8 +42,8 @@ SPIN_ANSIBLE_COLLECTION_NAME="${SPIN_ANSIBLE_COLLECTION_NAME:-"serversideup.spin
 source "$SPIN_HOME/lib/functions.sh"
 setup_color
 
-# Check for upgrades, except for development installs and on `spin update`
-if [[ "$(installation_type)" != "development" && "$1" != "update" ]]; then
+# Check for upgrades, for only user installs
+if [[ "$(installation_type)" == "user" && "$1" != "update" ]]; then
   check_for_upgrade
 fi
 

lib/functions.sh

@@ -639,13 +639,17 @@ github_default_branch() {
 }
 
 installation_type() {
-  if [[ "$SPIN_HOME" =~ (/vendor/bin|/node_modules/.bin) ]]; then
-    echo "project"
-  elif [[ "$SPIN_HOME" =~ (\.spin) ]]; then
-    echo "user"
-  else
-    echo "development"
-  fi
+  case "$SPIN_HOME" in
+    */vendor/*|*/node_modules/*)
+      echo "project"
+      ;;
+    */.spin*)
+      echo "user"
+      ;;
+    *)
+      echo "development"
+      ;;
+  esac
 }
 
 is_encrypted_with_ansible_vault() {