Skip to content

Commit d2d1180

Browse files
author
bors-servo
authored
Auto merge of #34 - nox:backcompat, r=emilio
Support Rust 1.15 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/unicode-bidi/34) <!-- Reviewable:end -->
2 parents 019b671 + 41e1716 commit d2d1180

File tree

4 files changed

+25
-24
lines changed

4 files changed

+25
-24
lines changed

.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ rust:
55
- nightly
66
- beta
77
- stable
8+
- 1.15.0
89

910
matrix:
1011
fast_finish: true

Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "unicode-bidi"
3-
version = "0.3.0"
3+
version = "0.3.1"
44
authors = ["The Servo Project Developers"]
55
license = "MIT / Apache-2.0"
66
description = "Implementation of the Unicode Bidirectional Algorithm"

src/lib.rs

+17-17
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,9 @@ impl<'text> InitialInfo<'text> {
208208
assert!(original_classes.len() == text.len());
209209

210210
InitialInfo {
211-
text,
212-
original_classes,
213-
paragraphs,
211+
text: text,
212+
original_classes: original_classes,
213+
paragraphs: paragraphs,
214214
}
215215
}
216216
}
@@ -284,10 +284,10 @@ impl<'text> BidiInfo<'text> {
284284
}
285285

286286
BidiInfo {
287-
text,
288-
original_classes,
289-
paragraphs,
290-
levels,
287+
text: text,
288+
original_classes: original_classes,
289+
paragraphs: paragraphs,
290+
levels: levels,
291291
}
292292
}
293293

@@ -460,7 +460,7 @@ mod tests {
460460
assert_eq!(
461461
InitialInfo::new(text, None),
462462
InitialInfo {
463-
text,
463+
text: &text,
464464
original_classes: vec![L, EN],
465465
paragraphs: vec![
466466
ParagraphInfo {
@@ -475,7 +475,7 @@ mod tests {
475475
assert_eq!(
476476
InitialInfo::new(text, None),
477477
InitialInfo {
478-
text,
478+
text: &text,
479479
original_classes: vec![AL, AL, WS, R, R],
480480
paragraphs: vec![
481481
ParagraphInfo {
@@ -490,7 +490,7 @@ mod tests {
490490
assert_eq!(
491491
InitialInfo::new(text, None),
492492
InitialInfo {
493-
text,
493+
text: &text,
494494
original_classes: vec![L, B, B, B, L],
495495
paragraphs: vec![
496496
ParagraphInfo {
@@ -527,7 +527,7 @@ mod tests {
527527
assert_eq!(
528528
BidiInfo::new(text, Some(Level::ltr())),
529529
BidiInfo {
530-
text,
530+
text: &text,
531531
levels: Level::vec(&[0, 0, 0, 0, 0, 0]),
532532
original_classes: vec![L, L, L, EN, EN, EN],
533533
paragraphs: vec![
@@ -543,7 +543,7 @@ mod tests {
543543
assert_eq!(
544544
BidiInfo::new(text, Some(Level::ltr())),
545545
BidiInfo {
546-
text,
546+
text: &text,
547547
levels: Level::vec(&[0, 0, 0, 0, 1, 1, 1, 1, 1, 1]),
548548
original_classes: vec![L, L, L, WS, R, R, R, R, R, R],
549549
paragraphs: vec![
@@ -557,7 +557,7 @@ mod tests {
557557
assert_eq!(
558558
BidiInfo::new(text, Some(Level::rtl())),
559559
BidiInfo {
560-
text,
560+
text: &text,
561561
levels: Level::vec(&[2, 2, 2, 1, 1, 1, 1, 1, 1, 1]),
562562
original_classes: vec![L, L, L, WS, R, R, R, R, R, R],
563563
paragraphs: vec![
@@ -573,7 +573,7 @@ mod tests {
573573
assert_eq!(
574574
BidiInfo::new(text, Some(Level::ltr())),
575575
BidiInfo {
576-
text,
576+
text: &text,
577577
levels: Level::vec(&[1, 1, 1, 1, 1, 1, 0, 0, 0, 0]),
578578
original_classes: vec![R, R, R, R, R, R, WS, L, L, L],
579579
paragraphs: vec![
@@ -587,7 +587,7 @@ mod tests {
587587
assert_eq!(
588588
BidiInfo::new(text, None),
589589
BidiInfo {
590-
text,
590+
text: &text,
591591
levels: Level::vec(&[1, 1, 1, 1, 1, 1, 1, 2, 2, 2]),
592592
original_classes: vec![R, R, R, R, R, R, WS, L, L, L],
593593
paragraphs: vec![
@@ -603,7 +603,7 @@ mod tests {
603603
assert_eq!(
604604
BidiInfo::new(text, Some(Level::ltr())),
605605
BidiInfo {
606-
text,
606+
text: &text,
607607
levels: Level::vec(&[1, 1, 2, 1, 1, 1, 1, 1, 2, 1, 1]),
608608
original_classes: vec![AL, AL, EN, AL, AL, WS, R, R, EN, R, R],
609609
paragraphs: vec![
@@ -619,7 +619,7 @@ mod tests {
619619
assert_eq!(
620620
BidiInfo::new(text, None),
621621
BidiInfo {
622-
text,
622+
text: &text,
623623
original_classes: vec![L, WS, R, R, CS, B, R, R],
624624
levels: Level::vec(&[0, 0, 1, 1, 0, 0, 1, 1]),
625625
paragraphs: vec![

tests/conformance_tests.rs

+6-6
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ fn test_basic_conformance() {
8888
if levels != exp_levels {
8989
fails.push(
9090
Fail {
91-
line_num,
92-
input_base_level,
91+
line_num: line_num,
92+
input_base_level: input_base_level,
9393
input_classes: input_classes.iter().map(|x| x.to_string()).collect(),
9494
input_string: input_string.to_owned(),
9595
exp_base_level: None,
@@ -172,8 +172,8 @@ fn test_character_conformance() {
172172
if levels != exp_levels {
173173
fails.push(
174174
Fail {
175-
line_num,
176-
input_base_level,
175+
line_num: line_num,
176+
input_base_level: input_base_level,
177177
input_classes: vec![],
178178
input_string: input_string.to_owned(),
179179
exp_base_level: Some(exp_base_level),
@@ -216,7 +216,7 @@ fn test_character_conformance() {
216216
// TODO: Support auto-RTL
217217
fn gen_base_levels_for_base_tests(bitset: u8) -> Vec<Option<Level>> {
218218
/// Values: auto-LTR, LTR, RTL
219-
const VALUES: &[Option<Level>] = &[None, Some(level::LTR_LEVEL), Some(level::RTL_LEVEL)];
219+
const VALUES: &'static [Option<Level>] = &[None, Some(level::LTR_LEVEL), Some(level::RTL_LEVEL)];
220220
assert!(bitset < (1 << VALUES.len()));
221221
(0..VALUES.len())
222222
.filter(|bit| bitset & (1u8 << bit) == 1)
@@ -227,7 +227,7 @@ fn gen_base_levels_for_base_tests(bitset: u8) -> Vec<Option<Level>> {
227227
// TODO: Support auto-RTL
228228
fn gen_base_level_for_characters_tests(idx: usize) -> Option<Level> {
229229
/// Values: LTR, RTL, auto-LTR
230-
const VALUES: &[Option<Level>] = &[Some(level::LTR_LEVEL), Some(level::RTL_LEVEL), None];
230+
const VALUES: &'static [Option<Level>] = &[Some(level::LTR_LEVEL), Some(level::RTL_LEVEL), None];
231231
assert!(idx < VALUES.len());
232232
VALUES[idx]
233233
}

0 commit comments

Comments
 (0)