fix(download-abi): update request parameter for listNamespacedConfigMap

- Changed the `_continue` parameter to `continue` in the request object for the `listNamespacedConfigMap` method to align with the updated KubernetesClient interface.
- Enhanced the test suite for the `download-abi` command to ensure proper handling of pagination tokens and verify that all pages are fetched correctly.

Author: roderik

src/cli/commands/download-abi/download-abi.command.test.ts

@@ -36,14 +36,12 @@ const createContext = (
 ): KubernetesClient => ({
   namespace: "test-ns",
   client: {
-    listNamespacedConfigMap: ({
-      _continue,
-    }: {
+    listNamespacedConfigMap: (request: {
       namespace: string;
       limit?: number;
-      _continue?: string;
+      continue?: string;
     }) => {
-      if (_continue) {
+      if (request.continue) {
         return Promise.resolve({ body: { items: [], metadata: {} } });
       }
       return Promise.resolve({
@@ -56,6 +54,40 @@ const createContext = (
   } as unknown as KubernetesClient["client"],
 });
 
+const createPaginatedContext = (
+  pages: readonly (readonly V1ConfigMap[])[],
+  tokens: readonly (string | undefined)[]
+): KubernetesClient => {
+  let callIndex = 0;
+  return {
+    namespace: "test-ns",
+    client: {
+      listNamespacedConfigMap: (request: {
+        namespace: string;
+        limit?: number;
+        continue?: string;
+      }) => {
+        const expectedToken = tokens[callIndex];
+        const providedToken = request.continue ?? undefined;
+        if (providedToken !== expectedToken) {
+          throw new Error(
+            `Unexpected continue token: expected ${expectedToken}, received ${providedToken}`
+          );
+        }
+        const items = pages[callIndex] ?? [];
+        const nextToken = tokens[callIndex + 1];
+        callIndex += 1;
+        return Promise.resolve({
+          body: {
+            items,
+            metadata: nextToken ? { continue: nextToken } : {},
+          },
+        });
+      },
+    } as unknown as KubernetesClient["client"],
+  };
+};
+
 describe("downloadAbi", () => {
   test("writes annotated configmaps to disk", async () => {
     const configMap: V1ConfigMap = {
@@ -103,4 +135,45 @@ describe("downloadAbi", () => {
     expect(entries).toHaveLength(0);
     expect(capturedOutput).toContain("No ABI ConfigMaps found");
   });
+
+  test("fetches all pages when the API provides a continue token", async () => {
+    const pageOne: V1ConfigMap = {
+      metadata: {
+        name: "abi-first",
+        annotations: {
+          [ARTIFACT_ANNOTATION_KEY]: ARTIFACT_VALUES.abi,
+        },
+      },
+      data: {
+        "First.json": "{}\n",
+      },
+    };
+    const pageTwo: V1ConfigMap = {
+      metadata: {
+        name: "abi-second",
+        annotations: {
+          [ARTIFACT_ANNOTATION_KEY]: ARTIFACT_VALUES.abi,
+        },
+      },
+      data: {
+        "Second.json": "{}\n",
+      },
+    };
+
+    await downloadAbi(
+      { outputDirectory: workingDirectory },
+      {
+        createContext: () =>
+          Promise.resolve(
+            createPaginatedContext(
+              [[pageOne], [pageTwo]],
+              [undefined, "page-2", undefined]
+            )
+          ),
+      }
+    );
+
+    const directories = await readdir(workingDirectory);
+    expect(directories.sort()).toEqual(["abi-first", "abi-second"]);
+  });
 });

src/cli/commands/download-abi/download-abi.command.ts

@@ -123,18 +123,28 @@ const writeConfigMap = async (
   return written;
 };
 
+const PAGE_SIZE = 100;
+
 const fetchAbiConfigMaps = async (
   context: KubernetesClient
 ): Promise<readonly V1ConfigMap[]> => {
   const abis: V1ConfigMap[] = [];
   let continueToken: string | undefined;
 
   do {
-    const response = await context.client.listNamespacedConfigMap({
+    const request: {
+      namespace: string;
+      limit: number;
+      continue?: string;
+    } = {
       namespace: context.namespace,
-      limit: 100,
-      _continue: continueToken,
-    });
+      limit: PAGE_SIZE,
+    };
+    if (continueToken) {
+      request.continue = continueToken;
+    }
+
+    const response = await context.client.listNamespacedConfigMap(request);
     const items = toConfigMapList(response);
     for (const item of items) {
       const annotation = item.metadata?.annotations?.[ARTIFACT_ANNOTATION_KEY];