Improve CI (#334)

* Fix rubocop violations

Fixed all violations using `rubocop -a`

* Add Ruby3.4 to CI matrix

* Fix issue in sidekiq_user method

The following test started failing after the commit Harmonize interface with 68d734f

```
  1) Error:
SidekiqCommonTest#test_sidekiq_user_with_role:
KeyError: key not found: :sidekiq_user
    lib/capistrano/sidekiq.rb:56:in 'Hash#fetch'
    lib/capistrano/sidekiq.rb:56:in 'Capistrano::SidekiqCommon#sidekiq_user'
    test/unit_test.rb:58:in 'SidekiqCommonTest#test_sidekiq_user_with_role'
```

This occurred because the implementation did not account for the case where sidekiq_user or run_as is missing in role.properties. I judged the implementation to be incorrect and fixed the code accordingly.

Author: willnet

.github/workflows/test.yml

@@ -11,8 +11,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['3.2', '3.3']
-    
+        ruby-version: ['3.2', '3.3', '3.4']
+
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -22,10 +22,10 @@ jobs:
         with:
           ruby-version: ${{ matrix.ruby-version }}
           bundler-cache: true
-          
+
       - name: Run RuboCop
         run: bundle exec rubocop
-        
+
       - name: Run Tests
         run: bundle exec rake test
 

lib/capistrano/sidekiq.rb

@@ -9,17 +9,17 @@ def compiled_template_sidekiq(from, role, config_file = 'sidekiq.yml')
       @role = role
       @config_file = config_file
       file = [
-          "lib/capistrano/templates/#{from}-#{role.hostname}-#{fetch(:stage)}.rb",
-          "lib/capistrano/templates/#{from}-#{role.hostname}.rb",
-          "lib/capistrano/templates/#{from}-#{fetch(:stage)}.rb",
-          "lib/capistrano/templates/#{from}.rb.erb",
-          "lib/capistrano/templates/#{from}.rb",
-          "lib/capistrano/templates/#{from}.erb",
-          "config/deploy/templates/#{from}.rb.erb",
-          "config/deploy/templates/#{from}.rb",
-          "config/deploy/templates/#{from}.erb",
-          File.expand_path("../templates/#{from}.erb", __FILE__),
-          File.expand_path("../templates/#{from}.rb.erb", __FILE__)
+        "lib/capistrano/templates/#{from}-#{role.hostname}-#{fetch(:stage)}.rb",
+        "lib/capistrano/templates/#{from}-#{role.hostname}.rb",
+        "lib/capistrano/templates/#{from}-#{fetch(:stage)}.rb",
+        "lib/capistrano/templates/#{from}.rb.erb",
+        "lib/capistrano/templates/#{from}.rb",
+        "lib/capistrano/templates/#{from}.erb",
+        "config/deploy/templates/#{from}.rb.erb",
+        "config/deploy/templates/#{from}.rb",
+        "config/deploy/templates/#{from}.erb",
+        File.expand_path("../templates/#{from}.erb", __FILE__),
+        File.expand_path("../templates/#{from}.rb.erb", __FILE__)
       ].detect { |path| File.file?(path) }
       erb = File.read(file)
       StringIO.new(ERB.new(erb, trim_mode: '-').result(binding))
@@ -37,12 +37,12 @@ def sidekiq_config
       "--config config/#{@config_file}" if @config_file != 'sidekiq.yml'
     end
 
-    def sidekiq_switch_user(role, &block)
+    def sidekiq_switch_user(role, &)
       su_user = sidekiq_user(role)
       if su_user == role.user
         yield
       else
-        backend.as(su_user, &block)
+        backend.as(su_user, &)
       end
     end
 
@@ -52,10 +52,10 @@ def sidekiq_user(role = nil)
       else
         properties = role.properties
         return role.user unless properties
-        
-        properties.fetch(:sidekiq_user) || # local property for sidekiq only
+
+        properties.fetch(:sidekiq_user, nil) || # local property for sidekiq only
           fetch(:sidekiq_user, nil) ||
-          properties.fetch(:run_as) || # global property across multiple capistrano gems
+          properties.fetch(:run_as, nil) || # global property across multiple capistrano gems
           role.user
       end
     end

lib/capistrano/sidekiq/systemd.rb

@@ -4,6 +4,7 @@ module Capistrano
   class Sidekiq
     class Systemd < Capistrano::Plugin
       include SidekiqCommon
+
       def define_tasks
         eval_rakefile File.expand_path('../tasks/systemd.rake', __dir__)
         eval_rakefile File.expand_path('../tasks/helpers.rake', __dir__)