refactor: remove obsolete dimension helpers

Author: iscarson

src/mcp/server.ts

@@ -2861,102 +2861,6 @@ function timeColumnSignal(
   };
 }
 
-function detectDimensionColumnCandidates(
-  rows: unknown[],
-  config: ObConfig,
-  schema: string | undefined,
-  table: string,
-  maxColumns: number
-) {
-  return rows
-    .map((row, index) => {
-      const metadata = profileColumnMetadata(row, config.compatibility);
-      if (!metadata) {
-        return undefined;
-      }
-      const signal = dimensionColumnSignal(metadata.name, metadata.dataType, metadata.comment);
-      if (signal.confidence < 0.35) {
-        return undefined;
-      }
-      return {
-        column: metadata.name,
-        kind: signal.kind,
-        confidence: signal.confidence,
-        evidence: signal.evidence,
-        dataType: metadata.dataType,
-        typeCategory: profileColumnTypeCategory(metadata.dataType),
-        nullable: metadata.nullable,
-        comment: metadata.comment,
-        masked: shouldMaskColumnValue(metadata.name, config, schema, table),
-        ordinalPosition: numberRecordValue(row as Record<string, unknown>, "ordinal_position", "ORDINAL_POSITION", "column_id", "COLUMN_ID") ?? index + 1
-      };
-    })
-    .filter((item): item is NonNullable<typeof item> => Boolean(item))
-    .sort((left, right) => right.confidence - left.confidence || left.ordinalPosition - right.ordinalPosition)
-    .slice(0, Math.max(1, Math.min(maxColumns, 50)));
-}
-
-function dimensionColumnSignal(
-  columnName: string,
-  dataType: string | undefined,
-  comment: string | undefined
-): { kind: string; confidence: number; evidence: string[] } {
-  const normalized = columnName.trim().toLowerCase();
-  const commentText = (comment ?? "").trim().toLowerCase();
-  const typeCategory = profileColumnTypeCategory(dataType);
-  const evidence: string[] = [];
-  let confidence = 0;
-  let kind = "generic_dimension";
-
-  const namedKind = dimensionKindFromName(normalized);
-  if (namedKind) {
-    kind = namedKind;
-    confidence += 0.55;
-    evidence.push(`Column name matches common ${namedKind.replace(/_/g, " ")} naming.`);
-  }
-  if (["enum", "boolean"].includes(typeCategory)) {
-    confidence += 0.3;
-    evidence.push(`Type category is ${typeCategory}.`);
-  } else if (typeCategory === "string" && /(char|varchar|text|string)/i.test(dataType ?? "")) {
-    confidence += 0.15;
-    evidence.push("String type can represent a categorical value.");
-  } else if (typeCategory === "numeric" && /(tinyint|smallint|number\(1|int\(1)/i.test(dataType ?? "")) {
-    confidence += 0.15;
-    evidence.push("Small numeric type can represent a code or flag.");
-  }
-  if (/(status|state|type|category|channel|region|city|province|country|source|platform|flag|level|kind|gender)/.test(commentText)) {
-    confidence += 0.15;
-    evidence.push("Column comment contains dimension-related wording.");
-  }
-  return {
-    kind,
-    confidence: Math.min(0.98, Number(confidence.toFixed(2))),
-    evidence
-  };
-}
-
-function dimensionKindFromName(name: string): string | undefined {
-  if (/(^|_)(status|state)(_|$)/.test(name)) {
-    return "status";
-  }
-  if (/(^|_)(type|category|kind|level)(_|$)/.test(name)) {
-    return "type";
-  }
-  if (/(^|_)(channel|source|platform|scene)(_|$)/.test(name)) {
-    return "channel";
-  }
-  if (/(^|_)(region|city|province|country|area)(_|$)/.test(name)) {
-    return "region";
-  }
-  if (/(^|_)(flag|enabled|disabled|deleted|active|valid)(_|$)/.test(name)) {
-    return "flag";
-  }
-  if (/(^|_)(gender|grade|segment|bucket|group)(_|$)/.test(name)) {
-    return "category";
-  }
-  return undefined;
-}
-
 function resolveRecentRowsTimeColumn(
   rows: unknown[],
   config: ObConfig,