Warn about scanning link-local or multicast IPs

Author: sfan5

.github/workflows/build.yml

@@ -30,18 +30,17 @@ jobs:
         env:
           CC: gcc
 
-      - name: Test
+      - name: Tests
         run: |
           ./util/ci-test.sh
+          ./util/ci-test4.sh
 
-      - name: Test 2
+      - name: Tests 2
         run: |
           sudo ./util/ci-test2.sh
-
-      - name: Test 3
-        run: |
           sudo ./util/ci-test3.sh
 
+
   clang:
     name: "clang (sanitize: ${{ matrix.c.san }})"
     strategy:
@@ -65,14 +64,12 @@ jobs:
         env:
           CC: clang
 
-      - name: Test
+      - name: Tests
         run: |
           ./util/ci-test.sh
+          ./util/ci-test4.sh
 
-      - name: Test 2
+      - name: Tests 2
         run: |
           sudo ./util/ci-test2.sh
-
-      - name: Test 3
-        run: |
           sudo ./util/ci-test3.sh

src/main.c

@@ -78,7 +78,7 @@ int main(int argc, char *argv[])
 	outfile = stdout;
 	outdef = NULL;
 
-	srand(time(NULL) ^ getpid());
+	srand(time(NULL) - (getpid() * argc) + monotonic_ms());
 	memset(source_mac, 0xff, 6);
 	memset(router_mac, 0xff, 6);
 	memset(source_addr, 0xff, 16);

src/target-gen.c

@@ -299,6 +299,7 @@ void target_gen_print_summary(int max_rate, int nports)
 
 int target_gen_sanity_check(void)
 {
+	/* Target size check */
 	uint64_t total = 0;
 	bool overflowed = false;
 	for(int i = 0; i < targets_i; i++) {
@@ -328,6 +329,27 @@ int target_gen_sanity_check(void)
 		);
 		return -1;
 	}
+
+	/* Target address check */
+	bool have_ll = false, have_mc = false;
+	for(int i = 0; i < targets_i; i++) {
+		const struct targetspec *s = &targets[i].spec;
+		if(s->mask[0] == 0xff && s->mask[1] == 0xff) {
+			have_ll |= s->addr[0] == 0xfe && s->addr[1] >= 0x80 && s->addr[1] <= 0xbf;
+		}
+		if(s->mask[0] == 0xff) {
+			have_mc |= s->addr[0] == 0xff;
+		}
+	}
+	if(have_ll) {
+		log_warning("Some of your targets are link-local IPv6 addresses. "
+			"Scanning them will not work.");
+	}
+	if(have_mc) {
+		log_warning("Some of your targets are multicast IPv6 addresses. "
+			"Scanning them will not work.");
+	}
+
 	return 0;
 }
 

util/ci-test2.sh

@@ -1,5 +1,4 @@
 #!/bin/bash -e
-##
 args=(
 	--interface   lo
 	--router-mac  01:01:01:01:01:01
@@ -8,23 +7,8 @@ args=(
 
 ./fi6s "${args[@]}" --icmp ::1 | tee out.txt
 if ! grep -q "^icmp up 0 ::1 " out.txt; then
-	echo "1: FAILED!"
+	echo "FAILED!"
 	exit 1
 fi
-echo "1: Passed."
-
-##
-
-printf '%s\n' >in.txt \
-	2001::/112 2002::/112 2003::/114 2004::1 2004::2 2004::3
-
-./fi6s --max-rate 123 --print-summary @in.txt | tee out.txt
-if ! grep -q "covering 147459 address" out.txt; then
-	echo "2: FAILED!"
-	exit 1
-fi
-echo "2: Passed."
-
-##
-
+echo "Passed."
 exit 0

util/ci-test4.sh

@@ -0,0 +1,57 @@
+#!/bin/bash -e
+
+ntest=0
+try () {
+	((ntest+=1))
+	echo
+	echo "-> fi6s $*"
+	./fi6s "$@" 2>&1 | tee out.txt
+}
+
+check_out () {
+	if ! grep -iq "$1" out.txt; then
+		echo "#$ntest: FAILED!"
+		exit 1
+	fi
+	echo "#$ntest: Passed"
+}
+
+##
+
+printf '%s\n' >in.txt \
+	2001::/112 2002::/112 2003::/114 2004::1 2004::2 2004::3
+
+try --max-rate 123 --print-summary @in.txt
+check_out "covering 147459 addr"
+
+##
+
+printf '%s\n' >in.txt \
+	cafe::xxx:xxxx:xxxx:xxxx babe::/69
+
+try --print-summary @in.txt
+check_out "covering 1729382256910270464 addr"
+check_out "largest.*/68\b"
+check_out "smallest.*/69\b"
+
+##
+
+try --print-summary c0ff:ee::1/48-64
+check_out "covering 65536 addr"
+
+##
+
+try --icmp 3ffe::/48
+check_out "tremendous amount of time"
+
+##
+
+try --icmp fe80::ffff
+check_out "Warning:.*are link-local "
+
+##
+
+try --icmp ff02::2
+check_out "Warning:.*are multicast "
+
+exit 0