Skip to content

Commit 2298a73

Browse files
sfirkesfirke
committed
prep for submission to CRAN
1 parent 3cd8748 commit 2298a73

File tree

3 files changed

+143
-52
lines changed

3 files changed

+143
-52
lines changed

‎cran-comments.md‎

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,28 @@
11
# Submission
2-
2018-03-21
2+
2018-07-17
33

44
## Submission summary
5-
An overhaul of core package functions, including breaking changes. Brings the package to a stable long-term state, as reflected by the 1.0.0 version number.
5+
Per CRAN request (Kurt Hornik on July 3rd 2018), I am submitting a patched version that addresses two dependency-based warnings currently being thrown under R-devel. There are a few minor changes to the package functionality as well.
66

77
### Test environments
88

99
#### Windows
10-
* local Windows 10 install, R 3.4.3
11-
* local Windows 10 install, R 3.4.4
12-
* win-builder with R-devel 2018-03-20 r74431
10+
* win-builder with R Under development (unstable) (2018-07-15 r74966)
1311

1412
#### Linux
15-
* ubuntu 16.04.3, R-release 3.4.3 (local)
16-
* ubuntu 16.04.3, R-release 3.4.4 (local)
17-
* ubuntu 14.04.5, R-oldrel 3.3.3 (Travis CI)
18-
* ubuntu 14.04.5 R-release 3.4.4 (Travis CI)
19-
* ubuntu 14.04.5 R-devel R 3.5.0 74418 (Travis CI)
13+
* ubuntu 16.04.3, R-oldrel 3.4.4 (local)
14+
* ubuntu 14.04.5, R-oldrel 3.4.4 (Travis CI)
15+
* ubuntu 14.04.5 R-release 3.5.0 (Travis CI)
16+
* ubuntu 14.04.5 R-devel R Under development (unstable) (2018-06-20 r74923) (Travis CI)
2017

2118
#### Mac
22-
* OS X Sierra 10.12.6, R-oldrel 3.3.3 (Travis CI)
23-
* OS X Sierra 10.12.6, R-release 3.4.4 (Travis CI)
19+
* OS X Sierra 10.12.6, R-oldrel 3.4.4 (Travis CI)
20+
* OS X Sierra 10.12.6, R-release 3.5.0 (Travis CI)
2421

2522
### R CMD check results
2623
0 errors | 0 warnings | 0 notes
2724

2825
### Downstream dependencies
29-
The janitor v1.0 update involves breaking changes that affect some downstream packages. I advised all downstream package maintainers of these changes on February 21, including providing example code that would keep their packages compatible with all versions of janitor. All downstream packages have since been updated to address the janitor 1.0.0 changes.
26+
The only breaking change in this release that could affect another package is quite obscure and does not affect the downstream dependencies.
3027

31-
I checked 4 reverse dependencies from CRAN.
32-
33-
#### New problems
34-
These CRAN packages depending on janitor each have 1 warning:
35-
36-
* ballr, bomrang: failures due to change in janitor::clean_names. I emailed the maintainers notice of failing R CMD check on Mar 17. Maintainers of both packages have since confirmed to me that they've updated their packages accordingly. Both packages have been submitted to CRAN or will be shortly following janitor 1.0.0's acceptance.
37-
* fivethirtyeight: my check yielded a warning `checking for unstated dependencies in example ... WARNING warning in parse(file = files, n = -1L) : invalid input found on input connection 'fivethirtyeight-Ex.R'.` I discussed this warning with the maintainer; he tested janitor 1.0.0 with his package and confirmed that any WARNING or NOTE is not the result of changes to janitor.
28+
I checked 5 reverse dependencies from CRAN: ballr, bomrang, driftR, fivethirtyeight, moderndive. I get some unrelated warnings and notes but nothing having to do with the janitor package or this update.

‎revdep/README.md‎

Lines changed: 25 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -2,61 +2,54 @@
22

33
|field |value |
44
|:--------|:----------------------------|
5-
|version |R version 3.4.3 (2017-11-30) |
5+
|version |R version 3.4.4 (2018-03-15) |
66
|os |Ubuntu 16.04.3 LTS |
77
|system |x86_64, linux-gnu |
88
|ui |RStudio |
99
|language |en_US |
1010
|collate |en_US.UTF-8 |
11-
|tz |posixrules |
12-
|date |2018-03-17 |
11+
|tz |America/New_York |
12+
|date |2018-07-17 |
1313

1414
# Dependencies
1515

1616
|package |old |new |Δ |
1717
|:----------|:--------|:--------|:--|
18-
|janitor |0.3.1 |1.0.0 |* |
18+
|janitor |1.0.0 |1.1 |* |
1919
|assertthat |0.2.0 |0.2.0 | |
2020
|BH |1.66.0-1 |1.66.0-1 | |
2121
|bindr |0.1.1 |0.1.1 | |
22-
|bindrcpp |0.2 |0.2 | |
22+
|bindrcpp |0.2.2 |0.2.2 | |
2323
|cli |1.0.0 |1.0.0 | |
2424
|crayon |1.3.4 |1.3.4 | |
25-
|dplyr |0.7.4 |0.7.4 | |
25+
|dplyr |0.7.6 |0.7.6 | |
26+
|fansi |0.2.3 |0.2.3 | |
2627
|glue |1.2.0 |1.2.0 | |
2728
|magrittr |1.5 |1.5 | |
28-
|pillar |1.2.1 |1.2.1 | |
29+
|pillar |1.3.0 |1.3.0 | |
2930
|pkgconfig |2.0.1 |2.0.1 | |
30-
|plogr |0.1-1 |0.1-1 | |
31-
|purrr |0.2.4 |0.2.4 | |
31+
|plogr |0.2.0 |0.2.0 | |
32+
|purrr |0.2.5 |0.2.5 | |
3233
|R6 |2.2.2 |2.2.2 | |
33-
|Rcpp |0.12.16 |0.12.16 | |
34-
|rlang |0.2.0 |0.2.0 | |
35-
|snakecase |NA |0.9.0 |* |
36-
|stringi |1.1.7 |1.1.7 | |
37-
|stringr |NA |1.3.0 |* |
34+
|Rcpp |0.12.17 |0.12.17 | |
35+
|rlang |0.2.1 |0.2.1 | |
36+
|snakecase |0.9.1 |0.9.1 | |
37+
|stringi |1.2.3 |1.2.3 | |
38+
|stringr |1.3.1 |1.3.1 | |
3839
|tibble |1.4.2 |1.4.2 | |
39-
|tidyr |0.8.0 |0.8.0 | |
40+
|tidyr |0.8.1 |0.8.1 | |
4041
|tidyselect |0.2.4 |0.2.4 | |
41-
|utf8 |1.1.3 |1.1.3 | |
42+
|utf8 |1.1.4 |1.1.4 | |
4243

4344
# Revdeps
4445

45-
## Couldn't check (4)
46+
## All (5)
4647

47-
|package |version |error |warning |note |
48-
|:---------------|:-------|:-----|:-------|:----|
49-
|ballr |? | | | |
50-
|bomrang |? | | | |
51-
|fivethirtyeight |? | | | |
52-
|moderndive |? | | | |
53-
54-
## All (4)
55-
56-
|package |version |error |warning |note |
57-
|:---------------|:-------|:-----|:-------|:----|
58-
|ballr |? | | | |
59-
|bomrang |? | | | |
60-
|fivethirtyeight |? | | | |
61-
|moderndive |? | | | |
48+
|package |version |error |warning |note |
49+
|:----------------------------------------------|:-------|:-----|:-------|:----|
50+
|[ballr](problems.md#ballr) |0.2.1 |1 |1 | |
51+
|[bomrang](problems.md#bomrang) |0.2.1 |1 | | |
52+
|[driftR](problems.md#driftr) |1.1.0 |1 |1 | |
53+
|[fivethirtyeight](problems.md#fivethirtyeight) |0.4.0 |1 |1 |3 |
54+
|[moderndive](problems.md#moderndive) |0.2.0 |1 |1 | |
6255

‎revdep/problems.md‎

Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
# ballr
2+
3+
Version: 0.2.1
4+
5+
## In both
6+
7+
* checking PDF version of manual without hyperrefs or index ... ERROR
8+
```
9+
Re-running with no redirection of stdout/stderr.
10+
Hmm ... looks like a package
11+
You may want to clean up by 'rm -rf /tmp/Rtmp7Fl3iL/Rd2pdf7d8e560b6b41'
12+
```
13+
14+
* checking PDF version of manual ... WARNING
15+
```
16+
LaTeX errors when creating PDF version.
17+
This typically indicates Rd problems.
18+
```
19+
20+
# bomrang
21+
22+
Version: 0.2.1
23+
24+
## In both
25+
26+
* checking package dependencies ... ERROR
27+
```
28+
Package required but not available: ‘rgdal’
29+
30+
See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’
31+
manual.
32+
```
33+
34+
# driftR
35+
36+
Version: 1.1.0
37+
38+
## In both
39+
40+
* checking PDF version of manual without hyperrefs or index ... ERROR
41+
```
42+
Re-running with no redirection of stdout/stderr.
43+
Hmm ... looks like a package
44+
You may want to clean up by 'rm -rf /tmp/RtmpDl2GqW/Rd2pdf174f4745dddc'
45+
```
46+
47+
* checking PDF version of manual ... WARNING
48+
```
49+
LaTeX errors when creating PDF version.
50+
This typically indicates Rd problems.
51+
```
52+
53+
# fivethirtyeight
54+
55+
Version: 0.4.0
56+
57+
## In both
58+
59+
* checking PDF version of manual without hyperrefs or index ... ERROR
60+
```
61+
Re-running with no redirection of stdout/stderr.
62+
Hmm ... looks like a package
63+
You may want to clean up by 'rm -rf /tmp/RtmpA7JSN5/Rd2pdf3c0733592067'
64+
```
65+
66+
* checking PDF version of manual ... WARNING
67+
```
68+
LaTeX errors when creating PDF version.
69+
This typically indicates Rd problems.
70+
```
71+
72+
* checking package dependencies ... NOTE
73+
```
74+
Package suggested but not available for checking: ‘fivethirtyeight’
75+
```
76+
77+
* checking installed package size ... NOTE
78+
```
79+
installed size is 6.6Mb
80+
sub-directories of 1Mb or more:
81+
data 5.4Mb
82+
```
83+
84+
* checking data for non-ASCII characters ... NOTE
85+
```
86+
Note: found 1616 marked UTF-8 strings
87+
```
88+
89+
# moderndive
90+
91+
Version: 0.2.0
92+
93+
## In both
94+
95+
* checking PDF version of manual without hyperrefs or index ... ERROR
96+
```
97+
Re-running with no redirection of stdout/stderr.
98+
Hmm ... looks like a package
99+
You may want to clean up by 'rm -rf /tmp/Rtmpw8bhRh/Rd2pdf48086135c2d3'
100+
```
101+
102+
* checking PDF version of manual ... WARNING
103+
```
104+
LaTeX errors when creating PDF version.
105+
This typically indicates Rd problems.
106+
```
107+

0 commit comments

Comments
 (0)