You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: cran-comments.md
+6-3Lines changed: 6 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,12 +1,15 @@
1
1
# Submission
2
2
2018-03-21
3
3
4
+
## Submission summary
5
+
An overhaul of core package functions, including breaking changes. Brings the package to a stable long-term state, as reflected by the 1.0.0 version number.
6
+
4
7
### Test environments
5
8
6
9
#### Windows
7
10
* local Windows 10 install, R 3.4.3
8
11
* local Windows 10 install, R 3.4.4
9
-
* win-builder with R-devel 2018-03-16 74418
12
+
* win-builder with R-devel 2018-03-20 r74431
10
13
11
14
#### Linux
12
15
* ubuntu 16.04.3, R-release 3.4.3 (local)
@@ -23,12 +26,12 @@
23
26
0 errors | 0 warnings | 0 notes
24
27
25
28
### Downstream dependencies
26
-
The janitor v1.0 update involves breaking changes that affect some downstream packages. I advised all downstream package maintainers of these changes on February 21, including providing example code that would keep their packages compatible with all versions of janitor.
29
+
The janitor v1.0 update involves breaking changes that affect some downstream packages. I advised all downstream package maintainers of these changes on February 21, including providing example code that would keep their packages compatible with all versions of janitor. All downstream packages have since been updated to address the janitor 1.0.0 changes.
27
30
28
31
I checked 4 reverse dependencies from CRAN.
29
32
30
33
#### New problems
31
34
These CRAN packages depending on janitor each have 1 warning:
32
35
33
-
* ballr, bomrang: failures due to change in janitor::clean_names. I proposed a fix to package maintainers on Feb 21 and emailed them notice of failing R CMD check on Mar 17. Maintainers of both packages have since confirmed to me that they've updated their packages accordingly. Both packages have been submitted to CRAN or will be shortly following janitor 1.0.0's acceptance.
36
+
* ballr, bomrang: failures due to change in janitor::clean_names. I emailed the maintainers notice of failing R CMD check on Mar 17. Maintainers of both packages have since confirmed to me that they've updated their packages accordingly. Both packages have been submitted to CRAN or will be shortly following janitor 1.0.0's acceptance.
34
37
* fivethirtyeight: my check yielded a warning `checking for unstated dependencies in example ... WARNING warning in parse(file = files, n = -1L) : invalid input found on input connection 'fivethirtyeight-Ex.R'.` I discussed this warning with the maintainer; he tested janitor 1.0.0 with his package and confirmed that any WARNING or NOTE is not the result of changes to janitor.
0 commit comments