Skip to content

Commit e13da58

Browse files
committed
note latest win_build results
1 parent 95d45ba commit e13da58

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

cran-comments.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
# Submission
22
2018-03-21
33

4+
## Submission summary
5+
An overhaul of core package functions, including breaking changes. Brings the package to a stable long-term state, as reflected by the 1.0.0 version number.
6+
47
### Test environments
58

69
#### Windows
710
* local Windows 10 install, R 3.4.3
811
* local Windows 10 install, R 3.4.4
9-
* win-builder with R-devel 2018-03-16 74418
12+
* win-builder with R-devel 2018-03-20 r74431
1013

1114
#### Linux
1215
* ubuntu 16.04.3, R-release 3.4.3 (local)
@@ -23,12 +26,12 @@
2326
0 errors | 0 warnings | 0 notes
2427

2528
### Downstream dependencies
26-
The janitor v1.0 update involves breaking changes that affect some downstream packages. I advised all downstream package maintainers of these changes on February 21, including providing example code that would keep their packages compatible with all versions of janitor.
29+
The janitor v1.0 update involves breaking changes that affect some downstream packages. I advised all downstream package maintainers of these changes on February 21, including providing example code that would keep their packages compatible with all versions of janitor. All downstream packages have since been updated to address the janitor 1.0.0 changes.
2730

2831
I checked 4 reverse dependencies from CRAN.
2932

3033
#### New problems
3134
These CRAN packages depending on janitor each have 1 warning:
3235

33-
* ballr, bomrang: failures due to change in janitor::clean_names. I proposed a fix to package maintainers on Feb 21 and emailed them notice of failing R CMD check on Mar 17. Maintainers of both packages have since confirmed to me that they've updated their packages accordingly. Both packages have been submitted to CRAN or will be shortly following janitor 1.0.0's acceptance.
36+
* ballr, bomrang: failures due to change in janitor::clean_names. I emailed the maintainers notice of failing R CMD check on Mar 17. Maintainers of both packages have since confirmed to me that they've updated their packages accordingly. Both packages have been submitted to CRAN or will be shortly following janitor 1.0.0's acceptance.
3437
* fivethirtyeight: my check yielded a warning `checking for unstated dependencies in example ... WARNING warning in parse(file = files, n = -1L) : invalid input found on input connection 'fivethirtyeight-Ex.R'.` I discussed this warning with the maintainer; he tested janitor 1.0.0 with his package and confirmed that any WARNING or NOTE is not the result of changes to janitor.

0 commit comments

Comments
 (0)