Skip to content

delayline() is called twice for every impulse response in ir_wfs() #116

Open
@hagenw

Description

@hagenw

This is a follow up on #115.

There @VeraE wrote that delayline() gets called several times:

  1. when calculating the driving function,
  2. in ir_correct_distance()

One way to improve this might be to let ir_correct_distance() return delay and weight instead of the actual shifted impulse response. The downside is that this would complicate how get_ir() works as this would then need to return the unmodified impulse response and the delay and weight. I guess in this case it would even be better to remove ir_correct_distance() from get_ir() and apply it somewhere else.

Maybe we find a good solution for this, but in my opinion it would be also ok, to stay with the current state.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions