Open
Description
This is a follow up on #115.
There @VeraE wrote that delayline()
gets called several times:
- when calculating the driving function,
- in
ir_correct_distance()
One way to improve this might be to let ir_correct_distance()
return delay and weight instead of the actual shifted impulse response. The downside is that this would complicate how get_ir()
works as this would then need to return the unmodified impulse response and the delay and weight. I guess in this case it would even be better to remove ir_correct_distance()
from get_ir()
and apply it somewhere else.
Maybe we find a good solution for this, but in my opinion it would be also ok, to stay with the current state.