Merge pull request #375 from sgbett/feat/368-broadcast-rollback

feat(wallet): broadcast/rollback semantics for create_action (F8.13)

Author: sgbett

.rubocop.yml

@@ -61,6 +61,7 @@ Naming/PredicateMethod:
     - is_authenticated
     - delete_output
     - delete_certificate
+    - delete_action
 
 # is_authenticated uses the BRC-100 wire-protocol naming convention (is_ prefix).
 Naming/PredicatePrefix:

gem/bsv-sdk/lib/bsv/network/arc.rb

@@ -195,7 +195,8 @@ def handle_broadcast_response(response)
           raise BroadcastError.new(
             body['detail'] || body['title'] || body['txStatus'],
             status_code: code,
-            txid: body['txid']
+            txid: body['txid'],
+            arc_status: body['txStatus'].to_s.upcase
           )
         end
 
@@ -277,7 +278,8 @@ def build_response_or_error(body)
           BroadcastError.new(
             body['detail'] || body['title'] || body['txStatus'],
             status_code: 200,
-            txid: body['txid']
+            txid: body['txid'],
+            arc_status: body['txStatus'].to_s.upcase
           )
         elsif !body['txid']
           BroadcastError.new(

gem/bsv-sdk/lib/bsv/network/broadcast_error.rb

@@ -3,11 +3,12 @@
 module BSV
   module Network
     class BroadcastError < StandardError
-      attr_reader :status_code, :txid
+      attr_reader :status_code, :txid, :arc_status
 
-      def initialize(message, status_code: nil, txid: nil)
+      def initialize(message, status_code: nil, txid: nil, arc_status: nil)
         @status_code = status_code
         @txid = txid
+        @arc_status = arc_status
         super(message)
       end
     end

gem/bsv-wallet-postgres/lib/bsv/wallet_postgres/postgres_store.rb

@@ -102,6 +102,23 @@ def count_actions(query)
         filter_actions(@db[:wallet_actions], query).count
       end
 
+      def update_action_status(txid, new_status)
+        ds = @db[:wallet_actions].where(txid: txid)
+        raise WalletError, "Action not found: #{txid}" if ds.empty?
+
+        ds.update(
+          data: Sequel.lit(
+            "data || jsonb_build_object('status', ?)",
+            new_status
+          )
+        )
+        symbolise_keys(ds.first[:data])
+      end
+
+      def delete_action(txid)
+        @db[:wallet_actions].where(txid: txid).delete.positive?
+      end
+
       # --- Outputs ---
 
       def store_output(output_data)

gem/bsv-wallet/lib/bsv/wallet_interface/file_store.rb

@@ -48,6 +48,18 @@ def store_action(action_data)
         result
       end
 
+      def update_action_status(txid, new_status)
+        result = super
+        save_actions
+        result
+      end
+
+      def delete_action(txid)
+        result = super
+        save_actions if result
+        result
+      end
+
       def store_output(output_data)
         result = super
         save_outputs

gem/bsv-wallet/lib/bsv/wallet_interface/memory_store.rb

@@ -30,6 +30,22 @@ def store_action(action_data)
         action_data
       end
 
+      def update_action_status(txid, new_status)
+        action = @actions.find { |a| a[:txid] == txid }
+        raise WalletError, "Action not found: #{txid}" unless action
+
+        action[:status] = new_status
+        action
+      end
+
+      def delete_action(txid)
+        idx = @actions.index { |a| a[:txid] == txid }
+        return false unless idx
+
+        @actions.delete_at(idx)
+        true
+      end
+
       def find_actions(query)
         apply_pagination(filter_actions(query), query)
       end

gem/bsv-wallet/lib/bsv/wallet_interface/storage_adapter.rb

@@ -67,6 +67,26 @@ def find_transaction(_txid)
         raise NotImplementedError, "#{self.class}#find_transaction not implemented"
       end
 
+      # Updates the status field of a stored action identified by txid.
+      #
+      # @param _txid [String] the transaction identifier of the action to update
+      # @param _new_status [String] the new status value (e.g. 'failed', 'completed')
+      # @return [Hash] the updated action hash
+      # @raise [BSV::Wallet::WalletError] if no action with the given txid is found
+      # @raise [NotImplementedError]
+      def update_action_status(_txid, _new_status)
+        raise NotImplementedError, "#{self.class}#update_action_status not implemented"
+      end
+
+      # Removes a stored action by txid.
+      #
+      # @param _txid [String] the transaction identifier of the action to remove
+      # @return [Boolean] true if the action was deleted, false if not found
+      # @raise [NotImplementedError]
+      def delete_action(_txid)
+        raise NotImplementedError, "#{self.class}#delete_action not implemented"
+      end
+
       # Transitions the state of an existing output.
       #
       # When +new_state+ is +:pending+, pass a +pending_reference:+ string to