Skip to content
This repository was archived by the owner on Jun 8, 2020. It is now read-only.
This repository was archived by the owner on Jun 8, 2020. It is now read-only.

List your candidates for inclusion in sgug-rse main 0.0.5 #3

@danielhams

Description

@danielhams

A place to track what we'd like to see moved from here (sgug-rse-wip) into main (sgug-rse) for the 0.0.5 release.

I'd personally like that sgug-rse isn't quite the free-for-all that sgug-rse-wip can be, so I propose the following criteria to be candidate for merging:

  • Package must not depend on something in sgug-rse-wip (unless that's getting merged too)
  • Package should have package.spec.origfedora if available too
  • Package should compile and install without any use of --force or --nodeps
  • Package spec must not contain AutoReqProv: 0 or disable dependency computations/constraints
  • Package changelog should be updated
  • Binaries (program/library) should have appropriate RPATH (see existing with objdump -p THING |grep RPATH)
  • Package should in almost all cases only touch files under /usr/sgug - check the files list of the RPMs and any pre/post sections of the spec
  • Evidence of testing (make check or some tool that uses it) - justifications about failures not being blockers are fine too
  • Where possible, package naming should match fedora style package naming
  • Patches associated with packages should try and use packagename.sgifixdescription.patch for hygiene reasons
  • Patches referenced in a spec should start at Patch100 (or later)
  • If possible, package is checked to see if "optimised linker flags" can be used
  • Do a review, see/check if the Requires, BuildRequires make sense / are up to date

These aren't hard and fast rules, but getting this stuff checked on this side of the fence will make for a simpler life during the long drawn out process of world building.

Ty

Edit: updated with Unxys suggestions

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions