[Fix] Thinker Input Length Check with Parameter Passing (#330)

Co-authored-by: zhaochenyang20 <zhaochen20@outlook.com>

Author: Jayon02

.github/actions/omni-post-stage/action.yaml

@@ -0,0 +1,120 @@
+name: Omni Post-Stage
+description: >
+  Shared teardown for Omni CI stages. Prints matching result JSON files to
+  the log (optionally summary-only), uploads them as workflow artifacts,
+  and always reclaims the GPU by killing leftover processes.
+
+inputs:
+  stage-label:
+    description: Human-readable label used in the log banner (e.g. "MMMU", "TTS").
+    required: true
+  artifact-search-root:
+    description: >
+      Directory that `find` descends into when resolving `artifact-path-globs`.
+      Qwen3-Omni tests write to `/tmp` via pytest `tmp_path`; S2-Pro tests
+      write under `stage-results/<name>/` inside `$GITHUB_WORKSPACE`. Set
+      accordingly.
+    required: false
+    default: "/tmp"
+  artifact-path-globs:
+    description: >
+      Newline-separated `find -path` globs (matched against the full path
+      starting from `artifact-search-root`). Leave empty to skip artifact
+      printing.
+    required: false
+    default: ""
+  artifact-upload-name:
+    description: >
+      If set, uploads files matching `artifact-upload-path` as a workflow
+      artifact under this name. Must be unique across the workflow run.
+    required: false
+    default: ""
+  artifact-upload-path:
+    description: >
+      Path or glob that `actions/upload-artifact` uploads when
+      `artifact-upload-name` is set. Required whenever `artifact-upload-name`
+      is provided — there is deliberately no default, since the right scope
+      (pytest `tmp_path` tree vs. workspace subdir) is stage-specific.
+    required: false
+    default: ""
+  artifact-if-no-files-found:
+    description: >
+      Behavior when the upload path matches nothing. Use "error" for stages
+      whose artifacts are required by downstream jobs; "ignore" otherwise.
+    required: false
+    default: "ignore"
+  summary-only:
+    description: >
+      When "true", strips the `per_sample` field before printing large result
+      files to the log. The uploaded artifact still contains the full data.
+    required: false
+    default: "false"
+
+runs:
+  using: composite
+  steps:
+    - name: Collect matching result files
+      id: collect
+      if: ${{ inputs.artifact-path-globs != '' }}
+      shell: bash
+      env:
+        ARTIFACT_SEARCH_ROOT: ${{ inputs.artifact-search-root }}
+        ARTIFACT_PATH_GLOBS: ${{ inputs.artifact-path-globs }}
+      run: |
+        matches_file="$(mktemp)"
+        if [ ! -d "${ARTIFACT_SEARCH_ROOT}" ]; then
+          echo "(search root ${ARTIFACT_SEARCH_ROOT} does not exist)"
+        else
+          while IFS= read -r pattern; do
+            [ -z "$pattern" ] && continue
+            find "${ARTIFACT_SEARCH_ROOT}" -path "$pattern" 2>/dev/null >> "$matches_file" || true
+          done <<< "$ARTIFACT_PATH_GLOBS"
+          sort -u "$matches_file" -o "$matches_file"
+        fi
+        echo "matches_file=${matches_file}" >> "$GITHUB_OUTPUT"
+        echo "match_count=$(wc -l < "$matches_file")" >> "$GITHUB_OUTPUT"
+
+    - name: Print CI artifacts
+      if: ${{ inputs.artifact-path-globs != '' }}
+      shell: bash
+      env:
+        STAGE_LABEL: ${{ inputs.stage-label }}
+        SUMMARY_ONLY: ${{ inputs.summary-only }}
+        MATCHES_FILE: ${{ steps.collect.outputs.matches_file }}
+        MATCH_COUNT: ${{ steps.collect.outputs.match_count }}
+      run: |
+        echo "=== ${STAGE_LABEL} CI results (${MATCH_COUNT} file(s)) ==="
+        if [ "${MATCH_COUNT}" = "0" ]; then
+          echo "(no matching result files found)"
+          exit 0
+        fi
+        while IFS= read -r f; do
+          echo "--- $f ---"
+          if [ "$SUMMARY_ONLY" = "true" ]; then
+            python -c "import json,sys; d=json.load(open(sys.argv[1])); d.pop('per_sample',None); print(json.dumps(d, indent=2, ensure_ascii=False))" "$f"
+          else
+            cat "$f"
+          fi
+          echo ""
+        done < "${MATCHES_FILE}"
+
+    - name: Validate upload inputs
+      if: ${{ inputs.artifact-upload-name != '' && inputs.artifact-upload-path == '' }}
+      shell: bash
+      run: |
+        echo "::error::artifact-upload-name='${{ inputs.artifact-upload-name }}' requires artifact-upload-path to be set explicitly."
+        exit 1
+
+    - name: Upload CI artifacts
+      if: ${{ inputs.artifact-upload-name != '' && inputs.artifact-upload-path != '' }}
+      uses: actions/upload-artifact@v4
+      with:
+        name: ${{ inputs.artifact-upload-name }}
+        path: ${{ inputs.artifact-upload-path }}
+        if-no-files-found: ${{ inputs.artifact-if-no-files-found }}
+        retention-days: 7
+
+    - name: Kill GPU processes
+      shell: bash
+      run: |
+        bash .github/scripts/delete_gpu_process.sh

.github/workflows/test-qwen3-omni-ci.yaml

@@ -12,6 +12,13 @@ concurrency:
 permissions:
   contents: read
 
+# DAG:
+#   docs ──► stage-1-thinker ──► stage-2-tts
+#                              ├─► stage-3-mmmu
+#                              ├─► stage-4-mmmu-tts-consistency
+#                              ├─► stage-5-mmsu
+#                              └─► stage-6-mmsu-tts-consistency
+
 jobs:
   docs:
     name: docs
@@ -38,11 +45,11 @@ jobs:
         env:
           HF_ENDPOINT: https://hf-mirror.com
 
-      - name: Kill GPU processes
+      - name: Post-stage cleanup
         if: always()
-        shell: bash
-        run: |
-          bash .github/scripts/delete_gpu_process.sh
+        uses: ./.github/actions/omni-post-stage
+        with:
+          stage-label: docs
 
       - name: Save cache
         if: always()
@@ -55,10 +62,41 @@ jobs:
             echo "::warning::Skipping cache save — venv appears corrupted (torch not importable)"
           fi
 
-  stage-1-tts:
-    name: stage 1 - TTS speed + WER
+  stage-1-thinker:
+    name: stage 1 - thinker length integration
     needs: docs
     runs-on: [self-hosted]
+    timeout-minutes: 20
+    container:
+      image: frankleeeee/sglang-omni:dev
+      options: --gpus all --rm -v /dev/shm:/dev/shm
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - uses: ./.github/actions/omni-setup
+        with:
+          venv-name: omni-qwen3
+
+      - name: Run thinker length integration test
+        shell: bash
+        run: |
+          source omni-qwen3/bin/activate
+          export PYTHONPATH=$PWD
+          pytest tests/test_model/test_qwen3_omni_thinker_length.py -v -s -x
+        env:
+          HF_ENDPOINT: https://hf-mirror.com
+
+      - name: Post-stage cleanup
+        if: always()
+        uses: ./.github/actions/omni-post-stage
+        with:
+          stage-label: thinker-length
+
+  stage-2-tts:
+    name: stage 2 - TTS speed + WER
+    needs: [docs, stage-1-thinker]
+    runs-on: [self-hosted]
     timeout-minutes: 15
     container:
       image: frankleeeee/sglang-omni:dev
@@ -81,26 +119,20 @@ jobs:
           HF_ENDPOINT: https://hf-mirror.com
           SGLANG_SEEDTTS_MINI_DIR: /github/home/seedtts-mini
 
-      - name: Print TTS CI artifacts (speed + WER)
+      - name: Post-stage cleanup
         if: always()
-        shell: bash
-        run: |
-          echo "=== Qwen3-Omni TTS CI results ==="
-          for f in $(find /tmp -name "speed_results.json" -o -name "wer_results.json" 2>/dev/null); do
-            echo "--- $f ---"
-            cat "$f"
-            echo ""
-          done
-
-      - name: Kill GPU processes
-        if: always()
-        shell: bash
-        run: |
-          bash .github/scripts/delete_gpu_process.sh
-
-  stage-2-mmmu:
-    name: stage 2 - MMMU accuracy + speed
-    needs: stage-1-tts
+        uses: ./.github/actions/omni-post-stage
+        with:
+          stage-label: TTS (speed + WER)
+          artifact-path-globs: |
+            */speed_results.json
+            */wer_results.json
+          artifact-upload-name: qwen3-omni-tts-results
+          artifact-upload-path: /tmp/**/*_results.json
+
+  stage-3-mmmu:
+    name: stage 3 - MMMU accuracy + speed
+    needs: [docs, stage-1-thinker]
     runs-on: [self-hosted]
     timeout-minutes: 20
     container:
@@ -123,26 +155,19 @@ jobs:
         env:
           HF_ENDPOINT: https://hf-mirror.com
 
-      - name: Print MMMU CI artifacts (accuracy + speed)
-        if: always()
-        shell: bash
-        run: |
-          echo "=== Qwen3-Omni MMMU CI results ==="
-          for f in $(find /tmp -path '*/mmmu/mmmu_results.json' 2>/dev/null); do
-            echo "--- $f ---"
-            cat "$f"
-            echo ""
-          done
-
-      - name: Kill GPU processes
+      - name: Post-stage cleanup
         if: always()
-        shell: bash
-        run: |
-          bash .github/scripts/delete_gpu_process.sh
-
-  stage-3-mmmu-tts-consistency:
-    name: stage 3 - MMMU TTS consistency
-    needs: stage-2-mmmu
+        uses: ./.github/actions/omni-post-stage
+        with:
+          stage-label: MMMU (accuracy + speed)
+          artifact-path-globs: |
+            */mmmu/mmmu_results.json
+          artifact-upload-name: qwen3-omni-mmmu-results
+          artifact-upload-path: /tmp/**/mmmu_results.json
+
+  stage-4-mmmu-tts-consistency:
+    name: stage 4 - MMMU TTS consistency
+    needs: [docs, stage-1-thinker]
     runs-on: [self-hosted]
     timeout-minutes: 15
     container:
@@ -165,26 +190,19 @@ jobs:
         env:
           HF_ENDPOINT: https://hf-mirror.com
 
-      - name: Print MMMU TTS Consistency CI artifacts (WER + speed)
-        if: always()
-        shell: bash
-        run: |
-          echo "=== Qwen3-Omni MMMU TTS Consistency CI results ==="
-          for f in $(find /tmp -path '*/mmmu_audio/mmmu_results.json' 2>/dev/null); do
-            echo "--- $f ---"
-            cat "$f"
-            echo ""
-          done
-
-      - name: Kill GPU processes
+      - name: Post-stage cleanup
         if: always()
-        shell: bash
-        run: |
-          bash .github/scripts/delete_gpu_process.sh
-
-  stage-4-mmsu:
-    name: stage 4 - MMSU accuracy + speed
-    needs: stage-3-mmmu-tts-consistency
+        uses: ./.github/actions/omni-post-stage
+        with:
+          stage-label: MMMU TTS Consistency (WER + speed)
+          artifact-path-globs: |
+            */mmmu_audio/mmmu_results.json
+          artifact-upload-name: qwen3-omni-mmmu-tts-consistency-results
+          artifact-upload-path: /tmp/**/mmmu_audio/mmmu_results.json
+
+  stage-5-mmsu:
+    name: stage 5 - MMSU accuracy + speed
+    needs: [docs, stage-1-thinker]
     runs-on: [self-hosted]
     timeout-minutes: 20
     container:
@@ -207,27 +225,20 @@ jobs:
         env:
           HF_ENDPOINT: https://hf-mirror.com
 
-      - name: Print MMSU CI artifacts (accuracy + speed)
-        if: always()
-        shell: bash
-        run: |
-          source omni-qwen3/bin/activate
-          echo "=== Qwen3-Omni MMSU CI results (summary only) ==="
-          for f in $(find /tmp -path '*/mmsu/mmsu_results.json' 2>/dev/null); do
-            echo "--- $f ---"
-            python -c "import json,sys; d=json.load(open(sys.argv[1])); d.pop('per_sample',None); print(json.dumps(d, indent=2, ensure_ascii=False))" "$f"
-            echo ""
-          done
-
-      - name: Kill GPU processes
+      - name: Post-stage cleanup
         if: always()
-        shell: bash
-        run: |
-          bash .github/scripts/delete_gpu_process.sh
-
-  stage-5-mmsu-tts-consistency:
-    name: stage 5 - MMSU TTS consistency
-    needs: stage-4-mmsu
+        uses: ./.github/actions/omni-post-stage
+        with:
+          stage-label: MMSU (accuracy + speed, summary only)
+          artifact-path-globs: |
+            */mmsu/mmsu_results.json
+          artifact-upload-name: qwen3-omni-mmsu-results
+          artifact-upload-path: /tmp/**/mmsu/mmsu_results.json
+          summary-only: "true"
+
+  stage-6-mmsu-tts-consistency:
+    name: stage 6 - MMSU TTS consistency
+    needs: [docs, stage-1-thinker]
     runs-on: [self-hosted]
     timeout-minutes: 15
     container:
@@ -250,19 +261,12 @@ jobs:
         env:
           HF_ENDPOINT: https://hf-mirror.com
 
-      - name: Print MMSU TTS Consistency CI artifacts (WER + speed)
-        if: always()
-        shell: bash
-        run: |
-          echo "=== Qwen3-Omni MMSU TTS Consistency CI results ==="
-          for f in $(find /tmp -path '*/mmsu_audio/mmsu_results.json' 2>/dev/null); do
-            echo "--- $f ---"
-            cat "$f"
-            echo ""
-          done
-
-      - name: Kill GPU processes
+      - name: Post-stage cleanup
         if: always()
-        shell: bash
-        run: |
-          bash .github/scripts/delete_gpu_process.sh
+        uses: ./.github/actions/omni-post-stage
+        with:
+          stage-label: MMSU TTS Consistency (WER + speed)
+          artifact-path-globs: |
+            */mmsu_audio/mmsu_results.json
+          artifact-upload-name: qwen3-omni-mmsu-tts-consistency-results
+          artifact-upload-path: /tmp/**/mmsu_audio/mmsu_results.json