-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[Feature] Support mixed precision #16282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: qimcis <[email protected]>
Summary of ChangesHello @qimcis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the handling of mixed-precision compressed tensors by refining how quantization formats are interpreted. Previously, the system struggled with configurations like FP8 attention combined with INT4 MLPs because it used a global format, leading to incorrect activation quantization and scheme selection. The updated logic now processes quantization formats on a per-group basis, ensuring that each component of a mixed-precision setup receives the appropriate quantization treatment. This change improves the flexibility and correctness of mixed-precision model deployments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively adds support for mixed-precision quantization by tracking the format for each configuration group. The changes are logical and consistently applied across configuration parsing, scheme selection, and MoE layers. The addition of regression tests ensures the new functionality is working as expected. The code is well-written, and I have one suggestion to improve type safety.
|
|
||
| SPARSITY_CONFIG_NAME: Literal["sparsity_config"] = "sparsity_config" | ||
| QUANTIZATION_SCHEME_MAP_TYPE = Dict[str, Optional[Dict[str, QuantizationArgs]]] | ||
| QUANTIZATION_SCHEME_MAP_TYPE = Dict[str, Dict[str, Any]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Dict[str, Any] reduces type safety and makes the code harder to understand and maintain. A more specific type hint would be better. Since the inner dictionary contains keys 'format' (str), 'weights' (QuantizationArgs), and 'input_activations' (Optional[QuantizationArgs]), consider defining a more precise type. For example, you could import Union and use Dict[str, Dict[str, Union[str, Optional[QuantizationArgs]]]], or define a TypedDict for better clarity.
Signed-off-by: qimcis <[email protected]>
Addresses #16276
Motivation
Configs using mixed-precision compressed tensors were failing because the code relied on the top-level format. This meant we skipped activation quantization and scheme selection when the global format was "mixed-precision," breaking setups like FP8 attention with INT4 MLPs.
Modifications
Updated parsing to track each group's specific format to determine if activation quantization is needed. The scheme selection and MoE validation now check the per-target format rather than the global one. I also added a regression test for a mixed FP8 + INT4 config to verify that activations are parsed only for the FP8 group and that the correct schemes are chosen.