Skip to content

Commit 969961b

Browse files
WovchenaCopilot
andauthored
Extend copilot-instructions.md (openvinotoolkit#3332)
## Description From openvinotoolkit#2707 (comment) ## Checklist: - [x] This PR follows GenAI Contributing guidelines. <!-- Always follow https://github.com/openvinotoolkit/openvino.genai?tab=contributing-ov-file#contributing. If there are deviations, explain what and why. --> - N/A Tests have been updated or added to cover the new code. <!-- Specify exactly which tests were added or updated. If the change isn't maintenance related, update the tests at https://github.com/openvinotoolkit/openvino.genai/tree/master/tests or explain in the description why the tests don't need an update. --> - N/A This PR fully addresses the ticket. <!--- If not, explain clearly what is covered and what is not. If follow-up pull requests are needed, specify in the description. --> - N/A I have made corresponding changes to the documentation. <!-- Run github.com/\<username>/openvino.genai/actions/workflows/deploy_gh_pages.yml on your fork with your branch as a parameter to deploy a test version with the updated content. Replace this comment with the link to the built docs. If the documentation is updated in a separate PR, clearly specify it. --> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent a4d1da1 commit 969961b

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

.github/copilot-instructions.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,12 @@ When analyzing a Pull Request, follow this protocol:
3333
12. Make sure the function names are descriptive.
3434
13. Check for variables with different names but similar meaning or aliasing.
3535
14. Avoid duplicate code. Ensure that common functionality is extracted into reusable functions or utilities.
36-
15. Avoid pronouns in comments and names to make the statements concise.
37-
16. Unused functions and constructors aren't allowed except for in `debug_utils.hpp`.
38-
17. `debug_utils.hpp` must never be included.
39-
18. Assumptions on user behalf aren't allowed. For example, the implementation shouldn't adjust config values silently or with a warning; it should throw an exception instead.
40-
19. Samples:
36+
15. When initial container values are known upfront, prefer initializer-list / brace-initialization over constructing an empty container and immediately inserting values.
37+
16. Avoid pronouns in comments and names to make the statements concise.
38+
17. Unused functions and constructors aren't allowed except for in `debug_utils.hpp`.
39+
18. `debug_utils.hpp` must never be included.
40+
19. Assumptions on the user's behalf aren't allowed. For example, the implementation shouldn't adjust config values silently or with a warning; it should throw an exception instead.
41+
20. Samples:
4142
* Avoid adding new samples unless there is a strong, clearly justified reason.
4243
* Keep command‑line arguments in samples minimal.
4344
* Ensure new samples have corresponding tests.

0 commit comments

Comments
 (0)