Split bot embed across multiple Discord messages to avoid size limits

The bot embed was erroring out when it exceeded Discord's 6000 character
embed limit. Instead of aborting the update entirely, the embed now splits
bot listings into multiple messages:

- Each message gets a single embed with up to 4000 chars of bot listings
- The first message keeps the "Castle bots - last updated" title
- Overflow messages are created/updated as needed using indexed names
- Overflow messages are automatically deleted when no longer needed
- Added deleteInstructionsMessage() to InstructionsReadyAction
- Changed InstructionsReadyAction name param from Name enum to string
  to support dynamic overflow message names

https://claude.ai/code/session_01F92hfgrzp44RWTTyFXyMQB

Author: claude

src/features/raid-bots/bot-embed.ts

@@ -1,5 +1,5 @@
-import { APIEmbed, EmbedBuilder, Utils } from "discord.js";
-import { botEmbedChannelId, knightRoleId, raiderRoleId } from "../../config";
+import { EmbedBuilder } from "discord.js";
+import { botEmbedChannelId, raiderRoleId } from "../../config";
 import { Name } from "../../db/instructions";
 import { Bot } from "../../services/bot/public-accounts-sheet";
 import { InstructionsReadyAction } from "../../shared/action/instructions-ready-action-2";
@@ -27,11 +27,18 @@ const truncate = (str: string, maxLength: number) => {
   if (str.length <= maxLength) return str;
   return str.slice(0, maxLength - 3) + "...";
 };
+
+// Discord embed description limit is 4096 characters.
+// Use 4000 to leave room for formatting.
+const MAX_EMBED_DESCRIPTION = 4000;
+
+// Maximum number of overflow messages to manage.
+const MAX_OVERFLOW_MESSAGES = 5;
+
 export const refreshBotEmbed = async () => {
   const publicAccounts = PublicAccountsFactory.getService();
-  let botString = "";
   const botMessages: string[] = [];
-  const start = moment.now();
+  let botString = "";
   const bots = await publicAccounts.getBots();
 
   bots.forEach((bot: Bot) => {
@@ -51,37 +58,54 @@ export const refreshBotEmbed = async () => {
     } ${getClassAbreviation(bot.class)}) - ${bot.location} ${
       pilotName ? "~~" : ""
     } ${pilotName ? "- " + pilotName : ""}\u200B\n`;
-    if (botString.length + botRow.length > 3000) {
+    if (botString.length + botRow.length > MAX_EMBED_DESCRIPTION) {
       botMessages.push(botString);
       botString = "";
     }
     botString += botRow;
   });
 
-  if (botString.length > 6000) {
-    console.log(`Embed length too long (${botString.length}), 
-      not attempting update`);
-    return;
+  if (botString) {
+    botMessages.push(botString);
   }
 
-  botMessages.push(botString);
-  try {
+  // Send the first message using the primary instruction action
+  if (botMessages.length > 0) {
     await botEmbedInstructions
       .createOrUpdateInstructions({
-        embeds: botMessages.map((message: string, idx: number) => {
-          return new EmbedBuilder({
-            title:
-              idx === 0
-                ? `Castle bots - last updated ${moment().toLocaleString()}`
-                : "",
-            description: message,
-          });
-        }),
+        embeds: [
+          new EmbedBuilder({
+            title: `Castle bots - last updated ${moment().toLocaleString()}`,
+            description: botMessages[0],
+          }),
+        ],
       })
       .catch((reason) => {
         log(`Embed update failed: ${reason}`);
       });
-  } catch (err: unknown) {
-    log("Failed to update bot embed");
+  }
+
+  // Send overflow messages or clean up ones that are no longer needed
+  for (let i = 1; i <= MAX_OVERFLOW_MESSAGES; i++) {
+    const overflowAction = new InstructionsReadyAction(
+      `${Name.BotStatusEmbed}_${i}`,
+      botEmbedChannelId
+    );
+    if (i < botMessages.length) {
+      await overflowAction
+        .createOrUpdateInstructions({
+          embeds: [
+            new EmbedBuilder({
+              description: botMessages[i],
+            }),
+          ],
+        })
+        .catch((reason) => {
+          log(`Overflow embed ${i} update failed: ${reason}`);
+        });
+    } else {
+      // Delete overflow messages that are no longer needed
+      await overflowAction.deleteInstructionsMessage().catch(() => {});
+    }
   }
 };

src/shared/action/instructions-ready-action-2.ts

@@ -1,11 +1,11 @@
 import { DiscordAPIError, BaseMessageOptions } from "discord.js";
 import { dataSource } from "../../db/data-source";
-import { Instructions, Name } from "../../db/instructions";
+import { Instructions } from "../../db/instructions";
 import { getTextChannel } from "../..";
 
 export class InstructionsReadyAction {
   public constructor(
-    private readonly name: Name,
+    private readonly name: string,
     private readonly channelId: string,
     private readonly threadName?: string
   ) {}
@@ -39,6 +39,20 @@ export class InstructionsReadyAction {
     }
   }
 
+  public async deleteInstructionsMessage() {
+    const message = await this.getInstructionsMessage();
+    if (message) {
+      await message.delete();
+    }
+    const instructions = await dataSource
+      .getRepository(Instructions)
+      .findOneBy({ name: this.name, canceled: false });
+    if (instructions) {
+      instructions.canceled = true;
+      await dataSource.manager.save(instructions);
+    }
+  }
+
   public async getThread() {
     const embed = await this.getInstructionsMessage();
     return embed?.thread;