Skip to content

Commit 3577948

Browse files
committed
Refactor permission handling
1 parent 3107e50 commit 3577948

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

codec2talkie/src/main/java/com/radio/codec2talkie/MainActivity.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -669,14 +669,7 @@ public boolean onTouch(View v, MotionEvent event) {
669669
public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
670670
super.onRequestPermissionsResult(requestCode, permissions, grantResults);
671671
if (requestCode == PermissionsManager.REQUEST_PERMISSIONS) {
672-
boolean allGranted = true;
673-
for (int result : grantResults) {
674-
if (result != PackageManager.PERMISSION_GRANTED) {
675-
allGranted = false;
676-
break;
677-
}
678-
}
679-
if (allGranted) {
672+
if (PermissionsManager.allGranted(grantResults)) {
680673
Toast.makeText(MainActivity.this, R.string.permissions_granted, Toast.LENGTH_SHORT).show();
681674
} else {
682675
Toast.makeText(MainActivity.this, R.string.permissions_denied, Toast.LENGTH_SHORT).show();

codec2talkie/src/main/java/com/radio/codec2talkie/tools/PermissionsManager.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import android.content.pm.PackageManager;
77
import android.os.Build;
88

9+
import androidx.annotation.NonNull;
910
import androidx.core.app.ActivityCompat;
1011
import androidx.core.content.ContextCompat;
1112

@@ -37,6 +38,17 @@ private static List<String> getRequiredPermissions() {
3738
return versionRequiredPermissions;
3839
}
3940

41+
public static boolean allGranted(@NonNull int[] grantResults) {
42+
boolean allGranted = true;
43+
for (int result : grantResults) {
44+
if (result != PackageManager.PERMISSION_GRANTED) {
45+
allGranted = false;
46+
break;
47+
}
48+
}
49+
return allGranted;
50+
}
51+
4052
public static boolean requestPermissions(Activity activity) {
4153
List<String> permissionsToRequest = new LinkedList<>();
4254
List<String> versionRequiredPermissions = getRequiredPermissions();

0 commit comments

Comments
 (0)