[CIR][NFC] Fix multiple warnings from latest PRs

Author: bcardosolopes

clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp

@@ -227,14 +227,11 @@ makeBinaryAtomicValue(CIRGenFunction &cgf, mlir::cir::AtomicFetchKind kind,
 
   Address destAddr = checkAtomicAlignment(cgf, expr);
   auto &builder = cgf.getBuilder();
-  auto *ctxt = builder.getContext();
   auto intType = builder.getSIntNTy(cgf.getContext().getTypeSize(typ));
   mlir::Value val = cgf.buildScalarExpr(expr->getArg(1));
   mlir::Type valueType = val.getType();
   val = buildToInt(cgf, val, typ, intType);
 
-  auto fetchAttr =
-      mlir::cir::AtomicFetchKindAttr::get(builder.getContext(), kind);
   auto rmwi = builder.create<mlir::cir::AtomicFetch>(
       cgf.getLoc(expr->getSourceRange()), destAddr.emitRawPointer(), val, kind,
       ordering, false, /* is volatile */

clang/lib/CIR/CodeGen/CIRGenDecl.cpp

@@ -631,9 +631,6 @@ void CIRGenFunction::buildStaticVarDecl(const VarDecl &D,
   if (D.getType()->isVariablyModifiedType())
     llvm_unreachable("VLAs are NYI");
 
-  // Save the type in case adding the initializer forces a type change.
-  mlir::Type expectedType = addr.getType();
-
   auto var = globalOp;
 
   // CUDA's local and local static __shared__ variables should not

clang/lib/CIR/CodeGen/CIRGenStmt.cpp

@@ -655,7 +655,7 @@ CIRGenFunction::foldCaseStmt(const clang::CaseStmt &S, mlir::Type condType,
   for (int i = 1; i < caseAttrCount; ++i) {
     // If there are multiple case attributes, we need to create a new region
     auto *region = currLexScope->createSwitchRegion();
-    auto *block = builder.createBlock(region);
+    builder.createBlock(region);
   }
 
   return lastCase;

clang/lib/CIR/Dialect/IR/CIRDialect.cpp

@@ -1150,6 +1150,7 @@ void printSwitchOp(OpAsmPrinter &p, SwitchOp op,
     case cir::CaseOpKind::Range:
       assert(attr.getValue().size() == 2 && "range must have two values");
       // The print format of the range is the same as anyof
+      LLVM_FALLTHROUGH;
     case cir::CaseOpKind::Anyof: {
       p << ", [";
       llvm::interleaveComma(attr.getValue(), p, [&](const Attribute &a) {

clang/lib/CIR/Dialect/Transforms/FlattenCFG.cpp

@@ -356,8 +356,6 @@ class CIRSwitchOpFlattening
           caseDestinations.push_back(&region.front());
         }
         break;
-      default:
-        llvm_unreachable("unsupported case kind");
       }
 
       // Previous case is a fallthrough: branch it to this case.
@@ -405,7 +403,7 @@ class CIRSwitchOpFlattening
       constexpr int kSmallRangeThreshold = 64;
       if ((upperBound - lowerBound)
               .ult(llvm::APInt(32, kSmallRangeThreshold))) {
-        for (auto iValue = lowerBound; iValue.sle(upperBound); iValue++) {
+        for (auto iValue = lowerBound; iValue.sle(upperBound); (void)iValue++) {
           caseValues.push_back(iValue);
           caseOperands.push_back(rangeOperands[index]);
           caseDestinations.push_back(rangeDestinations[index]);