[CIR][CIRGen] Implement VisitBinComma for aggregates

Author: bcardosolopes

clang/lib/CIR/CodeGen/CIRGenExprAgg.cpp

@@ -259,7 +259,7 @@ class AggExprEmitter : public StmtVisitor<AggExprEmitter> {
                       E->getType());
   }
 
-  void VisitBinComma(const BinaryOperator *E) { llvm_unreachable("NYI"); }
+  void VisitBinComma(const BinaryOperator *E);
   void VisitBinCmp(const BinaryOperator *E);
   void VisitCXXRewrittenBinaryOperator(CXXRewrittenBinaryOperator *E) {
     llvm_unreachable("NYI");
@@ -1351,6 +1351,11 @@ void AggExprEmitter::VisitAbstractConditionalOperator(
   assert(!UnimplementedFeature::incrementProfileCounter());
 }
 
+void AggExprEmitter::VisitBinComma(const BinaryOperator *E) {
+  CGF.buildIgnoredExpr(E->getLHS());
+  Visit(E->getRHS());
+}
+
 //===----------------------------------------------------------------------===//
 //                        Helpers and dispatcher
 //===----------------------------------------------------------------------===//

clang/test/CIR/CodeGen/struct-comma.c

@@ -0,0 +1,14 @@
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir %s -o %t.cir
+// RUN: FileCheck --input-file=%t.cir %s
+
+struct AA {int a, b;} x;
+extern int r(void);
+void a(struct AA* b) {*b = (r(), x);}
+
+// CHECK-LABEL: @a
+// CHECK: %[[ADDR:.*]] = cir.alloca {{.*}} ["b"
+// CHECK: cir.store {{.*}}, %[[ADDR]]
+// CHECK: %[[LOAD:.*]] = cir.load deref %[[ADDR]]
+// CHECK: cir.call @r
+// CHECK: %[[GADDR:.*]] = cir.get_global @x
+// CHECK: cir.copy %[[GADDR]] to %[[LOAD]]