Using golangci-lint (#2)

Author: shahradelahi

.github/workflows/linter.yml

@@ -0,0 +1,31 @@
+name: Linter
+
+concurrency:
+  group: linter-${{ github.event_name }}-${{ github.ref }}
+  cancel-in-progress: true
+
+on:
+  push:
+    branches:
+      - 'main'
+  pull_request:
+
+jobs:
+  linter:
+    name: Linter
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v5
+
+      - name: Setup Go
+        uses: actions/setup-go@v5
+        with:
+          check-latest: true
+          go-version-file: 'go.mod'
+
+      - name: GolangCI lint
+        uses: golangci/golangci-lint-action@v8
+        with:
+          version: latest
+          args: -v

.golangci.yaml

@@ -0,0 +1,40 @@
+version: "2"
+
+run:
+  timeout: 5m
+
+linters:
+  default: none
+  enable:
+    - cyclop
+    - govet
+    - ineffassign
+    - misspell
+    - staticcheck
+    - unconvert
+    - unused
+    - usestdlibvars
+
+  settings:
+    cyclop:
+      max-complexity: 20
+      package-average: 10.0
+
+  exclusions:
+    rules:
+      - path: _test\.go$
+        linters:
+          - cyclop
+          - errcheck
+
+formatters:
+  enable:
+    - gci
+    - gofmt
+  settings:
+    gci:
+      custom-order: true
+      sections:
+        - standard
+        - default
+        - prefix(github.com/shahradelahi/wiresocks)

cmd/wiresocks/main.go

@@ -89,6 +89,7 @@ var rootCmd = &cobra.Command{
 		sigChan := make(chan os.Signal, 1)
 		signal.Notify(sigChan, syscall.SIGINT, syscall.SIGTERM)
 		ctx, cancel := context.WithCancel(context.Background())
+		defer cancel()
 
 		logLevel := wiresocks.LogLevelVerbose
 		if silent {

proxy/socks5/common.go

@@ -167,15 +167,6 @@ func readBytes(r io.Reader) ([]byte, error) {
 	return bytes, nil
 }
 
-func writeBytes(w io.Writer, b []byte) error {
-	_, err := w.Write([]byte{byte(len(b))})
-	if err != nil {
-		return err
-	}
-	_, err = w.Write(b)
-	return err
-}
-
 func readByte(r io.Reader) (byte, error) {
 	var buf [1]byte
 	_, err := r.Read(buf[:])

proxy/socks5/server.go

@@ -432,7 +432,7 @@ func (s *Server) handleAssociate(req *request) error {
 			if err != nil {
 				return fmt.Errorf("failed to write UDP packet to source %s for SOCKS5 UDP ASSOCIATE: %w", sourceAddr.String(), err)
 			}
-		} else {
+		} else { //nolint:staticcheck
 			// Ignoring UDP packet from unknown source
 		}
 	}

proxy/statute/tunnel.go

@@ -12,6 +12,8 @@ import (
 
 // isClosedConnError reports whether err is an error from use of a closed
 // network connection.
+//
+//nolint:unused
 func isClosedConnError(err error) bool {
 	if err == nil {
 		return false
@@ -36,6 +38,7 @@ func isClosedConnError(err error) bool {
 	return false
 }
 
+//nolint:unused
 func errno(v error) uintptr {
 	if rv := reflect.ValueOf(v); rv.Kind() == reflect.Uintptr {
 		return uintptr(rv.Uint())
@@ -67,8 +70,10 @@ func Tunnel(ctx context.Context, c1, c2 io.ReadWriteCloser, buf1, buf2 []byte) e
 	}
 }
 
+//nolint:unused
 type tunnelErr [5]error
 
+//nolint:unused
 func (t tunnelErr) FirstError() error {
 	for _, err := range t {
 		if err != nil {

vtun.go

@@ -84,7 +84,7 @@ func (vt VirtualTun) CheckConnectivity(ctx context.Context, url string, timeout
 			DialContext: vt.Tnet.DialContext,
 		}}
 
-		req, err := http.NewRequestWithContext(ctx, "HEAD", url, nil)
+		req, err := http.NewRequestWithContext(ctx, http.MethodHead, url, nil)
 		if err != nil {
 			return fmt.Errorf("failed to create connectivity test request: %w", err)
 		}