Skip to content

Commit 3a2378d

Browse files
authored
ci: Do not persist credentials after checkout (#112)
See actions/checkout#485 and https://johnstawinski.com/2024/01/11/playing-with-fire-how-we-executed-a-critical-supply-chain-attack-on-pytorch/ In short, it is a terrible idea to persist even our default credentials after checkout. There's no call for that, so we will now set `persist-credentials: false` on all checkout actions.
1 parent 16c9880 commit 3a2378d

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

.github/workflows/release-please.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ jobs:
2424
uses: actions/checkout@v4
2525
with:
2626
ref: refs/tags/${{ steps.release.outputs.tag_name }}
27+
persist-credentials: false
2728
if: steps.release.outputs.releases_created
2829

2930
- name: Setup Node.js

.github/workflows/test.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ jobs:
2929
uses: actions/checkout@v4
3030
with:
3131
ref: ${{ github.ref }}
32+
persist-credentials: false
3233

3334
- name: Setup Node.js ${{ matrix.node-version }}
3435
uses: actions/setup-node@v4

0 commit comments

Comments
 (0)